Skip to content

Commit 8e6ffa7

Browse files
committed
chat xdd protection
1 parent a774870 commit 8e6ffa7

File tree

2 files changed

+15
-4
lines changed

2 files changed

+15
-4
lines changed

src/client/scripts/Chat.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,9 @@ class Chat {
5353
}
5454

5555
log(message) {
56-
const replacements = [[/&/g, "&amp;"], [/</g, "&lt;"], [/>/g, "&gt;"], [/"/g, "&quot;"]];
57-
for (const replacement of replacements)
58-
message = message.replace(replacement[0], replacement[1]);
59-
$(".chat").append(`<span>${message}<br></span>`);
56+
let elem = document.createElement("div");
57+
elem.innerHTML = message + "<br>";
58+
this.chatDiv.append(elem);
6059
this.scrollToBottom(this.chatDiv);
6160
}
6261

src/index.js

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,18 @@ io.sockets.on("connection", function (socket) {
7575
socket.emit("kicked", reason);
7676
});
7777
bot.on("message", function (msg) {
78+
let message = msg.extra[0].text;
79+
80+
const replacements = [
81+
[/&/g, "&amp;"],
82+
[/</g, "&lt;"],
83+
[/>/g, "&gt;"],
84+
[/"/g, "&quot;"],
85+
];
86+
for (const replacement of replacements)
87+
message = message.replace(replacement[0], replacement[1]);
88+
msg.extra[0].text = message;
89+
7890
socket.emit("msg", convert.toHtml(msg.toAnsi()));
7991
});
8092
bot.on("experience", function () {

0 commit comments

Comments
 (0)