lint code

Author: michaljaz

index.js

@@ -2,7 +2,6 @@ const { app } = require('./lib/server.js')
 const helmet = require('helmet')
 const middleware = require('webpack-dev-middleware')
 const config = require('./src/webpack.dev.js')
-const path = require('path')
 const compression = require('compression')
 const webpack = require('webpack')
 

lib/postinstall.js

@@ -1,5 +1,4 @@
 const decompress = require('decompress')
-const decompressTarxz = require('decompress-tarxz')
 const path = require('path')
 
 decompress(

lib/proxy.js

@@ -18,7 +18,7 @@ function checkTo (allowed, requested) {
   for (let i = 0; i < allowed.length; i++) {
     const to = allowed[i]
 
-    if ((to.host == requested.host || !to.host) && (to.port == requested.port || !to.port)) {
+    if ((to.host === requested.host || !to.host) && (to.port === requested.port || !to.port)) {
       if (to.blacklist) { // This item is blacklisted
         return false
       } else { // Otheriwse, it's whitelisted
@@ -67,7 +67,7 @@ module.exports = function (options, connectionListener) {
 
         res.header('Access-Control-Allow-Origin', allowOrigin)
 
-        if (req.method.toUpperCase() == 'OPTIONS') { // Preflighted requests
+        if (req.method.toUpperCase() === 'OPTIONS') { // Preflighted requests
           res.header('Access-Control-Allow-Methods', 'GET, POST, OPTIONS')
           res.header('Access-Control-Allow-Headers', 'Content-Type')
 
@@ -99,7 +99,7 @@ module.exports = function (options, connectionListener) {
       }
     }
 
-    var socket = net.connect({
+    const socket = net.connect({
       host: host,
       port: port
     }, function (err) {
@@ -146,7 +146,7 @@ module.exports = function (options, connectionListener) {
     }
   })
 
-  const wss = expressWs(app, server)
+  expressWs(app, server)
 
   app.ws(urlRoot + '/socket', function (ws, req) {
     const token = req.query.token
@@ -170,7 +170,7 @@ module.exports = function (options, connectionListener) {
     socket.on('data', function (chunk) {
       // myLog('Received: ', chunk.toString());
       // Providing a callback is important, otherwise errors can be thrown
-      ws.send(chunk, { binary: true }, function (err) {})
+      ws.send(chunk, { binary: true }, function (err) { if (err !== undefined) { console.log(err) } })
     })
     socket.on('end', function () {
       myLog('TCP connection closed by remote (' + token + ')')

src/scripts/EventHandler.js

@@ -192,33 +192,17 @@ class EventHandler {
       })
     }
     const lockChangeAlert = () => {
-      if (
-        document.pointerLockElement === this.game.canvas ||
-                document.mozPointerLockElement === this.game.canvas
-      ) {
+      if (document.pointerLockElement === this.game.canvas || document.mozPointerLockElement === this.game.canvas) {
         if (this.gameState === 'game') {
           this.setState('gameLock')
         }
-      } else if (
-        this.gameState === 'gameLock' &&
-                this.gameState !== 'inventory'
-      ) {
+      } else if (this.gameState === 'gameLock' && this.gameState !== 'inventory') {
         this.setState('menu')
       }
     }
     document.addEventListener('pointerlockchange', lockChangeAlert, false)
-    document.addEventListener(
-      'mozpointerlockchange',
-      lockChangeAlert,
-      false
-    )
-    document.addEventListener(
-      'mousemove',
-      (e) => {
-        return this.updatePosition(e)
-      },
-      false
-    )
+    document.addEventListener('mozpointerlockchange', lockChangeAlert, false)
+    document.addEventListener('mousemove', (e) => { return this.updatePosition(e) }, false)
   }
 
   updatePosition (e) {

src/scripts/Setup.js

@@ -1,6 +1,6 @@
 import Stats from 'three/examples/jsm/libs/stats.module.js'
 import * as dat from 'three/examples/jsm/libs/dat.gui.module.js'
-import { WebGLRenderer, Scene, PerspectiveCamera, AmbientLight, Mesh, BoxGeometry, MeshBasicMaterial } from 'three'
+import { WebGLRenderer, Scene, PerspectiveCamera, AmbientLight } from 'three'
 import { DistanceBasedFog } from './rendering/DistanceBasedFog.js'
 import { UrlParams } from './UrlParams.js'
 import { gpuInfo } from './additional/gpuInfo.js'

src/scripts/additional/tools.js

@@ -6,7 +6,7 @@ const antiXSS = (str) => {
     [/"/g, '"']
   ]
   for (const replacement of replacements) {
-  	str = str.replace(replacement[0], replacement[1])
+    str = str.replace(replacement[0], replacement[1])
   }
   return str
 }

src/scripts/proxy/Proxy.worker.js

@@ -4,7 +4,6 @@ import Convert from 'ansi-to-html'
 import { antiXSS } from './../additional/tools.js'
 const convert = new Convert()
 importScripts('./mineflayer.js')
-mineflayer = mineflayer.default
 
 global.window = self
 let bot = null
@@ -22,7 +21,7 @@ addEventListener('message', function (e) {
     case 'init':
       data = data[0]
       console.log(data)
-      bot = mineflayer(null, data.hostname, data.port, {
+      bot = self.mineflayer.default(null, data.hostname, data.port, {
         host: data.server,
         port: data.serverPort,
         username: data.nick

src/scripts/world/AnimatedTextureAtlas.js

@@ -1,6 +1,5 @@
 import {
   MeshStandardMaterial,
-  TextureLoader,
   NearestFilter,
   NearestMipmapLinearFilter,
   CanvasTexture

src/scripts/world/chunk.worker.js

@@ -86,7 +86,6 @@ class TerrainManager {
     let nearestDistance = -1
     let isNearest = false
     for (const chunkId in this.chunkNeedsUpdate) {
-      const pos = this.chunkTerrain.strToVec(chunkId)
       const dist = this.distance(chunkId)
       if (
         (nearestDistance === -1 || nearestDistance > dist) &&

src/vendor/browser.js

@@ -1,12 +1,12 @@
+/* global WebSocket,Blob,FileReader */
 const stream = require('stream')
 const util = require('util')
-const timers = require('timers')
 const http = require('http')
 
 const debug = util.debuglog('net')
 
 const proxy = {
-  protocol: (window.location.protocol == 'https:') ? 'wss' : 'ws',
+  protocol: (window.location.protocol === 'https:') ? 'wss' : 'ws',
   hostname: window.location.hostname,
   port: window.location.port,
   path: '/api/vm/net'
@@ -55,14 +55,14 @@ exports.connect = exports.createConnection = function (/* options, connectListen
 function toNumber (x) { return (x = Number(x)) >= 0 ? x : false }
 
 function isPipeName (s) {
-  return util.isString(s) && toNumber(s) === false
+  return typeof s === 'string' && toNumber(s) === false
 }
 
 // Returns an array [options] or [options, cb]
 // It is the same as the argument of Socket.prototype.connect().
 function normalizeConnectArgs (args) {
   let options = {}
-  if (util.isObject(args[0])) {
+  if (typeof args[0] === 'object') {
     // connect(options, [cb])
     options = args[0]
   } else if (isPipeName(args[0])) {
@@ -71,12 +71,12 @@ function normalizeConnectArgs (args) {
   } else {
     // connect(port, [host], [cb])
     options.port = args[0]
-    if (util.isString(args[1])) {
+    if (typeof args[1] === 'string') {
       options.host = args[1]
     }
   }
   const cb = args[args.length - 1]
-  return util.isFunction(cb) ? [options, cb] : [options]
+  return typeof cb === 'function' ? [options, cb] : [options]
 }
 exports._normalizeConnectArgs = normalizeConnectArgs
 
@@ -86,8 +86,9 @@ function Socket (options) {
   this._connecting = false
   this._host = null
 
-  if (util.isNumber(options)) { options = { fd: options } } // Legacy interface.
-  else if (util.isUndefined(options)) { options = {} }
+  if (typeof options === 'number') {
+    options = { fd: options }
+  } else if (typeof options === 'undefined') { options = {} }
 
   stream.Duplex.call(this, options)
 
@@ -98,7 +99,7 @@ function Socket (options) {
   this._writableState.decodeStrings = false
 
   // default to *not* allowing half open sockets
-  this.allowHalfOpen = options && options.allowHalfOpen || false
+  this.allowHalfOpen = (options && options.allowHalfOpen) || false
 }
 util.inherits(Socket, stream.Duplex)
 
@@ -235,9 +236,9 @@ Socket.prototype._write = function (data, encoding, cb) {
   this._pendingData = null
   this._pendingEncoding = ''
 
-  if (encoding == 'binary' && typeof data === 'string') { // TODO: maybe apply this for all string inputs?
+  if (encoding === 'binary' && typeof data === 'string') { // TODO: maybe apply this for all string inputs?
     // Setting encoding is very important for binary data - otherwise the data gets modified
-    data = new Buffer(data, encoding)
+    data = Buffer.alloc(data, encoding)
   }
 
   // Send the data
@@ -251,14 +252,14 @@ Socket.prototype._write = function (data, encoding, cb) {
 }
 
 Socket.prototype.write = function (chunk, encoding, cb) {
-  if (!util.isString(chunk) && !util.isBuffer(chunk)) { throw new TypeError('invalid data') }
+  if (typeof chunk !== 'string' && !Buffer.isBuffer(chunk)) { throw new TypeError('invalid data') }
   return stream.Duplex.prototype.write.apply(this, arguments)
 }
 
 Socket.prototype.connect = function (options, cb) {
   const self = this
 
-  if (!util.isObject(options)) {
+  if (typeof options !== 'object') {
     // Old API:
     // connect(port, [host], [cb])
     // connect(path, [cb]);
@@ -374,22 +375,22 @@ Socket.prototype._handleWebsocket = function () {
     }
 
     if (typeof contents === 'string') {
-      const buffer = new Buffer(contents)
+      const buffer = Buffer.alloc(contents)
       gotBuffer(buffer)
     } else if (window.Blob && contents instanceof Blob) {
       const fileReader = new FileReader()
       fileReader.addEventListener('load', function (e) {
         const buf = fileReader.result
         const arr = new Uint8Array(buf)
-        gotBuffer(new Buffer(arr))
+        gotBuffer(Buffer.from(arr))
       })
       fileReader.readAsArrayBuffer(contents)
     } else {
       console.warn('Cannot read TCP stream: unsupported message type', contents)
     }
   })
   this._ws.addEventListener('close', function () {
-    if (self.readyState == 'open') {
+    if (self.readyState === 'open') {
       // console.log('TCP closed');
       self.destroy()
     }