Skip to content

Commit fe7c4cb

Browse files
committed
dashes as valid character for mysql databases
1 parent 868f905 commit fe7c4cb

File tree

2 files changed

+21
-19
lines changed

2 files changed

+21
-19
lines changed

func/db.sh

Lines changed: 20 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -102,17 +102,19 @@ add_mysql_database() {
102102
exit $E_DB
103103
fi
104104

105-
query="CREATE DATABASE $database CHARACTER SET $charset"
105+
106+
query="CREATE DATABASE \`$database\` CHARACTER SET $charset"
106107
mysql -h $HOST -u $USER -p$PASSWORD -P $PORT -e "$query" &> /dev/null
107108

108-
query="GRANT ALL ON $database.* TO '$dbuser'@'%' IDENTIFIED BY '$dbpass'"
109+
query="GRANT ALL ON \`$database\`.* TO \`$dbuser\`@\`%\`
110+
IDENTIFIED BY '$dbpass'"
109111
mysql -h $HOST -u $USER -p$PASSWORD -P $PORT -e "$query" &> /dev/null
110112

111-
query="GRANT ALL ON $database.* TO '$dbuser'@'localhost'
113+
query="GRANT ALL ON \`$database\`.* TO \`$dbuser\`@localhost
112114
IDENTIFIED BY '$dbpass'"
113115
mysql -h $HOST -u $USER -p$PASSWORD -P $PORT -e "$query" &> /dev/null
114116

115-
query="SHOW GRANTS FOR '$dbuser'"
117+
query="SHOW GRANTS FOR \`$dbuser\`"
116118
md5=$(mysql -h $HOST -u $USER -p$PASSWORD -P $PORT -e "$query")
117119
md5=$(echo "$md5" |grep 'PASSWORD' |tr ' ' '\n' |tail -n1 |cut -f 2 -d \')
118120
}
@@ -215,10 +217,11 @@ change_mysql_password() {
215217
exit $E_DB
216218
fi
217219

218-
query="GRANT ALL ON $database.* TO '$DBUSER'@'%' IDENTIFIED BY '$dbpass'"
220+
query="GRANT ALL ON \`$database\`.* TO \`$DBUSER\`@\`%\`
221+
IDENTIFIED BY '$dbpass'"
219222
mysql -h $HOST -u $USER -p$PASSWORD -P $PORT -e "$query" &> /dev/null
220223

221-
query="GRANT ALL ON $database.* TO '$DBUSER'@'localhost'
224+
query="GRANT ALL ON \`$database\`.* TO \`$DBUSER\`@localhost
222225
IDENTIFIED BY '$dbpass'"
223226
mysql -h $HOST -u $USER -p$PASSWORD -P $PORT -e "$query" &> /dev/null
224227

@@ -271,13 +274,13 @@ delete_mysql_database() {
271274
exit $E_DB
272275
fi
273276

274-
query="DROP DATABASE $database"
277+
query="DROP DATABASE \`$database\`"
275278
mysql -h $HOST -u $USER -p$PASSWORD -P $PORT -e "$query" &> /dev/null
276279

277-
query="REVOKE ALL ON $database.* FROM '$DBUSER'@'%'"
280+
query="REVOKE ALL ON \`$database\`.* FROM \`$DBUSER\`@\`%\`"
278281
mysql -h $HOST -u $USER -p$PASSWORD -P $PORT -e "$query" &> /dev/null
279282

280-
query="REVOKE ALL ON $database.* FROM '$DBUSER'@'localhost'"
283+
query="REVOKE ALL ON \`$database\`.* FROM \`$DBUSER\`@localhost"
281284
mysql -h $HOST -u $USER -p$PASSWORD -P $PORT -e "$query" &> /dev/null
282285

283286
if [ "$(grep "DBUSER='$DBUSER'" $USER_DATA/db.conf |wc -l)" -lt 2 ]; then
@@ -409,12 +412,11 @@ suspend_mysql_database() {
409412
exit $E_DB
410413
fi
411414

412-
query="REVOKE ALL ON $database.* FROM '$DBUSER'@'%'"
415+
query="REVOKE ALL ON \`$database\`.* FROM \`$DBUSER\`@\`%\`"
413416
mysql -h $HOST -u $USER -p$PASSWORD -P $PORT -e "$query" &> /dev/null
414417

415-
query="REVOKE ALL ON $database.* FROM '$DBUSER'@'localhost'"
418+
query="REVOKE ALL ON \`$database\`.* FROM \`$DBUSER\`@localhost"
416419
mysql -h $HOST -u $USER -p$PASSWORD -P $PORT -e "$query" &> /dev/null
417-
418420
}
419421

420422
# Suspend PostgreSQL database
@@ -458,10 +460,10 @@ unsuspend_mysql_database() {
458460
exit $E_DB
459461
fi
460462

461-
query="GRANT ALL ON $database.* FROM '$DBUSER'@'%'"
463+
query="GRANT ALL ON \`$database\`.* FROM \`$DBUSER\`@\`%\`"
462464
mysql -h $HOST -u $USER -p$PASSWORD -P $PORT -e "$query" &> /dev/null
463465

464-
query="GRANT ALL ON $database.* TO '$DBUSER'@'localhost'"
466+
query="GRANT ALL ON \`$database\`.* TO \`$DBUSER\`@localhost"
465467
mysql -h $HOST -u $USER -p$PASSWORD -P $PORT -e "$query" &> /dev/null
466468
}
467469

@@ -507,7 +509,7 @@ get_mysql_disk_usage() {
507509
fi
508510

509511
query="SELECT SUM( data_length + index_length ) / 1024 / 1024 \"Size\"
510-
FROM information_schema.TABLES WHERE table_schema='$database'"
512+
FROM information_schema.TABLES WHERE table_schema=\`$database\`"
511513
usage=$(mysql -h $HOST -u $USER -p$PASSWORD -P $PORT -e "$query" |tail -n1)
512514
if [ "$usage" == 'NULL' ] || [ "${usage:0:1}" -eq '0' ]; then
513515
usage=1
@@ -566,13 +568,13 @@ rebuild_mysql_database() {
566568
exit $E_DB
567569
fi
568570

569-
query="CREATE DATABASE $database CHARACTER SET $CHARSET"
571+
query="CREATE DATABASE \`$database\` CHARACTER SET $CHARSET"
570572
mysql -h $HOST -u $USER -p$PASSWORD -P $PORT -e "$query" &> /dev/null
571573

572-
query="GRANT ALL ON $database.* TO '$DBUSER'@'%'"
574+
query="GRANT ALL ON \`$database\`.* TO \`$DBUSER\`@\`%\`"
573575
mysql -h $HOST -u $USER -p$PASSWORD -P $PORT -e "$query" &> /dev/null
574576

575-
query="GRANT ALL ON $database.* TO '$DBUSER'@'localhost'"
577+
query="GRANT ALL ON \`$database\`.* TO \`$DBUSER\`@localhost"
576578
mysql -h $HOST -u $USER -p$PASSWORD -P $PORT -e "$query" &> /dev/null
577579

578580
query="UPDATE mysql.user SET Password='$MD5' WHERE User='$DBUSER';"

func/main.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -590,7 +590,7 @@ validate_format_domain_alias() {
590590

591591
# Database
592592
validate_format_database() {
593-
exclude="[!|@|#|$|^|&|*|(|)|+|-|=|{|}|:|,|.|<|>|?|/|\|\"|'|;|%|\`| ]"
593+
exclude="[!|@|#|$|^|&|*|(|)|+|=|{|}|:|,|.|<|>|?|/|\|\"|'|;|%|\`| ]"
594594
if [[ "$1" =~ $exclude ]] || [ 17 -le ${#1} ]; then
595595
echo "Error: $2 $1 is not valid"
596596
log_event "$E_INVALID" "$EVENT"

0 commit comments

Comments
 (0)