Minor code quality improvements (hestiacp#2298)

* General code clean up (line spacings, comments, typos)

Clarified language in upgrade scripts
Fixed typo for File Manager version check
Added comment headers to function libraries
Add comment headers to manual upgrade scripts
Clarify upgrade messages and comments

* SDK: Add blank script template

* Minor fixes to installer scripts (comments/code parity)

* Changed hesita.conf to hestia.conf
* Clarified comments
* Moved code block for initial port setting to align with Debian installer and trigger after hestia.conf is created 
Add documentation link to installer
Update warning prompt at end of install
Fix comment and command order
Fix capitalization of iptables

* Fix capitalization of phpMyAdmin/phpPgAdmin

Author: Kristan Kenney

bin/v-acknowledge-user-notification

@@ -1,15 +1,13 @@
 #!/bin/bash
 # info: update user notification
 # options: USER NOTIFICATION
-# labels: panel
 #
 # example: v-acknowledge-user-notification
 #
-# The function updates user notification.
-
+# This function updates user notification.
 
 #----------------------------------------------------------#
-#                    Variable&Function                     #
+#                Variables & Functions                     #
 #----------------------------------------------------------#
 
 # Argument definition
@@ -23,6 +21,7 @@ source /etc/hestiacp/hestia.conf
 source $HESTIA/func/main.sh
 # load config file
 source_conf "$HESTIA/conf/hestia.conf"
+
 #----------------------------------------------------------#
 #                    Verifications                         #
 #----------------------------------------------------------#
@@ -34,7 +33,6 @@ is_object_valid 'user' 'USER' "$user"
 # Perform verification if read-only mode is enabled
 check_hestia_demo_mode
 
-
 #----------------------------------------------------------#
 #                       Action                             #
 #----------------------------------------------------------#

bin/v-add-backup-host

@@ -1,15 +1,14 @@
 #!/bin/bash
 # info: add backup host
 # options: TYPE HOST USERNAME PASSWORD [PATH] [PORT]
-# labels: 
 #
 # example: v-add-backup-host sftp backup.acme.com admin p4$$w@Rd
 #          v-add-backup-host b2 bucketName keyID applicationKey
 #
 # Add a new remote backup location. Currently SFTP, FTP and Backblaze are supported 
 
 #----------------------------------------------------------#
-#                    Variable&Function                     #
+#                Variables & Functions                     #
 #----------------------------------------------------------#
 
 # Argument definition
@@ -99,7 +98,6 @@ sftpc() {
 EOF
 }
 
-
 #----------------------------------------------------------#
 #                    Verifications                         #
 #----------------------------------------------------------#
@@ -230,7 +228,6 @@ elif [ $type == 'b2' ]; then
     chmod 660 $HESTIA/conf/$type.backup.conf
 fi
 
-
 #----------------------------------------------------------#
 #                       Hestia                             #
 #----------------------------------------------------------#

bin/v-add-cron-hestia-autoupdate

@@ -1,13 +1,12 @@
 #!/bin/bash
-# info: add cron job for hestia autoupdates
+# info: add cron job for hestia automatic updates
 # options: MODE
-# labels: 
 #
-# The function adds cronjob for hestia autoupdate from apt or git.
-
+# This function adds a cronjob for hestia automatic updates
+# that can be downloaded from apt or git.
 
 #----------------------------------------------------------#
-#                    Variable&Function                     #
+#                Variables & Functions                     #
 #----------------------------------------------------------#
 
 # Argument definition
@@ -22,7 +21,6 @@ source $HESTIA/func/main.sh
 # load config file
 source_conf "$HESTIA/conf/hestia.conf"
 
-
 #----------------------------------------------------------#
 #                    Verifications                         #
 #----------------------------------------------------------#
@@ -39,7 +37,6 @@ fi
 # Perform verification if read-only mode is enabled
 check_hestia_demo_mode
 
-
 #----------------------------------------------------------#
 #                       Action                             #
 #----------------------------------------------------------#
@@ -75,13 +72,13 @@ str="$str CMD='$command' SUSPENDED='no' TIME='$time' DATE='$date'"
 # Adding to crontab
 echo "$str" >> $HESTIA/data/users/$user/cron.conf
 
-# Chaning permissions
+# Changing permissions
 chmod 660 $HESTIA/data/users/$user/cron.conf
 
 # Sort jobs by id number
 sort_cron_jobs
 
-# Sync cronjobs with system crond
+# Sync cronjobs with system cron
 sync_cron_jobs
 
 #----------------------------------------------------------#
@@ -91,7 +88,7 @@ sync_cron_jobs
 # Increasing cron value
 increase_user_value "$user" '$U_CRON_JOBS'
 
-# Restarting crond
+# Restarting cron
 $BIN/v-restart-cron
 check_result $? "Cron restart failed" >/dev/null
 

bin/v-add-cron-job

@@ -1,16 +1,14 @@
 #!/bin/bash
 # info: add cron job
 # options: USER MIN HOUR DAY MONTH WDAY COMMAND [JOB] [RESTART]
-# labels: 
 #
 # example: v-add-cron-job admin * * * * * sudo /usr/local/hestia/bin/v-backup-users
 #
-# The function adds a job to cron daemon. When executing commands, any output
+# This function adds a job to cron daemon. When executing commands, any output
 # is mailed to user's email if parameter REPORTS is set to 'yes'.
 
-
 #----------------------------------------------------------#
-#                    Variable&Function                     #
+#                Variables & Functions                     #
 #----------------------------------------------------------#
 
 # Argument definition
@@ -51,7 +49,6 @@ is_object_new 'cron' 'JOB' "$job"
 # Perform verification if read-only mode is enabled
 check_hestia_demo_mode
 
-
 #----------------------------------------------------------#
 #                       Action                             #
 #----------------------------------------------------------#
@@ -77,15 +74,14 @@ sort_cron_jobs
 # Sync cronjobs with system crond
 sync_cron_jobs
 
-
 #----------------------------------------------------------#
 #                       Hestia                             #
 #----------------------------------------------------------#
 
 # Increasing cron value
 increase_user_value $user '$U_CRON_JOBS'
 
-# Restarting crond
+# Restarting cron
 $BIN/v-restart-cron "$restart"
 check_result $? "Cron restart failed" >/dev/null
 

bin/v-add-cron-letsencrypt-job

@@ -1,13 +1,11 @@
 #!/bin/bash
-# info: add letsencrypt cronjob
+# info: add cron job for Let's Encrypt certificates
 # options: NONE
-# labels: 
 #
-# The script for enabling letsencrypt cronjob
-
+# This function adds a new cron job for Let's Encrypt.
 
 #----------------------------------------------------------#
-#                    Variable&Function                     #
+#                Variables & Functions                     #
 #----------------------------------------------------------#
 
 # Includes
@@ -18,7 +16,6 @@ source $HESTIA/func/main.sh
 # load config file
 source_conf "$HESTIA/conf/hestia.conf"
 
-
 #----------------------------------------------------------#
 #                    Verifications                         #
 #----------------------------------------------------------#
@@ -39,7 +36,6 @@ if [ -z "$check_cron" ] && [ -n "$CRON_SYSTEM" ]; then
     $BIN/v-add-cron-job admin '*/5' '*' '*' '*' '*' "$cmd"
 fi
 
-
 #----------------------------------------------------------#
 #                       Hestia                             #
 #----------------------------------------------------------#

bin/v-add-cron-reports

@@ -1,16 +1,14 @@
 #!/bin/bash
 # info: add cron reports
 # options: USER
-# labels: 
 #
 # example: v-add-cron-reports admin
 #
-# The script for enabling reports on cron tasks and administrative
+# This function for enabling reports on cron tasks and administrative
 # notifications.
 
-
 #----------------------------------------------------------#
-#                    Variable&Function                     #
+#                Variables & Functions                     #
 #----------------------------------------------------------#
 
 # Argument definition
@@ -24,7 +22,6 @@ source $HESTIA/func/main.sh
 # load config file
 source_conf "$HESTIA/conf/hestia.conf"
 
-
 #----------------------------------------------------------#
 #                    Verifications                         #
 #----------------------------------------------------------#
@@ -48,12 +45,11 @@ update_user_value "$user" '$CRON_REPORTS' 'yes'
 # Sync system cron with user
 sync_cron_jobs
 
-
 #----------------------------------------------------------#
 #                       Hestia                             #
 #----------------------------------------------------------#
 
-# Restart crond
+# Restart cron
 $BIN/v-restart-cron
 check_result $? "Cron restart failed" >/dev/null
 

bin/v-add-cron-restart-job

@@ -1,13 +1,11 @@
 #!/bin/bash
 # info: add cron reports
 # options: NONE
-# labels: 
 #
-# The script for enabling restart cron tasks
-
+# This function for enabling restart cron tasks
 
 #----------------------------------------------------------#
-#                    Variable&Function                     #
+#                Variables & Functions                     #
 #----------------------------------------------------------#
 
 # Includes
@@ -18,7 +16,6 @@ source $HESTIA/func/main.sh
 # load config file
 source_conf "$HESTIA/conf/hestia.conf"
 
-
 #----------------------------------------------------------#
 #                    Verifications                         #
 #----------------------------------------------------------#
@@ -39,7 +36,6 @@ if [ -z "$check_cron" ] && [ -n "$CRON_SYSTEM" ]; then
     $BIN/v-add-cron-job admin '*' '*' '*' '*' '*' "$cmd"
 fi
 
-
 #----------------------------------------------------------#
 #                       Hestia                             #
 #----------------------------------------------------------#

bin/v-add-database

@@ -1,21 +1,19 @@
 #!/bin/bash
 # info: add database
 # options: USER DATABASE DBUSER DBPASS [TYPE] [HOST] [CHARSET]
-# labels: 
 #
 # example: v-add-database admin wordpress_db matt qwerty123
 #
-# The function creates the database concatenating username and user_db.
+# This function creates the database concatenating username and user_db.
 # Supported types of databases you can get using v-list-sys-config script.
 # If the host isn't stated and there are few hosts configured on the server,
 # then the host will be defined by one of three algorithms. "First" will choose
 # the first host in the list. "Random" will chose the host by a chance.
 # "Weight" will distribute new database through hosts evenly. Algorithm and
 # types of supported databases is designated in the main configuration file.
 
-
 #----------------------------------------------------------#
-#                    Variable&Function                     #
+#                Variables & Functions                     #
 #----------------------------------------------------------#
 
 # Argument definition
@@ -76,7 +74,6 @@ dbpass="$password"
 # Perform verification if read-only mode is enabled
 check_hestia_demo_mode
 
-
 #----------------------------------------------------------#
 #                       Action                             #
 #----------------------------------------------------------#
@@ -87,7 +84,6 @@ case $type in
     pgsql) add_pgsql_database ;;
 esac
 
-
 #----------------------------------------------------------#
 #                       Hestia                             #
 #----------------------------------------------------------#

bin/v-add-database-host

@@ -1,19 +1,17 @@
 #!/bin/bash
 # info: add new database server
 # options: TYPE HOST DBUSER DBPASS [MAX_DB] [CHARSETS] [TEMPLATE] [PORT]
-# labels: 
 #
 # example: v-add-database-host mysql localhost alice p@$$wOrd
 #
-# The function add new database server to the server pool. It supports local
+# This function add new database server to the server pool. It supports local
 # and remote database servers, which is useful for clusters. By adding a host
 # you can set limit for number of databases on a host. Template parameter is
 # used only for PostgreSQL and has an default value "template1". You can read
 # more about templates in official PostgreSQL documentation.
 
-
 #----------------------------------------------------------#
-#                    Variable&Function                     #
+#                Variables & Functions                     #
 #----------------------------------------------------------#
 
 # Argument definition
@@ -65,7 +63,6 @@ is_pgsql_host_alive() {
     fi
 }
 
-
 #----------------------------------------------------------#
 #                    Verifications                         #
 #----------------------------------------------------------#
@@ -113,7 +110,6 @@ case $type in
            str="$str TIME='$time' DATE='$date' PORT='$port'";;
 esac
 
-
 #----------------------------------------------------------#
 #                       Hestia                             #
 #----------------------------------------------------------#

bin/v-add-database-temp-user

@@ -1,16 +1,15 @@
 #!/bin/bash
 # info: add temp database user
 # options: USER DATABASE [TYPE] [HOST] [TTL]
-# labels: hestia database
 #
 # example: v-add-database-temp-user wordress wordpress_db mysql
 #
-# The function creates an temporary database user mysql_sso_db_XXXXXXXX and a random password 
+# This function creates an temporary database user mysql_sso_db_XXXXXXXX and a random password 
 # The user has an limited validity and only granted access to the specific database 
 # Returns json to be read SSO Script
 
 #----------------------------------------------------------#
-#                    Variable&Function                     #
+#                Variables & Functions                     #
 #----------------------------------------------------------#
 
 # Argument definition