Skip to content

Commit fd42196

Browse files
authored
Patch out XSS in edit server (hestiacp#2471)
1 parent 91081b0 commit fd42196

File tree

5 files changed

+5
-1
lines changed

5 files changed

+5
-1
lines changed

web/edit/db/index.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
// Edit as someone else?
1616
if (($_SESSION['userContext'] === 'admin') && (!empty($_GET['user']))) {
1717
$user=escapeshellarg($_GET['user']);
18+
$user_plain=htmlentities($_GET['user']);
1819
}
1920

2021
// List datbase

web/edit/dns/index.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
// Edit as someone else?
1616
if (($_SESSION['userContext'] === 'admin') && (!empty($_GET['user']))) {
1717
$user=escapeshellarg($_GET['user']);
18+
$user_plain=htmlentities($_GET['user']);
1819
}
1920

2021
// List ip addresses

web/edit/mail/index.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
// Edit as someone else?
1616
if (($_SESSION['userContext'] === 'admin') && (!empty($_GET['user']))) {
1717
$user=escapeshellarg($_GET['user']);
18+
$user_plain=htmlentities($_GET['user']);
1819
}
1920

2021
$v_username = $user;

web/edit/web/index.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
// Edit as someone else?
1717
if (($_SESSION['userContext'] === 'admin') && (!empty($_GET['user']))) {
1818
$user=escapeshellarg($_GET['user']);
19+
$user_plain=htmlentities($_GET['user']);
1920
}
2021

2122
// Get all user domains

web/templates/pages/edit_server.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -857,7 +857,7 @@
857857
<tr>
858858
<td class="vst-text step-top">
859859
<?=_('SSL Certificate');?>
860-
<span id="generate-csr"> / <a class="generate" target="_blank" href="/generate/ssl/?domain=<?=$v_hostname?>"><?=_('Generate CSR');?></a></span>
860+
<span id="generate-csr"> / <a class="generate" target="_blank" href="/generate/ssl/?domain=<?=htmlentities(trim($v_hostname,'"'));?>"><?=_('Generate CSR');?></a></span>
861861
</td>
862862
</tr>
863863
<tr>

0 commit comments

Comments
 (0)