Skip to content

Commit fc67477

Browse files
committed
Bugix: Do not try to resolve ip addreses when adding a remote backup server
Fixes issue hestiacp#569
1 parent 10885f8 commit fc67477

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ All notable changes to this project will be documented in this file.
3535
- Performance: Do not resolve ip when listing iptables rules. Server tab could take multiple minutes to load in some cases.
3636
- Update jQuery to 3.4.1 and adjust includes.
3737
- Fixed cronjob issue with sftp jail due to missing user.
38+
- Fixed issue #569 Remote backup hostname would reject ip addr without reverse dns (PTR record)
3839

3940
## [1.0.5] - 2019-08-06 - Hotfix
4041
### Bugfixes

bin/v-add-backup-host

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,10 @@ if [ "$type" != 'local' ];then
9999
which expect >/dev/null 2>&1
100100
check_result $? "expect command not found" $E_NOTEXIST
101101
fi
102-
host "$host" >/dev/null 2>&1
103-
check_result $? "host connection failed" "$E_CONNECT"
102+
if ! (is_ip_format_valid "$host" >/dev/null); then
103+
host "$host" >/dev/null 2>&1
104+
check_result $? "host connection failed" "$E_CONNECT"
105+
fi
104106
fi
105107

106108
# Perform verification if read-only mode is enabled

0 commit comments

Comments
 (0)