Skip to content

Commit fa8cada

Browse files
committed
Improved eval key=value parsing
1 parent 7bf4668 commit fa8cada

File tree

1 file changed

+12
-34
lines changed

1 file changed

+12
-34
lines changed

func/domain.func

Lines changed: 12 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,7 @@ update_domain_zone() {
159159
fi
160160

161161
# Parsing dns domains conf
162-
for key in $line; do
163-
eval ${key%%=*}=${key#*=}
164-
done
162+
eval $line
165163

166164
# Converting SOA to ascii
167165
SOA=$(idn --quiet -a -t "$SOA")
@@ -326,9 +324,7 @@ get_web_domain_value() {
326324
string=$( grep "DOMAIN='$domain'" $V_USERS/$user/web.conf )
327325

328326
# Parsing key=value
329-
for keys in $string; do
330-
eval ${keys%%=*}=${keys#*=}
331-
done
327+
eval $string
332328

333329
# Self reference
334330
eval value="$key"
@@ -341,9 +337,7 @@ get_web_domain_values() {
341337
# Defining domain parameters
342338
for line in $(grep "DOMAIN='$domain'" $V_USERS/$user/web.conf); do
343339
# Assing key=value
344-
for key in $line; do
345-
eval ${key%%=*}=${key#*=}
346-
done
340+
eval $line
347341
done
348342
}
349343

@@ -354,9 +348,7 @@ get_dns_domain_value() {
354348
string=$( grep "DOMAIN='$domain'" $V_USERS/$user/dns.conf )
355349

356350
# Parsing key=value
357-
for keys in $string; do
358-
eval ${keys%%=*}=${keys#*=}
359-
done
351+
eval $string
360352

361353
# Self reference
362354
eval value="$key"
@@ -378,9 +370,7 @@ update_web_domain_value() {
378370
str=$(echo $domain_str | cut -f 2 -d ':')
379371

380372
# Reading key=values
381-
for keys in $str; do
382-
eval ${keys%%=*}=${keys#*=}
383-
done
373+
eval $str
384374

385375
# Defining clean key
386376
c_key=$(echo "${key//$/}")
@@ -409,9 +399,7 @@ update_dns_domain_value() {
409399
str=$(echo $domain_str | cut -f 2 -d ':')
410400

411401
# Reading key=values
412-
for keys in $str; do
413-
eval ${keys%%=*}=${keys#*=}
414-
done
402+
eval $str
415403

416404
# Defining clean key
417405
c_key=$(echo "${key//$/}")
@@ -434,9 +422,7 @@ is_web_domain_key_empty() {
434422
string=$( grep "DOMAIN='$domain'" $V_USERS/$user/web.conf )
435423

436424
# Parsing key=value
437-
for keys in $string; do
438-
eval ${keys%%=*}=${keys#*=}
439-
done
425+
eval $string
440426

441427
# Self reference
442428
eval value="$key"
@@ -518,9 +504,7 @@ is_web_domain_value_exist() {
518504
string=$( grep "DOMAIN='$domain'" $V_USERS/$user/web.conf )
519505

520506
# Parsing key=value
521-
for keys in $string; do
522-
eval ${keys%%=*}=${keys#*=}
523-
done
507+
eval $string
524508

525509
# Self reference
526510
eval value="$key"
@@ -540,9 +524,7 @@ is_dns_domain_value_exist() {
540524
string=$( grep "DOMAIN='$domain'" $V_USERS/$user/dns.conf )
541525

542526
# Parsing key=value
543-
for keys in $string; do
544-
eval ${keys%%=*}=${keys#*=}
545-
done
527+
eval $string
546528

547529
# Self reference
548530
eval value="$key"
@@ -599,9 +581,8 @@ dom_clear_search(){
599581
# Reading file line by line
600582
for line in $(grep $search_string $conf); do
601583
# Parsing key=val
602-
for key in $line; do
603-
eval ${key%%=*}=${key#*=}
604-
done
584+
eval $line
585+
605586
# Print result line
606587
eval echo "$field"
607588
done
@@ -610,11 +591,8 @@ dom_clear_search(){
610591
dom_clear_list() {
611592
# Reading file line by line
612593
while read line ; do
613-
614594
# Parsing key=value
615-
for key in $line; do
616-
eval ${key%%=*}=${key#*=}
617-
done
595+
eval $line
618596

619597
# Print result line
620598
eval echo "$field"

0 commit comments

Comments
 (0)