Skip to content

Commit e475944

Browse files
authored
Merge pull request hestiacp#1054 from hestiacp/staging/fixes
Staging/fixes
2 parents 810f0a7 + a378101 commit e475944

27 files changed

+76
-61
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ All notable changes to this project will be documented in this file.
2121
- Improved reliability of list handling when using IP lists.
2222
- Enforce minimum password requirements with visual indication of password strength.
2323
- Improved installer version detection.
24+
- Fix MariaDB service detection.
2425

2526
## [1.2.1] - Service Release
2627
### Features

bin/v-add-mail-domain-ssl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ if [[ "$domain" =~ .*\.$ ]]; then
2828
domain=$(echo "$domain" |sed -e "s/\.$//")
2929
fi
3030

31-
domain=$(idn -t --quiet -u "$domain" )
3231
domain_idn=$(idn -t --quiet -a "$domain")
3332

3433
# Includes

bin/v-add-sys-webmail

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ if [[ "$domain" =~ .*\.$ ]]; then
2626
domain=$(echo "$domain" |sed -e "s/\.$//")
2727
fi
2828

29-
domain=$(idn -t --quiet -u "$domain" )
3029
domain_idn=$(idn -t --quiet -a "$domain")
3130

3231
# Includes

bin/v-add-user

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,9 @@ CONTACT='$email'
183183
CRON_REPORTS='yes'
184184
MD5='$(awk -v user=$user -F : 'user == $1 {print $2}' /etc/shadow)'
185185
RKEY='$(generate_password)'
186+
TWOFA=''
187+
QRCODE=''
188+
PHPCLI=''
186189
SUSPENDED='no'
187190
SUSPENDED_USERS='0'
188191
SUSPENDED_WEB='0'

bin/v-add-user-2fa

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ secret=${array[0]}
5151
qrcode=${array[1]}
5252

5353
# Save the secret in user config (needs encryption?)
54-
sed -i "/RKEY/a TWOFA='$secret'" $USER_DATA/user.conf
55-
sed -i "/TWOFA/a QRCODE='$qrcode'" $USER_DATA/user.conf
54+
update_user_value "$user" '$TWOFA' "$secret"
55+
update_user_value "$user" '$QRCODE' "$qrcode"
5656

5757
#----------------------------------------------------------#
5858
# Hestia #

bin/v-add-web-domain-ssl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ if [[ "$domain" =~ .*\.$ ]]; then
3232
domain=$(echo "$domain" |sed -e "s/\.$//")
3333
fi
3434

35-
domain=$(idn -t --quiet -u "$domain" )
35+
domain=$domain
3636
domain_idn=$(idn -t --quiet -a "$domain")
3737

3838
# Includes

bin/v-add-web-domain-stats

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ cat $WEBTPL/$type/$type.tpl |\
7575
-e "s|%domain%|$domain|g" \
7676
-e "s|%user%|$user|g" \
7777
-e "s|%home%|$HOMEDIR|g" \
78-
-e "s|%alias%|${aliases//,/ }|g" \
78+
-e "s|%alias%|$stats_alias|g" \
7979
-e "s|%alias_idn%|$stats_alias|g" \
8080
> $HOMEDIR/$user/conf/web/$domain/$type.conf
8181

bin/v-change-user-package

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,7 @@ is_package_avalable() {
7878
change_user_package() {
7979
eval $(cat $USER_DATA/user.conf)
8080
eval $(cat $HESTIA/data/packages/$package.pkg |egrep -v "TIME|DATE")
81-
echo "FNAME='$FNAME'
82-
LNAME='$LNAME'
81+
echo "NAME='$NAME'
8382
PACKAGE='$package'
8483
WEB_TEMPLATE='$WEB_TEMPLATE'
8584
BACKEND_TEMPLATE='$BACKEND_TEMPLATE'
@@ -102,6 +101,9 @@ CONTACT='$CONTACT'
102101
CRON_REPORTS='$CRON_REPORTS'
103102
MD5='$MD5'
104103
RKEY='$RKEY'
104+
TWOFA='$TWOFA'
105+
QRCODE='$QRCODE'
106+
PHPCLI='$PHPCLI'
105107
SUSPENDED='$SUSPENDED'
106108
SUSPENDED_USERS='$SUSPENDED_USERS'
107109
SUSPENDED_WEB='$SUSPENDED_WEB'
@@ -166,7 +168,7 @@ shell=$(grep -w "$shell_conf" /etc/shells |head -n1)
166168

167169
# Run template trigger
168170
if [ -x "$HESTIA/data/packages/$package.sh" ]; then
169-
$HESTIA/data/packages/$package.sh "$user" "$CONTACT" "$FNAME" "$LNAME"
171+
$HESTIA/data/packages/$package.sh "$user" "$CONTACT" "$NAME"
170172
fi
171173

172174
# Update disk quota

bin/v-change-user-php-cli

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -62,12 +62,8 @@ sed -i "/alias php='env/d" "$FILE"
6262

6363
echo "alias php='env php$version'" >> $FILE
6464

65-
# Change language
66-
if [ -z "$(grep PHPCLI $USER_DATA/user.conf)" ]; then
67-
sed -i "s/^TIME/PHPCLI='$version'\nTIME/g" $USER_DATA/user.conf
68-
else
69-
update_user_value "$user" '$PHPCLI' "$version"
70-
fi
65+
update_user_value "$user" '$PHPCLI' "$version"
66+
7167

7268
#----------------------------------------------------------#
7369
# Hestia #

bin/v-delete-dns-domain

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
# Argument definition
1414
user=$1
15-
domain=$(idn -t --quiet -u "$2" )
15+
domain=$2
1616
restart="$3"
1717

1818
# Includes

0 commit comments

Comments
 (0)