Skip to content

Commit cb0f85d

Browse files
authored
Merge pull request hestiacp#1974 from jaapmarcus/fix/pma-sso
Fix minor issues during upgrade 1.4.5
2 parents 20654e7 + cf64095 commit cb0f85d

File tree

4 files changed

+25
-21
lines changed

4 files changed

+25
-21
lines changed

bin/v-add-sys-pma-sso

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,14 +75,13 @@ apikey=$($BIN/v-generate-api-key);
7575

7676
# copy config dir to /usr/share/phpmyadmin/
7777
cp -f $HESTIA_INSTALL_DIR/phpmyadmin/hestia-sso.php $PMA_INSTALL/hestia-sso.php
78-
chmod 644 $PMA_INSTALL/hestia-sso.php
78+
chmod 640 $PMA_INSTALL/hestia-sso.php
7979

8080
sed -i "s/%PHPMYADMIN_KEY%/$phpmyadminkey/g" $PMA_INSTALL/hestia-sso.php
8181
sed -i "s/%API_KEY%/$apikey/g" $PMA_INSTALL/hestia-sso.php
8282
sed -i "s/%API_HOST_NAME%/$(hostname)/g" $PMA_INSTALL/hestia-sso.php
8383
sed -i "s/%API_HESTIA_PORT%/$BACKEND_PORT/g" $PMA_INSTALL/hestia-sso.php
8484

85-
8685
# Check if config already contains the keys
8786
touch $PMA_CONFIG/hestia-sso.inc.php
8887
chmod 640 $PMA_CONFIG/hestia-sso.inc.php

bin/v-restart-service

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -33,25 +33,26 @@ is_format_valid 'service' 'restart'
3333
# Action #
3434
#----------------------------------------------------------#
3535

36-
# Get installed php versions
37-
php_versions=$(ls /usr/sbin/php*fpm* | cut -d'/' -f4 | sed 's|php-fpm||')
38-
39-
# Substitute php-fpm service name formats
40-
for version in $php_versions; do
41-
if [ "$service" = "php-fpm${version}" ]; then
42-
service="php${version}-fpm"
43-
fi
44-
done
45-
46-
# Multi-instance service restart request handling
47-
if [ "$service" = "php-fpm" ];then
36+
if [ -d /usr/sbin/php*/fpm/ ]; then
37+
# Get installed php versions
38+
php_versions=$(ls /usr/sbin/php*fpm* | cut -d'/' -f4 | sed 's|php-fpm||')
39+
40+
# Substitute php-fpm service name formats
4841
for version in $php_versions; do
49-
service_list="${service_list} php${version}-fpm"
42+
if [ "$service" = "php-fpm${version}" ]; then
43+
service="php${version}-fpm"
44+
fi
5045
done
51-
else
52-
service_list="$service"
53-
fi
54-
46+
47+
# Multi-instance service restart request handling
48+
if [ "$service" = "php-fpm" ];then
49+
for version in $php_versions; do
50+
service_list="${service_list} php${version}-fpm"
51+
done
52+
else
53+
service_list="$service"
54+
fi
55+
fi
5556
for service in $service_list; do
5657

5758
if [ "$service" = "iptables" ]; then

install/upgrade/manual/migrate_phpmyadmin.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ then
5252
mkdir -p /etc/phpmyadmin
5353
mkdir -p /etc/phpmyadmin/conf.d/
5454
mkdir /usr/share/phpmyadmin/tmp
55-
chmod 777 /usr/share/phpmyadmin/tmp/
55+
chmod 770 /usr/share/phpmyadmin/tmp/
5656
mkdir -p /etc/phpmyadmin/conf.d/
5757

5858
# Configuring Apache2 for PHPMYADMIN
@@ -76,7 +76,7 @@ then
7676
# Create copy of config file
7777
cp -f $HESTIA_INSTALL_DIR/phpmyadmin/config.inc.php /etc/phpmyadmin/
7878
mkdir -p /var/lib/phpmyadmin/tmp
79-
chmod 777 -R /var/lib/phpmyadmin/tmp
79+
chmod 770 -R /var/lib/phpmyadmin/tmp
8080

8181
# Set config and log directory
8282
sed -i "s|define('CONFIG_DIR', ROOT_PATH);|define('CONFIG_DIR', '/etc/phpmyadmin/');|" /usr/share/phpmyadmin/libraries/vendor_config.php

install/upgrade/versions/1.4.6.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,7 @@
55
#######################################################################################
66
####### Place additional commands below. #######
77
#######################################################################################
8+
9+
if [ -z "$DB_PMA_ALIAS" ]; then
10+
$HESTIA/bin/v-change-sys-db-alias 'pma' $DB_PMA_ALIAS
11+
fi

0 commit comments

Comments
 (0)