Skip to content

Commit c9e93a8

Browse files
AlecRustjaapmarcus
andauthored
Move ShellCheck to Actions (hestiacp#3036)
* Move ShellCheck to Actions * Removed linting step from drone PHP never caught really any bug in the future we should replace it with more advanced unit testing Removed Publish to apt step. Minor changes have been made an broke it. Co-authored-by: Jaap Marcus <9754650+jaapmarcus@users.noreply.github.com>
1 parent 7e02569 commit c9e93a8

File tree

2 files changed

+21
-38
lines changed

2 files changed

+21
-38
lines changed

.drone.yml

Lines changed: 0 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -96,27 +96,6 @@ trigger:
9696
- refs/heads/main
9797
- refs/pull/*/head
9898

99-
---
100-
kind: pipeline
101-
type: docker
102-
name: Linting
103-
104-
concurrency:
105-
limit: 1
106-
107-
steps:
108-
- name: Shellcheck
109-
image: koalaman/shellcheck-alpine:v0.8.0
110-
commands:
111-
- ./test/shellcheck.sh
112-
- name: PHP 8.1
113-
image: php:8.1-cli-bullseye
114-
commands:
115-
- ./test/check_php.sh ./web/
116-
117-
trigger:
118-
event: [ pull_request, push ]
119-
12099
---
121100
kind: pipeline
122101
type: docker
@@ -147,24 +126,7 @@ steps:
147126
target: /root/
148127
source:
149128
- ./hestia/*
150-
- name: Publish
151-
image: appleboy/drone-ssh
152-
settings:
153-
host:
154-
from_secret: apt_server
155-
user: root
156-
key:
157-
from_secret: ssh_key
158-
port: 22
159-
command_timeout: 2m
160-
script:
161-
- freight-add ./hestia/*.deb apt/bionic apt/focal apt/jammy apt/stretch apt/buster apt/bullseye
162-
- freight-cache
163-
- rm -fr ./hestia/
164129

165130
trigger:
166131
event: [ promote]
167132

168-
---
169-
kind: signature
170-
hmac: f89a311b0f023c6ee92dbdb56bcd23ec663ef9242269a6b70c1c222bac4380ee

.github/workflows/lint.yml

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
name: Lint
2+
3+
on:
4+
pull_request:
5+
push:
6+
branches:
7+
- main
8+
9+
jobs:
10+
shellcheck:
11+
name: ShellCheck
12+
runs-on: ubuntu-latest
13+
steps:
14+
- name: Checkout code
15+
uses: actions/checkout@v3
16+
17+
- name: Install ShellCheck
18+
run: sudo apt-get install -y shellcheck
19+
20+
- name: Run ShellCheck
21+
run: ./test/shellcheck.sh

0 commit comments

Comments
 (0)