Skip to content

Commit b299b35

Browse files
authored
Fix $ undefined error (hestiacp#3271)
1 parent cf49945 commit b299b35

File tree

3 files changed

+48
-39
lines changed

3 files changed

+48
-39
lines changed

web/js/pages/edit_web.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,14 @@ $(function () {
213213
var elm = $(evt.target);
214214
App.Actions.WEB.passwordChanged(elm);
215215
});
216-
App.Actions.WEB.toggle_letsencrypt($('input[name=v_letsencrypt]'));
216+
$('input[name=v_letsencrypt]').change(function (evt) {
217+
var input = $(evt.target);
218+
if (input.prop('checked')) {
219+
$('#ssl-details').hide();
220+
} else {
221+
$('#ssl-details').show();
222+
}
223+
});
217224

218225
$('select[name="v_stats"]').change(function (evt) {
219226
var select = $(evt.target);

web/templates/footer.php

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -74,24 +74,25 @@ class="button button-secondary button-circle button-floating button-floating-top
7474
<?php if (!empty($_SESSION["error_msg"])): ?>
7575
<div>
7676
<script>
77-
// TODO: This is broken, $ is not defined
78-
$(function() {
79-
$('#dialog:ui-dialog').dialog('destroy');
80-
$('#dialog-message').dialog({
81-
modal: true,
82-
resizable: false,
83-
buttons: {
84-
Ok: function() {
85-
$(this).dialog('close');
77+
window.onload=function(){
78+
$(function() {
79+
$('#dialog:ui-dialog').dialog('destroy');
80+
$('#dialog-message').dialog({
81+
modal: true,
82+
resizable: false,
83+
buttons: {
84+
Ok: function() {
85+
$(this).dialog('close');
86+
}
87+
},
88+
create: function() {
89+
var buttonGroup = $(this).closest(".ui-dialog").find('.ui-dialog-buttonset');
90+
buttonGroup.find('button:first').addClass('button submit')
91+
buttonGroup.find('button:last').addClass('button button-secondary cancel');
8692
}
87-
},
88-
create: function() {
89-
var buttonGroup = $(this).closest(".ui-dialog").find('.ui-dialog-buttonset');
90-
buttonGroup.find('button:first').addClass('button submit')
91-
buttonGroup.find('button:last').addClass('button button-secondary cancel');
92-
}
93+
});
9394
});
94-
});
95+
}
9596
</script>
9697
<div id="dialog-message" title="">
9798
<p><?= htmlentities($_SESSION["error_msg"]) ?></p>

web/templates/pages/add_firewall_ipset.php

Lines changed: 23 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -91,34 +91,35 @@
9191
blacklist_iplists.sort(function (a, b) {
9292
return a.name > b.name;
9393
});
94+
window.onload = function(){
95+
$(function () {
96+
var targetElement = document.getElementById('datasource_list');
9497

95-
$(function () {
96-
var targetElement = document.getElementById('datasource_list');
97-
98-
// Blacklist
99-
var newEl = document.createElement("option");
100-
newEl.text = "<?= _("BLACKLIST") ?>";
101-
newEl.disabled = true;
102-
targetElement.appendChild(newEl);
103-
104-
blacklist_iplists.forEach(iplist => {
98+
// Blacklist
10599
var newEl = document.createElement("option");
106-
newEl.text = iplist.name;
107-
newEl.value = iplist.source;
100+
newEl.text = "<?= _("BLACKLIST") ?>";
101+
newEl.disabled = true;
108102
targetElement.appendChild(newEl);
109-
});
110103

111-
// IPVERSE
112-
var newEl = document.createElement("option");
113-
newEl.text = "<?= _("IPVERSE") ?>";
114-
newEl.disabled = true;
115-
targetElement.appendChild(newEl);
104+
blacklist_iplists.forEach(iplist => {
105+
var newEl = document.createElement("option");
106+
newEl.text = iplist.name;
107+
newEl.value = iplist.source;
108+
targetElement.appendChild(newEl);
109+
});
116110

117-
country_iplists.forEach(iplist => {
111+
// IPVERSE
118112
var newEl = document.createElement("option");
119-
newEl.text = iplist.name;
120-
newEl.value = iplist.source;
113+
newEl.text = "<?= _("IPVERSE") ?>";
114+
newEl.disabled = true;
121115
targetElement.appendChild(newEl);
116+
117+
country_iplists.forEach(iplist => {
118+
var newEl = document.createElement("option");
119+
newEl.text = iplist.name;
120+
newEl.value = iplist.source;
121+
targetElement.appendChild(newEl);
122+
});
122123
});
123-
});
124+
}
124125
</script>

0 commit comments

Comments
 (0)