Patch insecure CSRF token crypto vulnerability.

ScIT-Raphael · ScIT-Raphael · commit 94e8e585f016 · 2019-04-13T10:32:01.000+02:00
diff --git a/web/inc/main.php b/web/inc/main.php
@@ -58,9 +58,10 @@
     exit;
 }
 
+// Generate CSRF Token
 if (isset($_SESSION['user'])) {
     if(!isset($_SESSION['token'])){
-        $token = uniqid(mt_rand(), true);
+        $token = bin2hex(file_get_contents('/dev/urandom', false, null, 0, 16));
         $_SESSION['token'] = $token;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -58,9 +58,10 @@`
`58`	`58`	`exit;`
`59`	`59`	`}`
`60`	`60`
	`61`	`+// Generate CSRF Token`
`61`	`62`	`if (isset($_SESSION['user'])) {`
`62`	`63`	`if(!isset($_SESSION['token'])){`
`63`		`- $token = uniqid(mt_rand(), true);`
	`64`	`+ $token = bin2hex(file_get_contents('/dev/urandom', false, null, 0, 16));`
`64`	`65`	`$_SESSION['token'] = $token;`
`65`	`66`	`}`
`66`	`67`	`}`