Fix php error where $username gets overwritten (hestiacp#3884)

jaapmarcus · web-flow · commit 857b257fe7ed · 2023-08-02T17:51:42.000-03:00
diff --git a/web/inc/main.php b/web/inc/main.php
@@ -101,9 +101,10 @@ function destroy_sessions() {
 		$_SESSION["token"] = $token;
 	}
 	$username = $_SESSION["user"];
-	if (isset($_SESSION["look"])) {
+	if ($_SESSION["look"] != "") {
 		$username = $_SESSION["look"];
 	}
+
 	exec(HESTIA_CMD . "v-list-user " . quoteshellarg($username) . " json", $output, $return_var);
 	$data = json_decode(implode("", $output), true);
 	unset($output, $return_var);

Original file line number	Diff line number	Diff line change
`@@ -101,9 +101,10 @@ function destroy_sessions() {`
`101`	`101`	`$_SESSION["token"] = $token;`
`102`	`102`	`}`
`103`	`103`	`$username = $_SESSION["user"];`
`104`		`- if (isset($_SESSION["look"])) {`
	`104`	`+ if ($_SESSION["look"] != "") {`
`105`	`105`	`$username = $_SESSION["look"];`
`106`	`106`	`}`
	`107`	`+`
`107`	`108`	`exec(HESTIA_CMD . "v-list-user " . quoteshellarg($username) . " json", $output, $return_var);`
`108`	`109`	`$data = json_decode(implode("", $output), true);`
`109`	`110`	`unset($output, $return_var);`