Ensure exact match in if statement

Kristan Kenney · Kristan Kenney · commit 7f5335ce12fa · 2021-03-14T21:11:44.000-03:00
diff --git a/web/bulk/cron/index.php b/web/bulk/cron/index.php
@@ -15,7 +15,7 @@
 $job = $_POST['job'];
 $action = $_POST['action'];
 
-if ($_SESSION['userContext'] == 'admin') {
+if ($_SESSION['userContext'] === "admin") {
     switch ($action) {
         case 'delete': $cmd='v-delete-cron-job';
             break;
diff --git a/web/bulk/db/index.php b/web/bulk/db/index.php
@@ -15,7 +15,7 @@
 $database = $_POST['database'];
 $action = $_POST['action'];
 
-if ($_SESSION['userContext'] == 'admin') {
+if ($_SESSION['userContext'] === "admin") {
     switch ($action) {
         case 'rebuild': $cmd='v-rebuild-database';
             break;
diff --git a/web/bulk/dns/index.php b/web/bulk/dns/index.php
@@ -16,7 +16,7 @@
 $record = $_POST['record'];
 $action = $_POST['action'];
 
-if ($_SESSION['userContext'] == 'admin') {
+if ($_SESSION['userContext'] === "admin") {
     if (empty($record)) {
         switch ($action) {
             case 'rebuild': $cmd='v-rebuild-dns-domain';
diff --git a/web/bulk/hestia/index.php b/web/bulk/hestia/index.php
@@ -16,7 +16,7 @@
 $pkg = $_POST['pkg'];
 $action = $_POST['action'];
 
-if ($_SESSION['userContext'] == 'admin') {
+if ($_SESSION['userContext'] === "admin") {
     switch ($action) {
         case 'update': $cmd='v-update-sys-hestia';
             break;
diff --git a/web/bulk/ip/index.php b/web/bulk/ip/index.php
@@ -15,7 +15,7 @@
 $ip = $_POST['ip'];
 $action = $_POST['action'];
 
-if ($_SESSION['userContext'] == 'admin') {
+if ($_SESSION['userContext'] === "admin") {
     switch ($action) {
         case 'reread IP': exec(HESTIA_CMD."v-update-sys-ip", $output, $return_var);
                 header("Location: /list/ip/");
diff --git a/web/bulk/mail/index.php b/web/bulk/mail/index.php
@@ -16,7 +16,7 @@
 $account = $_POST['account'];
 $action = $_POST['action'];
 
-if ($_SESSION['userContext'] == 'admin') {
+if ($_SESSION['userContext'] === "admin") {
     if (empty($account)) {
         switch ($action) {
             case 'rebuild': $cmd='v-rebuild-mail-domain';
diff --git a/web/bulk/package/index.php b/web/bulk/package/index.php
@@ -15,7 +15,7 @@
 $package = $_POST['package'];
 $action = $_POST['action'];
 
-if ($_SESSION['userContext'] == 'admin') {
+if ($_SESSION['userContext'] === "admin") {
     switch ($action) {
         case 'delete': $cmd='v-delete-user-package';
             break;
diff --git a/web/bulk/service/index.php b/web/bulk/service/index.php
@@ -15,7 +15,7 @@
 $service = $_POST['service'];
 $action = $_POST['action'];
 
-if ($_SESSION['userContext'] == 'admin') {
+if ($_SESSION['userContext'] === "admin") {
     switch ($action) {
         case 'stop': $cmd='v-stop-service';
             break;
diff --git a/web/bulk/user/index.php b/web/bulk/user/index.php
@@ -15,7 +15,7 @@
 $user = $_POST['user'];
 $action = $_POST['action'];
 
-if ($_SESSION['userContext'] == 'admin') {
+if ($_SESSION['userContext'] === "admin") {
     switch ($action) {
         case 'delete': $cmd='v-delete-user'; $restart = 'no';
             break;
diff --git a/web/bulk/web/index.php b/web/bulk/web/index.php
@@ -15,7 +15,7 @@
 $domain = $_POST['domain'];
 $action = $_POST['action'];
 
-if ($_SESSION['userContext'] == 'admin') {
+if ($_SESSION['userContext'] === "admin") {
     switch ($action) {
         case 'delete': $cmd='v-delete-web-domain';
             break;
diff --git a/web/copy/package/index.php b/web/copy/package/index.php
@@ -23,7 +23,7 @@
     exit;
 }
 
-if ($_SESSION['userContext'] == 'admin') {
+if ($_SESSION['userContext'] === "admin") {
     if (!empty($_GET['package'])) {
         $v_package = escapeshellarg($_GET['package']);
         exec (HESTIA_CMD."v-copy-user-package ".$v_package." ".$v_package."-copy", $output, $return_var);
diff --git a/web/delete/backup/exclusion/index.php b/web/delete/backup/exclusion/index.php
@@ -5,7 +5,7 @@
 session_start();
 include($_SERVER['DOCUMENT_ROOT']."/inc/main.php");
 
-if (($_SESSION['userContext'] == 'admin') && (!empty($_GET['user']))) {
+if (($_SESSION['userContext'] === "admin") && (!empty($_GET['user']))) {
     $user=$_GET['user'];
 }
 
diff --git a/web/delete/backup/index.php b/web/delete/backup/index.php
@@ -5,7 +5,7 @@
 session_start();
 include($_SERVER['DOCUMENT_ROOT']."/inc/main.php");
 
-if (($_SESSION['userContext'] == 'admin') && (!empty($_GET['user']))) {
+if (($_SESSION['userContext'] === "admin") && (!empty($_GET['user']))) {
     $user=$_GET['user'];
 }
 
diff --git a/web/delete/cron/autoupdate/index.php b/web/delete/cron/autoupdate/index.php
@@ -11,7 +11,7 @@
     exit();
 }
 
-if ($_SESSION['userContext'] == 'admin') {
+if ($_SESSION['userContext'] === "admin") {
     exec (HESTIA_CMD."v-delete-cron-hestia-autoupdate", $output, $return_var);
     unset($output);
 }
diff --git a/web/delete/cron/index.php b/web/delete/cron/index.php
@@ -5,7 +5,7 @@
 session_start();
 include($_SERVER['DOCUMENT_ROOT']."/inc/main.php");
 
-if (($_SESSION['userContext'] == 'admin') && (!empty($_GET['user']))) {
+if (($_SESSION['userContext'] === "admin") && (!empty($_GET['user']))) {
     $user=$_GET['user'];
 }
 
diff --git a/web/delete/db/index.php b/web/delete/db/index.php
@@ -5,7 +5,7 @@
 session_start();
 include($_SERVER['DOCUMENT_ROOT']."/inc/main.php");
 
-if (($_SESSION['userContext'] == 'admin') && (!empty($_GET['user']))) {
+if (($_SESSION['userContext'] === "admin") && (!empty($_GET['user']))) {
     $user=$_GET['user'];
 }
 
diff --git a/web/delete/dns/index.php b/web/delete/dns/index.php
@@ -6,7 +6,7 @@
 include($_SERVER['DOCUMENT_ROOT']."/inc/main.php");
 
 // Delete as someone else?
-if (($_SESSION['userContext'] == 'admin') && (!empty($_GET['user']))) {
+if (($_SESSION['userContext'] === "admin") && (!empty($_GET['user']))) {
     $user=$_GET['user'];
 }
 
diff --git a/web/delete/ip/index.php b/web/delete/ip/index.php
@@ -11,7 +11,7 @@
     exit();
 }
 
-if ($_SESSION['userContext'] == 'admin') {
+if ($_SESSION['userContext'] === "admin") {
     if (!empty($_GET['ip'])) {
         $v_ip = escapeshellarg($_GET['ip']);
         exec (HESTIA_CMD."v-delete-sys-ip ".$v_ip, $output, $return_var);
diff --git a/web/delete/key/index.php b/web/delete/key/index.php
@@ -5,7 +5,7 @@
 session_start();
 include($_SERVER['DOCUMENT_ROOT']."/inc/main.php");
 
-if (($_SESSION['userContext'] == 'admin') && (!empty($_GET['user']))) {
+if (($_SESSION['userContext'] === "admin") && (!empty($_GET['user']))) {
     $user=$_GET['user'];
 }
 
diff --git a/web/delete/mail/index.php b/web/delete/mail/index.php
@@ -6,7 +6,7 @@
 include($_SERVER['DOCUMENT_ROOT']."/inc/main.php");
 
 // Delete as someone else?
-if (($_SESSION['userContext'] == 'admin') && (!empty($_GET['user']))) {
+if (($_SESSION['userContext'] === "admin") && (!empty($_GET['user']))) {
     $user=$_GET['user'];
 }
 
diff --git a/web/delete/package/index.php b/web/delete/package/index.php
@@ -11,7 +11,7 @@
     exit();
 }
 
-if ($_SESSION['userContext'] == 'admin') {
+if ($_SESSION['userContext'] === "admin") {
     if (!empty($_GET['package'])) {
         $v_package = escapeshellarg($_GET['package']);
         exec (HESTIA_CMD."v-delete-user-package ".$v_package, $output, $return_var);
diff --git a/web/delete/user/index.php b/web/delete/user/index.php
@@ -11,7 +11,7 @@
     exit();
 }
 
-if ($_SESSION['userContext'] == 'admin') {
+if ($_SESSION['userContext'] === "admin") {
     if (!empty($_GET['user'])) {
         $v_username = escapeshellarg($_GET['user']);
         exec (HESTIA_CMD."v-delete-user ".$v_username, $output, $return_var);
diff --git a/web/delete/web/cache/index.php b/web/delete/web/cache/index.php
@@ -12,7 +12,7 @@
 }
 
 // Delete as someone else?
-if (($_SESSION['userContext'] == 'admin') && (!empty($_GET['user']))) {
+if (($_SESSION['userContext'] === "admin") && (!empty($_GET['user']))) {
     $user=$_GET['user'];
 }
 
diff --git a/web/delete/web/index.php b/web/delete/web/index.php
@@ -12,7 +12,7 @@
 }
 
 // Delete as someone else?
-if (($_SESSION['userContext'] == 'admin') && (!empty($_GET['user']))) {
+if (($_SESSION['userContext'] === "admin") && (!empty($_GET['user']))) {
     $user=$_GET['user'];
 }
 
diff --git a/web/download/backup/index.php b/web/download/backup/index.php
@@ -29,7 +29,7 @@
     exit;
 
 }else{
-    if ($_SESSION['userContext'] == 'admin') {
+    if ($_SESSION['userContext'] === "admin") {
         header('Content-type: application/gzip');
         header("Content-Disposition: attachment; filename=\"".$backup."\";" ); 
         header("X-Accel-Redirect: /backup/" . $backup);
diff --git a/web/edit/backup/exclusions/index.php b/web/edit/backup/exclusions/index.php
@@ -7,7 +7,7 @@
 include($_SERVER['DOCUMENT_ROOT']."/inc/main.php");
 
 // Edit as someone else?
-if (($_SESSION['userContext'] == 'admin') && (!empty($_GET['user']))) {
+if (($_SESSION['userContext'] === "admin") && (!empty($_GET['user']))) {
     $user=escapeshellarg($_GET['user']);
 }
 
diff --git a/web/edit/cron/index.php b/web/edit/cron/index.php
@@ -8,7 +8,7 @@
 include($_SERVER['DOCUMENT_ROOT']."/inc/main.php");
 
 // Edit as someone else?
-if (($_SESSION['userContext'] == 'admin') && (!empty($_GET['user']))) {
+if (($_SESSION['userContext'] === "admin") && (!empty($_GET['user']))) {
     $user=escapeshellarg($_GET['user']);
 }
 
diff --git a/web/edit/db/index.php b/web/edit/db/index.php
@@ -14,7 +14,7 @@
 }
 
 // Edit as someone else?
-if (($_SESSION['userContext'] == 'admin') && (!empty($_GET['user']))) {
+if (($_SESSION['userContext'] === "admin") && (!empty($_GET['user']))) {
     $user=escapeshellarg($_GET['user']);
 }
 
diff --git a/web/edit/dns/index.php b/web/edit/dns/index.php
@@ -13,7 +13,7 @@
 }
 
 // Edit as someone else?
-if (($_SESSION['userContext'] == 'admin') && (!empty($_GET['user']))) {
+if (($_SESSION['userContext'] === "admin") && (!empty($_GET['user']))) {
     $user=escapeshellarg($_GET['user']);
 }
 
diff --git a/web/edit/file/index.php b/web/edit/file/index.php
@@ -4,7 +4,7 @@
 $user = $_SESSION['user'];
 
 // Check login_as feature
-if (($_SESSION['userContext'] == 'admin') && (!empty($_SESSION['look']))) {
+if (($_SESSION['userContext'] === "admin") && (!empty($_SESSION['look']))) {
     $user=$_SESSION['look'];
 }
 
diff --git a/web/edit/mail/index.php b/web/edit/mail/index.php
@@ -13,7 +13,7 @@
 }
 
 // Edit as someone else?
-if (($_SESSION['userContext'] == 'admin') && (!empty($_GET['user']))) {
+if (($_SESSION['userContext'] === "admin") && (!empty($_GET['user']))) {
     $user=escapeshellarg($_GET['user']);
 }
 $v_username = $user;
diff --git a/web/edit/user/index.php b/web/edit/user/index.php
@@ -14,7 +14,7 @@
 }
 
 // Edit as someone else?
-if (($_SESSION['userContext'] == 'admin') && (!empty($_GET['user']))) {
+if (($_SESSION['userContext'] === "admin") && (!empty($_GET['user']))) {
     $user=$_GET['user'];
     $v_username=$_GET['user'];
 } else {
@@ -23,7 +23,7 @@
 }
 
 // Prevent other users with admin privileges from editing properties of default 'admin' user
-if (($_SESSION['userContext'] == 'admin') && (isset($_SESSION['look'])) && ($user == 'admin') || ($_SESSION['userContext'] == 'admin') && (!isset($_SESSION['look'])) && ($user == 'admin') && ($_SESSION['user'] != 'admin')) {
+if (($_SESSION['userContext'] === "admin") && (isset($_SESSION['look'])) && ($user == 'admin') || ($_SESSION['userContext'] === "admin") && (!isset($_SESSION['look'])) && ($user == 'admin') && ($_SESSION['user'] != 'admin')) {
     header("Location: /list/user/");
     exit;
 }
@@ -160,22 +160,22 @@
     }
 
     // Change package (admin only)
-    if (($v_package != $_POST['v_package']) && ($_SESSION['userContext'] == 'admin') && (empty($_SESSION['error_msg']))) {
+    if (($v_package != $_POST['v_package']) && ($_SESSION['userContext'] === "admin") && (empty($_SESSION['error_msg']))) {
         $v_package = escapeshellarg($_POST['v_package']);
         exec (HESTIA_CMD."v-change-user-package ".escapeshellarg($v_username)." ".$v_package, $output, $return_var);
         check_return_code($return_var,$output);
         unset($output);
     }
 
     // Change phpcli (admin only)
-    if (($v_phpcli != $_POST['v_phpcli']) && ($_SESSION['userContext'] == 'admin') && (empty($_SESSION['error_msg']))) {
+    if (($v_phpcli != $_POST['v_phpcli']) && ($_SESSION['userContext'] === "admin") && (empty($_SESSION['error_msg']))) {
         $v_phpcli = escapeshellarg($_POST['v_phpcli']);
         exec (HESTIA_CMD."v-change-user-php-cli ".escapeshellarg($v_username)." ".$v_phpcli, $output, $return_var);
         check_return_code($return_var,$output);
         unset($output);
     }
     // Change Role (admin only)
-    if (($v_role != $_POST['$v_role']) && ($_SESSION['userContext'] == 'admin') && $v_username != "admin" && (empty($_SESSION['error_msg']))) {
+    if (($v_role != $_POST['$v_role']) && ($_SESSION['userContext'] === "admin") && $v_username != "admin" && (empty($_SESSION['error_msg']))) {
         $v_role = escapeshellarg($_POST['v_role']);
         exec (HESTIA_CMD."v-change-user-role ".escapeshellarg($v_username)." ".$v_role, $output, $return_var);
         check_return_code($return_var,$output);
@@ -194,7 +194,7 @@
     }
 
     // Change shell (admin only)
-    if (($v_shell != $_POST['v_shell']) && ($_SESSION['userContext'] == 'admin') && (empty($_SESSION['error_msg']))) {
+    if (($v_shell != $_POST['v_shell']) && ($_SESSION['userContext'] === "admin") && (empty($_SESSION['error_msg']))) {
         $v_shell = escapeshellarg($_POST['v_shell']);
         exec (HESTIA_CMD."v-change-user-shell ".escapeshellarg($v_username)." ".$v_shell, $output, $return_var);
         check_return_code($return_var,$output);
diff --git a/web/edit/user/log/index.php b/web/edit/user/log/index.php
@@ -14,7 +14,7 @@
 }
 
 // Edit as someone else?
-if (($_SESSION['userContext'] == 'admin') && (!empty($_GET['user']))) {
+if (($_SESSION['userContext'] === "admin") && (!empty($_GET['user']))) {
     $user=$_GET['user'];
     $v_username=$_GET['user'];
 } else {
diff --git a/web/edit/web/index.php b/web/edit/web/index.php
@@ -14,7 +14,7 @@
 }
 
 // Edit as someone else?
-if (($_SESSION['userContext'] == 'admin') && (!empty($_GET['user']))) {
+if (($_SESSION['userContext'] === "admin") && (!empty($_GET['user']))) {
     $user=escapeshellarg($_GET['user']);
 }
 
diff --git a/web/inc/main.php b/web/inc/main.php
@@ -93,7 +93,7 @@
     $user = $_SESSION['user'];
 }
 
-if (isset($_SESSION['look']) && ($_SESSION['userContext'] == 'admin')) {
+if (isset($_SESSION['look']) && ($_SESSION['userContext'] === "admin")) {
     $user = $_SESSION['look'];
 }
 
@@ -158,7 +158,7 @@ function top_panel($user, $TAB) {
     $panel = json_decode(implode('', $output), true);
     unset($output);
 
-    if (($_SESSION['userContext'] == 'admin')) {
+    if (($_SESSION['userContext'] === "admin")) {
         include(dirname(__FILE__).'/../templates/admin/panel.html');
     } else {
         include(dirname(__FILE__).'/../templates/user/panel.html');
diff --git a/web/list/directory/index.php b/web/list/directory/index.php
@@ -4,7 +4,7 @@
 include($_SERVER['DOCUMENT_ROOT'] . "/inc/main.php");
 
 // Check login_as feature
-if (($_SESSION['userContext'] == 'admin') && (!empty($_SESSION['look']))) {
+if (($_SESSION['userContext'] === "admin") && (!empty($_SESSION['look']))) {
     $user=$_SESSION['look'];
 }
 
diff --git a/web/list/stats/index.php b/web/list/stats/index.php
@@ -6,7 +6,7 @@
 include($_SERVER['DOCUMENT_ROOT']."/inc/main.php");
 
 // Data
-if ($_SESSION['userContext'] == 'admin') {
+if ($_SESSION['userContext'] === "admin") {
     if (empty($_GET['user'])) {
         exec (HESTIA_CMD."v-list-users-stats json", $output, $return_var);
         $data = json_decode(implode('', $output), true);
diff --git a/web/list/user/index.php b/web/list/user/index.php
@@ -6,7 +6,7 @@
 include($_SERVER['DOCUMENT_ROOT']."/inc/main.php");
 
 // Data
-if ($_SESSION['userContext'] == 'admin') {
+if ($_SESSION['userContext'] === "admin") {
     exec (HESTIA_CMD . "v-list-users json", $output, $return_var);
 } else {
     exec (HESTIA_CMD . "v-list-user ".$user." json", $output, $return_var);
diff --git a/web/login/index.php b/web/login/index.php
diff --git a/web/restart/service/index.php b/web/restart/service/index.php
diff --git a/web/restart/system/index.php b/web/restart/system/index.php
diff --git a/web/start/service/index.php b/web/start/service/index.php
diff --git a/web/stop/service/index.php b/web/stop/service/index.php
diff --git a/web/templates/admin/list_user.html b/web/templates/admin/list_user.html
diff --git a/web/templates/admin/panel.html b/web/templates/admin/panel.html
diff --git a/web/templates/user/list_user.html b/web/templates/user/list_user.html
diff --git a/web/update/hestia/index.php b/web/update/hestia/index.php
