Skip to content

Commit 7ec123a

Browse files
authored
Refactoring rebuild_mysql_database() func
Fix hestiacp#1523
1 parent b3d78bb commit 7ec123a

File tree

1 file changed

+18
-9
lines changed

1 file changed

+18
-9
lines changed

func/rebuild.sh

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -535,21 +535,30 @@ rebuild_mail_domain_conf() {
535535
rebuild_mysql_database() {
536536
mysql_connect $HOST
537537
mysql_query "CREATE DATABASE \`$DB\` CHARACTER SET $CHARSET" >/dev/null
538-
if [ "$(echo $mysql_ver |cut -d '.' -f2)" -ge 7 ] || [ "$mysql_fork" = "mariadb" ]; then
539-
if [ "$mysql_fork" = "mariadb" ] && [ "$(echo $mysql_ver |cut -d '.' -f1)" -eq 5 ]; then
540-
mysql_query "CREATE USER \`$DBUSER\`" > /dev/null
541-
mysql_query "CREATE USER \`$DBUSER\`@localhost" > /dev/null
542-
else
538+
if [ "$mysql_fork" = "mysql" ]; then
539+
# mysql
540+
if [ "$(echo $mysql_ver |cut -d '.' -f2)" -ge 7 ]; then
541+
# mysql >= 5.7
543542
mysql_query "CREATE USER IF NOT EXISTS \`$DBUSER\`" > /dev/null
544543
mysql_query "CREATE USER IF NOT EXISTS \`$DBUSER\`@localhost" > /dev/null
545-
fi
546-
if [ "$mysql_fork" = "mariadb" ]; then
547-
query="UPDATE mysql.user SET Password='$MD5' WHERE User='$DBUSER'"
548-
else
549544
query="UPDATE mysql.user SET authentication_string='$MD5'"
550545
query="$query WHERE User='$DBUSER'"
546+
else
547+
# mysql < 5.7
548+
query="UPDATE mysql.user SET Password='$MD5' WHERE User='$DBUSER'"
551549
fi
552550
else
551+
# mariadb
552+
if [ "$(echo $mysql_ver |cut -d '.' -f1)" -eq 5 ]; then
553+
# mariadb = 5
554+
mysql_query "CREATE USER \`$DBUSER\`" > /dev/null
555+
mysql_query "CREATE USER \`$DBUSER\`@localhost" > /dev/null
556+
else
557+
# mariadb = 10
558+
mysql_query "CREATE USER IF NOT EXISTS \`$DBUSER\`" > /dev/null
559+
mysql_query "CREATE USER IF NOT EXISTS \`$DBUSER\`@localhost" > /dev/null
560+
fi
561+
# mariadb any version
553562
query="UPDATE mysql.user SET Password='$MD5' WHERE User='$DBUSER'"
554563
fi
555564
mysql_query "GRANT ALL ON \`$DB\`.* TO \`$DBUSER\`@\`%\`" >/dev/null

0 commit comments

Comments
 (0)