Skip to content

Commit 735067a

Browse files
committed
Fix for ftp backup on RHEL5 and Ubuntu
1 parent b531e9f commit 735067a

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

bin/v-add-backup-ftp-host

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ source $VESTA/conf/vesta.conf
2323

2424
# Defining ftp command function
2525
ftpc() {
26-
ftp -n $host $ftp_port <<EOF
26+
ftp -p -n $host $ftp_port <<EOF
2727
quote USER $ftp_user
2828
quote PASS $ftp_password
2929
binary
@@ -48,16 +48,17 @@ validate_format 'host' 'ftp_user' 'ftp_password'
4848
#----------------------------------------------------------#
4949

5050
# Checking network connection
51-
ftp_connect=$(ftpc)
52-
if [ ! -z "$(echo $ftp_connect |grep -i -e error -e 'not connected')" ]; then
51+
fconn=$(ftpc)
52+
ferror=$(echo $fconn |grep -i -e failed -e error -e "Can't" -e "not conn")
53+
if [ ! -z "$ferror" ]; then
5354
echo "Error: can't login to ftp"
5455
log_event "$E_CONNECT" "$EVENT"
5556
exit $E_CONNECT
5657
fi
5758

5859
# Checking write permissions
5960
ftpc "mkdir $ftp_path" > /dev/null 2>&1
60-
ftmpdir=$(mktemp -u -p "$ftp_path")
61+
ftmpdir="$ftp_path/vst.bK76A9SUkt"
6162
ftp_result=$(ftpc "mkdir $ftmpdir" "rm $ftmpdir"|grep -v Trying)
6263
if [ ! -z "$ftp_result" ] ; then
6364
echo "$ftp_result"

bin/v-backup-user

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -509,7 +509,7 @@ local_backup(){
509509

510510
# Defining ftp command function
511511
ftpc() {
512-
/usr/bin/ftp -n $HOST $PORT <<EOF
512+
/usr/bin/ftp -p -n $HOST $PORT <<EOF
513513
quote USER $USERNAME
514514
quote PASS $PASSWORD
515515
binary
@@ -556,8 +556,9 @@ ftp_backup() {
556556
echo -e "$(date "+%F %T") FTP ftp://$HOST$BPATH/$user.$DATE.tar"
557557

558558
# Checking ftp connection
559-
ftp_connect=$(ftpc)
560-
if [ ! -z "$(echo $ftp_connect |grep -i -e error -e 'not conn')" ]; then
559+
fconn=$(ftpc)
560+
ferror=$(echo $fconn |grep -i -e failed -e error -e "Can't" -e "not conn")
561+
if [ ! -z "$ferror" ]; then
561562
rm -rf $tmpdir
562563
echo "Can't login to ftp://$USERNAME@$HOST" |\
563564
$send_mail -s "$subj" $email
@@ -569,7 +570,8 @@ ftp_backup() {
569570

570571
# Check ftp permissions
571572
ftpc "mkdir $BPATH" > /dev/null 2>&1
572-
ftmpdir=$(mktemp -u -p "$BPATH")
573+
ftmpdir="$BPATH/vst.bK76A9SUkt"
574+
ftpc "mkdir $ftmpdir" "rm $ftmpdir"
573575
ftp_result=$(ftpc "mkdir $ftmpdir" "rm $ftmpdir" |grep -v Trying)
574576
if [ ! -z "$ftp_result" ] ; then
575577
rm -rf $tmpdir

0 commit comments

Comments
 (0)