Skip to content

Commit 67acac3

Browse files
Added check if return value is an array (hestiacp#1494)
* Added check if return value is an array foreach ($dns_cluster as $key => $value) { $v_dns_cluster = 'yes'; } Returned NULL when cluster is disabled causing error in error log 2020/12/22 21:48:25 [error] 29766#0: *63 FastCGI sent in stderr: "PHP message: PHP Warning: Invalid argument supplied for foreach() in /usr/local/hestia/web/edit/server/index.php on line 113" while reading response header from upstream, client: xx.xx.xx.xx, server: _, request: "POST /edit/server/ HTTP/1.1", upstream: "fastcgi://unix:/var/run/hestia-php.sock:", host: "dev.eris.nu:8083", referrer: "https://dev.text.xx:8083/edit/server/" * Add spaces Co-authored-by: Raphael Schneeberger <rs@scit.ch>
1 parent c837a6d commit 67acac3

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

web/edit/server/index.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,10 @@
110110
exec (HESTIA_CMD."v-list-remote-dns-hosts json", $output, $return_var);
111111
$dns_cluster = json_decode(implode('', $output), true);
112112
unset($output);
113-
foreach ($dns_cluster as $key => $value) {
114-
$v_dns_cluster = 'yes';
113+
if (is_array($dns_cluster)) {
114+
foreach ($dns_cluster as $key => $value) {
115+
$v_dns_cluster = 'yes';
116+
}
115117
}
116118

117119
// List Database hosts

0 commit comments

Comments
 (0)