Skip to content

Commit 5dbc398

Browse files
committed
Fix incorrect quoting
1 parent 6be496b commit 5dbc398

File tree

6 files changed

+10
-10
lines changed

6 files changed

+10
-10
lines changed

web/add/ip/index.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757

5858
// Add IP
5959
if (empty($_SESSION['error_msg'])) {
60-
exec (HESTIA_CMD."v-add-sys-ip ".$v_ip." ".$v_netmask." ".$v_interface." ".$v_owner." '".$ip_status."' ".$v_name." ".$v_nat, $output, $return_var);
60+
exec (HESTIA_CMD."v-add-sys-ip ".$v_ip." ".$v_netmask." ".$v_interface." ".$v_owner." ".escapeshellarg($ip_status)." ".$v_name." ".$v_nat, $output, $return_var);
6161
check_return_code($return_var,$output);
6262
unset($output);
6363
$v_owner = $_POST['v_owner'];

web/edit/server/index.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -393,7 +393,7 @@
393393
$v_backup_username = escapeshellarg($_POST['v_backup_username']);
394394
$v_backup_password = escapeshellcmd($_POST['v_backup_password']);
395395
$v_backup_bpath = escapeshellarg($_POST['v_backup_bpath']);
396-
exec (HESTIA_CMD."v-add-backup-host ". $v_backup_type ." ". $v_backup_host ." ". $v_backup_username ." '". $v_backup_password ."' ". $v_backup_bpath." ".$v_backup_port, $output, $return_var);
396+
exec (HESTIA_CMD."v-add-backup-host ". $v_backup_type ." ". $v_backup_host ." ". $v_backup_username ." ". $v_backup_password ." ". $v_backup_bpath." ".$v_backup_port, $output, $return_var);
397397
check_return_code($return_var,$output);
398398
unset($output);
399399
if (empty($_SESSION['error_msg'])) $v_backup_host = $_POST['v_backup_host'];
@@ -411,15 +411,15 @@
411411
// Change remote backup host type
412412
if (empty($_SESSION['error_msg'])) {
413413
if ((!empty($_POST['v_backup_host'])) && ($_POST['v_backup_type'] != $v_backup_type)) {
414-
exec (HESTIA_CMD."v-delete-backup-host '". $v_backup_type ."'", $output, $return_var);
414+
exec (HESTIA_CMD."v-delete-backup-host " . escapeshellarg($v_backup_type) , $output, $return_var);
415415
unset($output);
416416
$v_backup_host = escapeshellarg($_POST['v_backup_host']);
417417
$v_backup_port = escapeshellarg($_POST['v_backup_port']);
418418
$v_backup_type = escapeshellarg($_POST['v_backup_type']);
419419
$v_backup_username = escapeshellarg($_POST['v_backup_username']);
420420
$v_backup_password = escapeshellcmd($_POST['v_backup_password']);
421421
$v_backup_bpath = escapeshellarg($_POST['v_backup_bpath']);
422-
exec (HESTIA_CMD."v-add-backup-host ". $v_backup_type ." ". $v_backup_host ." ". $v_backup_username ." '". $v_backup_password ."' ". $v_backup_bpath." ".$v_backup_port, $output, $return_var);
422+
exec (HESTIA_CMD."v-add-backup-host ". $v_backup_type ." ". $v_backup_host ." ". $v_backup_username ." ". $v_backup_password ." ". $v_backup_bpath." ".$v_backup_port, $output, $return_var);
423423
check_return_code($return_var,$output);
424424
unset($output);
425425
if (empty($_SESSION['error_msg'])) $v_backup_host = $_POST['v_backup_host'];
@@ -443,7 +443,7 @@
443443
$v_backup_username = escapeshellarg($_POST['v_backup_username']);
444444
$v_backup_password = escapeshellcmd($_POST['v_backup_password']);
445445
$v_backup_bpath = escapeshellarg($_POST['v_backup_bpath']);
446-
exec (HESTIA_CMD."v-add-backup-host ". $v_backup_type ." ". $v_backup_host ." ". $v_backup_username ." '". $v_backup_password ."' ". $v_backup_bpath." ".$v_backup_port, $output, $return_var);
446+
exec (HESTIA_CMD."v-add-backup-host ". $v_backup_type ." ". $v_backup_host ." ". $v_backup_username ." ". $v_backup_password ." ". $v_backup_bpath." ".$v_backup_port, $output, $return_var);
447447
check_return_code($return_var,$output);
448448
unset($output);
449449
if (empty($_SESSION['error_msg'])) $v_backup_host = $_POST['v_backup_host'];

web/list/directory/index.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
}
1010

1111
if (empty($panel)) {
12-
$command = HESTIA_CMD."v-list-user '".$user."' 'json'";
12+
$command = HESTIA_CMD."v-list-user ".escapeshellarg($user)." 'json'";
1313
exec ($command, $output, $return_var);
1414
if ( $return_var > 0 ) {
1515
header("Location: /error/");

web/list/dns/index.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
render_page($user, $TAB, 'list_dns');
1616
} else {
17-
exec (HESTIA_CMD."v-list-dns-records '".$user."' '".escapeshellarg($_GET['domain'])."' 'json'", $output, $return_var);
17+
exec (HESTIA_CMD."v-list-dns-records ".escapeshellarg($user)." ".escapeshellarg($_GET['domain'])." 'json'", $output, $return_var);
1818
$data = json_decode(implode('', $output), true);
1919
$data = array_reverse($data, true);
2020
unset($output);

web/list/mail/index.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
render_page($user, $TAB, 'list_mail');
1616
} else {
17-
exec (HESTIA_CMD."v-list-mail-accounts '".$user."' '".escapeshellarg($_GET['domain'])."' json", $output, $return_var);
17+
exec (HESTIA_CMD."v-list-mail-accounts ".escapeshellarg($user)." ".escapeshellarg($_GET['domain'])." json", $output, $return_var);
1818
$data = json_decode(implode('', $output), true);
1919
$data = array_reverse($data, true);
2020
unset($output);

web/reset/mail/index.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ function to64 ($v, $n)
135135

136136
// Get current md5 hash
137137
if (!empty($v_user)) {
138-
exec (HESTIA_CMD."v-get-mail-account-value '".$v_user."' ".$v_domain." ".$v_account." 'md5'", $output, $return_var);
138+
exec (HESTIA_CMD."v-get-mail-account-value ".escapeshellarg($v_user)." ".$v_domain." ".$v_account." 'md5'", $output, $return_var);
139139
if ($return_var == 0) {
140140
$v_hash = $output[0];
141141
}
@@ -154,7 +154,7 @@ function to64 ($v, $n)
154154
$fp = fopen($v_new_password, "w");
155155
fwrite($fp, $_POST['new']."\n");
156156
fclose($fp);
157-
exec (HESTIA_CMD."v-change-mail-account-password '".$v_user."' ".$v_domain." ".$v_account." ".$v_new_password, $output, $return_var);
157+
exec (HESTIA_CMD."v-change-mail-account-password ".escapeshellarg($v_user)." ".$v_domain." ".$v_account." ".$v_new_password, $output, $return_var);
158158
if ($return_var == 0) {
159159
echo "==ok==";
160160
exit;

0 commit comments

Comments
 (0)