Skip to content

Commit 5c3568a

Browse files
committed
Adjust let's encrypt validation check for idn domains, thanks to @zanami
This commit closes hestiacp#779
1 parent a2a26c7 commit 5c3568a

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ All notable changes to this project will be documented in this file.
88
- Disable Apache2 Server Status Module by default.
99
- Do not allow to change the password of a non-hestia user. Thanks to Alexandre Zanni!
1010
- Remove duplicated set-cookie line in default fpm config.
11+
- Adjust let's encrypt validation check for idn domains, thanks to @zanami!
1112

1213
## [1.1.1] - 2020-03-24 - Hotfix
1314
### Features

bin/v-add-letsencrypt-domain

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,9 @@ fi
134134
# Check if dns records exist for requested domain/aliases
135135
if [ "$proto" = "http-01" ]; then
136136
for identifier in $(echo $domain,$aliases |tr ',' '\n' |sort -u); do
137+
if [[ "$identifier" = *[![:ascii:]]* ]]; then
138+
identifier=$(idn -t --quiet -a $identifier)
139+
fi
137140
if ! nslookup "${identifier}" > /dev/null 2>&1 ; then
138141
check_result $E_NOTEXIST "DNS record for $identifier doesn't exist"
139142
fi

0 commit comments

Comments
 (0)