Fix: Infinite restart loop when server restart is invoked from the UI

Author: gdarko

web/restart/system/index.php

@@ -11,13 +11,29 @@
     exit();
 }
 
-if ($_SESSION['user'] == 'admin') {
-    if (!empty($_GET['hostname'])) {
-        exec (HESTIA_CMD."v-restart-system yes", $output, $return_var);
-        $_SESSION['error_msg'] = 'The system is going down for reboot NOW!';
+// If the session has the same reset token as the current request prevent restarting again.
+// This happens when the server is restarted, the admin panel goes down and the browser reloads
+// the /restart/index.php page once the server goes online causing restart loop.
+$reset_token_dir = '/var/tmp/';
+if (isset($_GET['system_reset_token']) && is_numeric($_GET['system_reset_token'])) {
+    clearstatcache();
+    $reset_token_file = $reset_token_dir . 'hst_reset_' . $_GET['system_reset_token'];
+    if (file_exists($reset_token_file)) {
+        unlink($reset_token_file);
+        sleep(5);
+        header('location: /list/server/');
+        exit();
+    }
+    if ($_SESSION['user'] == 'admin') {
+        if (!empty($_GET['hostname'])) {
+            touch($reset_token_file);
+            $_SESSION['error_msg'] = 'The system is going down for reboot NOW!';
+            touch($reset_token_file . '_persistent');
+            exec(HESTIA_CMD . "v-restart-system yes", $output, $return_var);
+        }
+        unset($output);
     }
-    unset($output);
 }
 
 header("Location: /list/server/");
-exit;
+exit();

web/templates/admin/list_services.html

@@ -10,7 +10,7 @@
               <a class="data-controls do_servicerestart ui-button danger cancel" title="<?=__('Restart')?>">
                 <i class="do_servicerestart fas fa-undo status-icon red"></i>
                 <?=__('Restart')?>
-                <input type="hidden" name="servicerestart_url" value="/restart/system/?hostname=<?php echo $sys['sysinfo']['HOSTNAME'] ?>&token=<?=$_SESSION['token']?>" />
+                <input type="hidden" name="servicerestart_url" value="/restart/system/?hostname=<?php echo $sys['sysinfo']['HOSTNAME'] ?>&token=<?=$_SESSION['token']?>&system_reset_token=<?php echo time(); ?>" />
                   <div class="confirmation-text-servicerestart hidden" title="<?=__('Confirmation')?>">
                     <p class="confirmation"><?=__('RESTART_CONFIRMATION', 'Server')?></p>
                   </div>