Fix Quick installer issues (hestiacp#2921)

* Some rare cases version might be empty

* Remove debug info

* If admin is not created status is not set

* Return correct status code

* Fix docuwiki installer

Install dir got changed due to new version

* Update to 2022-07-31a

See CVE-2022-3123

* Update opencart

* Use correct folder

* Update prestashop

Author: jaapmarcus

web/src/app/System/HestiaApp.php

@@ -28,7 +28,6 @@ public function run(string $cmd, $args, &$cmd_result=null): bool
         $cli_arguments = '';
         if (!empty($args) && is_array($args)) {
             foreach ($args as $arg) {
-                var_dump($arg);
                 $cli_arguments .= quoteshellarg((string)$arg) . ' ';
             }
         } else {
@@ -195,12 +194,17 @@ public function databaseAdd(string $dbname, string $dbuser, string $dbpass, stri
     public function getCurrentBackendTemplate(string $domain){
         $status = $this->runUser('v-list-web-domain', [$domain, 'json'],$return_message);
         $version = $return_message -> json[$domain]['BACKEND'];
-        if($version != "default"){
-            $test= preg_match('/^.*PHP-([0-9])\_([0-9])/',$version, $match);
-            return $match[1].'.'.$match[2];   
+        if (!empty($version)){
+            if($version != "default"){
+                $test= preg_match('/^.*PHP-([0-9])\_([0-9])/',$version, $match);
+                return $match[1].'.'.$match[2];   
+            }else{
+                $supported = $this -> run('v-list-sys-php', 'json', $result);
+                return $this -> $supported -> json[0];
+            }
         }else{
             $supported = $this -> run('v-list-sys-php', 'json', $result);
-            return $this -> $supported -> json[0];
+            return $this -> $supported -> json[0];  
         }                
     }
 

web/src/app/WebApp/Installers/DokuWiki/DokuWikiSetup.php

@@ -11,7 +11,7 @@ class DokuWikiSetup extends BaseSetup {
 		'name' => 'DokuWiki',
 		'group' => 'wiki',
 		'enabled' => true,
-		'version' => 'stable_2022-07-31',
+		'version' => 'stable_2022-07-31a',
 		'thumbnail' => 'dokuwiki-logo.svg'
 	];
 
@@ -48,7 +48,7 @@ class DokuWikiSetup extends BaseSetup {
 			],
 		 ],
 		'resources' => [
-			'archive'  => [ 'src' => 'https://github.com/splitbrain/dokuwiki/archive/refs/tags/release_stable_2022-07-31.zip' ],
+			'archive'  => [ 'src' => 'https://github.com/splitbrain/dokuwiki/archive/refs/tags/release_stable_2022-07-31a.zip' ],
 		],
 		'server' => [
 			'nginx' => [
@@ -72,7 +72,7 @@ public function install(array $options = null, &$status=null)
 		$webDomain = ($sslEnabled ? "https://" : "http://") . $this->domain . "/";
 
 		$this->appcontext->runUser('v-copy-fs-directory',[
-			$this->getDocRoot($this->extractsubdir . "/dokuwiki-release_stable_2020-07-29/."),
+			$this->getDocRoot($this->extractsubdir . "/dokuwiki-release_stable_2022-07-31a/."),
 			$this->getDocRoot()], $status);
 
 		// enable htaccess
@@ -100,7 +100,6 @@ public function install(array $options = null, &$status=null)
 		if($return_var > 0){
 			throw new \Exception(implode( PHP_EOL, $output));
 		}
-
 		// remove temp folder
 		$this->appcontext->runUser('v-delete-fs-file', [$this->getDocRoot("install.php")], $status);
 		$this->cleanup();

web/src/app/WebApp/Installers/Grav/GravSetup.php

@@ -60,7 +60,10 @@ public function install(array $options = null)
 				'-N '.$options['username'],
 				'-l en'
 			 ], $status);
+			 return ($status -> code === 0);
+		}else{
+			return true;
 		}
-		return ($status -> code === 1);
+
 	}
 }

web/src/app/WebApp/Installers/Opencart/OpencartSetup.php

@@ -10,7 +10,7 @@ class OpencartSetup extends BaseSetup
         'name' => 'Opencart',
         'group' => 'ecommerce',
         'enabled' => true,
-        'version' => '4.0.0.0',
+        'version' => '4.0.1.1',
         'thumbnail' => 'opencart-thumb.png'
     ];
 
@@ -25,7 +25,7 @@ class OpencartSetup extends BaseSetup
             ],
         'database' => true,
         'resources' => [
-            'archive'  => [ 'src' => 'https://github.com/opencart/opencart/releases/download/4.0.0.0/opencart-4.0.0.0.zip' ],
+            'archive'  => [ 'src' => 'https://github.com/opencart/opencart/releases/download/4.0.1.1/opencart-4.0.1.1.zip' ],
         ],
         'server' => [
             'nginx' => [

web/src/app/WebApp/Installers/Prestashop/PrestashopSetup.php

@@ -10,7 +10,7 @@ class PrestashopSetup extends BaseSetup
         'name' => 'Prestashop',
         'group' => 'ecommerce',
         'enabled' => true,
-        'version' => '1.7.8.6',
+        'version' => '1.7.8.7',
         'thumbnail' => 'prestashop-thumb.png'
     ];
 
@@ -26,7 +26,7 @@ class PrestashopSetup extends BaseSetup
             ],
         'database' => true,
         'resources' => [
-            'archive'  => [ 'src' => 'https://github.com/PrestaShop/PrestaShop/releases/download/1.7.8.6/prestashop_1.7.8.6.zip' ],
+            'archive'  => [ 'src' => 'https://github.com/PrestaShop/PrestaShop/releases/download/1.7.8.7/prestashop_1.7.8.7.zip' ],
         ],
         'server' => [
             'nginx' => [