Remove error_reporting(null) + Small fixes (hestiacp#2365)

* Remove error_reporting(null)

* Remove edit protection default package

Create a protected "System" package for admin user

* Alter check edit package

* hestiacp#2359 Disable dropbox when api is disabled

Add link for more info

* Add new system.pkg on existing installs

* Update system.pkg

Allowing to add 1 mail domain for sending email

* Increase some default values

1 DNS record on default is to low at 13 are required for web domain + mail domain

Co-authored-by: Raphael Schneeberger <rs@scit.ch>

Author: jaapmarcus

install/deb/packages/system.pkg

@@ -0,0 +1,19 @@
+WEB_TEMPLATE='default'
+PROXY_TEMPLATE='default'
+BACKEND_TEMPLATE='default'
+DNS_TEMPLATE='default'
+WEB_DOMAINS='1'
+WEB_ALIASES='0'
+DNS_DOMAINS='1'
+DNS_RECORDS='unlimited'
+MAIL_DOMAINS='1'
+MAIL_ACCOUNTS='1'
+DATABASES='0'
+CRON_JOBS='unlimited'
+DISK_QUOTA='unlimited'
+BANDWIDTH='unlimited'
+NS='ns1.domain.tld,ns2.domain.tld'
+SHELL='nologin'
+BACKUPS='1'
+TIME='00:00:00'
+DATE='2022-01-20'

install/hst-install-debian.sh

@@ -1296,7 +1296,7 @@ if [ "$release" -eq 11 ]; then
 fi
 
 # Adding Hestia admin account
-$HESTIA/bin/v-add-user admin $vpass $email default "System Administrator"
+$HESTIA/bin/v-add-user admin $vpass $email "system" "System Administrator"
 check_result $? "can't create admin user"
 $HESTIA/bin/v-change-user-shell admin nologin
 $HESTIA/bin/v-change-user-role admin admin

install/hst-install-ubuntu.sh

@@ -1327,7 +1327,7 @@ check_result $? "can't enable sftp jail"
 
 # Adding Hestia admin account
 echo "[ * ] Create admin account..."
-$HESTIA/bin/v-add-user admin $vpass $email default "System Administrator"
+$HESTIA/bin/v-add-user admin $vpass $email "system" "System Administrator"
 check_result $? "can't create admin user"
 $HESTIA/bin/v-change-user-shell admin nologin
 $HESTIA/bin/v-change-user-role admin admin

install/upgrade/versions/1.5.5.sh

@@ -94,6 +94,11 @@ if [ ! -f "/usr/share/keyrings/nginx-keyring.gpg" ]; then
 
 fi
 
+if [ ! -f "$HESTIA/data/packages/system.pkg" ]; then 
+    echo "[ * ] Install default system package."
+    cp -f $HESTIA/install/deb/packages/system.pkg $HESTIA/data/packages/system.pkg
+fi
+
 echo "[ * ] Refresh Hostname SSL"
 hostname=$(hostname);
 user=$(v-search-domain-owner "$hostname");

web/add/cron/autoupdate/index.php

@@ -1,9 +1,5 @@
 <?php
-
-// Init
-error_reporting(null);
 ob_start();
-session_start();
 include($_SERVER['DOCUMENT_ROOT']."/inc/main.php");
 
 // Check token

web/add/cron/index.php

@@ -1,6 +1,4 @@
 <?php
-
-error_reporting(null);
 ob_start();
 $TAB = 'CRON';
 

web/add/cron/reports/index.php

@@ -1,9 +1,5 @@
 <?php
-
-// Init
-error_reporting(null);
 ob_start();
-session_start();
 include($_SERVER['DOCUMENT_ROOT']."/inc/main.php");
 
 // Check token

web/add/db/index.php

@@ -1,6 +1,4 @@
 <?php
-
-error_reporting(null);
 ob_start();
 $TAB = 'DB';
 

web/add/dns/index.php

@@ -1,6 +1,4 @@
 <?php
-
-error_reporting(null);
 ob_start();
 $TAB = 'DNS';
 

web/add/firewall/banlist/index.php

@@ -1,6 +1,4 @@
 <?php
-
-error_reporting(null);
 ob_start();
 $TAB = 'FIREWALL';