Skip to content

Commit 387f673

Browse files
committed
Changed cmd Query on Api index.php
To avoid "Notice : undefined variables " changed the way the cmd query is built by validating each argument Not empty into the cmd command string
1 parent 2828dfc commit 387f673

File tree

1 file changed

+22
-5
lines changed

1 file changed

+22
-5
lines changed

web/api/index.php

Lines changed: 22 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,7 @@
2626
echo 'Error: only admin is allowed to use API';
2727
exit;
2828
}
29-
// Not Declaring arguments may cause Notifies on the response on an API Call when the Directive Dysplay errors is enabled
30-
// you may initialize argument arg1, arg2,... arg9 to = '' here
31-
// Or post the unused args to =''
29+
3230

3331
// Prepare arguments
3432
if (isset($_POST['cmd'])) $cmd = escapeshellarg($_POST['cmd']);
@@ -42,8 +40,27 @@
4240
if (isset($_POST['arg8'])) $arg8 = escapeshellarg($_POST['arg8']);
4341
if (isset($_POST['arg9'])) $arg9 = escapeshellarg($_POST['arg9']);
4442

45-
// Run query
46-
exec (VESTA_CMD.$cmd." ".$arg1." ".$arg2." ".$arg3." ".$arg4." ".$arg5." ".$arg6." ".$arg7." ".$arg8." ".$arg9, $output, $return_var);
43+
// Build query
44+
$cmdquery = VESTA_CMD.$cmd." ".$arg1." ".$arg2." ";
45+
if(!empty($arg3)){
46+
$cmdquery = $cmdquery.$arg3." "; }
47+
if(!empty($arg4)){
48+
$cmdquery = $cmdquery.$arg4." "; }
49+
50+
if(!empty($arg5)){
51+
$cmdquery = $cmdquery.$arg5." "; }
52+
if(!empty($arg6)){
53+
$cmdquery = $cmdquery.$arg6." "; }
54+
if(!empty($arg7)){
55+
$cmdquery = $cmdquery.$arg7." "; }
56+
if(!empty($arg8)){
57+
$cmdquery = $cmdquery.$arg8." "; }
58+
if(!empty($arg9)){
59+
$cmdquery = $cmdquery.$arg9; }
60+
61+
// Run query
62+
exec ($cmdquery, $output, $return_var);
63+
4764
if ((!empty($_POST['returncode'])) && ($_POST['returncode'] == 'yes')) {
4865
echo $return_var;
4966
} else {

0 commit comments

Comments
 (0)