Skip to content

Commit 351c0cf

Browse files
authored
Merge pull request hestiacp#2888 from jaapmarcus/fix/multiple-dns-clusters
Fix issue password and hash mixed up
2 parents fe967bd + 27f2391 commit 351c0cf

10 files changed

+47
-9
lines changed

bin/v-add-remote-dns-domain

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,10 @@ fi
5959

6060
IFS=$'\n'
6161
for cluster in $(grep "SUSPENDED='no'" $HESTIA/conf/dns-cluster.conf); do
62-
62+
63+
# Reset user, password and hash vars
64+
clear_dns_cluster_settings
65+
6366
# Parsing remote dns host parameters
6467
parse_object_kv_list "$cluster"
6568

bin/v-add-remote-dns-record

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,10 @@ fi
5757

5858
IFS=$'\n'
5959
for cluster in $(grep "SUSPENDED='no'" $HESTIA/conf/dns-cluster.conf); do
60-
60+
61+
# Reset user, password and hash vars
62+
clear_dns_cluster_settings
63+
6164
# Parsing remote host parameters
6265
parse_object_kv_list "$cluster"
6366

bin/v-change-remote-dns-domain-exp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,10 @@ check_hestia_demo_mode
4343

4444
IFS=$'\n'
4545
for cluster in $(grep "SUSPENDED='no'" $HESTIA/conf/dns-cluster.conf); do
46-
46+
47+
# Reset user, password and hash vars
48+
clear_dns_cluster_settings
49+
4750
# Parsing remote host parameters
4851
parse_object_kv_list "$cluster"
4952

bin/v-change-remote-dns-domain-soa

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,10 @@ check_hestia_demo_mode
4545

4646
IFS=$'\n'
4747
for cluster in $(grep "SUSPENDED='no'" $HESTIA/conf/dns-cluster.conf); do
48-
48+
49+
# Reset user, password and hash vars
50+
clear_dns_cluster_settings
51+
4952
# Parsing remote host parameters
5053
parse_object_kv_list "$cluster"
5154

bin/v-change-remote-dns-domain-ttl

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,10 @@ check_hestia_demo_mode
4545

4646
IFS=$'\n'
4747
for cluster in $(grep "SUSPENDED='no'" $HESTIA/conf/dns-cluster.conf); do
48-
48+
49+
# Reset user, password and hash vars
50+
clear_dns_cluster_settings
51+
4952
# Parsing remote host parameters
5053
parse_object_kv_list "$cluster"
5154

bin/v-delete-remote-dns-domain

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,10 @@ check_hestia_demo_mode
4444
# Starting cluster loop
4545
IFS=$'\n'
4646
for cluster in $(grep "SUSPENDED='no'" $HESTIA/conf/dns-cluster.conf); do
47-
47+
48+
# Reset user, password and hash vars
49+
clear_dns_cluster_settings
50+
4851
# Parsing remote host parameters
4952
parse_object_kv_list "$cluster"
5053

bin/v-delete-remote-dns-domains

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,10 @@ fi
4747

4848
# Starting cluster loop
4949
for cluster in $hosts; do
50-
50+
51+
# Reset user, password and hash vars
52+
clear_dns_cluster_settings
53+
5154
# Parsing remote host parameters
5255
parse_object_kv_list "$cluster"
5356

bin/v-delete-remote-dns-record

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,10 @@ check_hestia_demo_mode
4545
# Starting cluster loop
4646
IFS=$'\n'
4747
for cluster in $(cat $HESTIA/conf/dns-cluster.conf); do
48-
48+
49+
# Reset user, password and hash vars
50+
clear_dns_cluster_settings
51+
4952
# Parsing remote host parameters
5053
parse_object_kv_list "$cluster"
5154

bin/v-sync-dns-cluster

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,10 @@ fi
4747

4848
# Starting cluster loop
4949
for cluster in $hosts; do
50-
50+
51+
# Reset user, password and hash vars
52+
clear_dns_cluster_settings
53+
5154
# Parsing host values
5255
parse_object_kv_list "$cluster"
5356

func/remote.sh

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,11 @@ remote_dns_health_check() {
128128

129129
# Starting health-check
130130
for str in $(grep "SUSPENDED='no'" $HESTIA/conf/dns-cluster.conf); do
131+
132+
# Reset user, password and hash vars
133+
clear_dns_cluster_settings
134+
135+
# Parsing host values
131136
parse_object_kv_list "$str"
132137

133138
# Checking host connection
@@ -178,3 +183,9 @@ cluster_file() {
178183
api) send_api_file $* ;;
179184
esac
180185
}
186+
187+
clear_dns_cluster_settings (){
188+
unset USER
189+
unset PASSWORD
190+
unset HASH
191+
}

0 commit comments

Comments
 (0)