Skip to content

Commit 2affbcf

Browse files
author
Kristan Kenney
authored
Merge pull request hestiacp#288 from Lupul/bugfix-0504-1
Force HTTPS/SSL bug fixes
2 parents 9c8c727 + d0ac9b0 commit 2affbcf

File tree

2 files changed

+16
-4
lines changed

2 files changed

+16
-4
lines changed

bin/v-add-web-domain-ssl-force

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ if [ "$SSL" != 'yes' ]; then
4343
fi
4444

4545
# Check if proxy is active
46-
if [ ! -z "$PROXY_SYSTEM" ] || [ ! -z "$PROXY" ]; then
46+
if [ ! -z "$PROXY_SYSTEM" ]; then
4747
if ! grep --quiet "forcessl" $HESTIA/data/templates/web/nginx/default.tpl; then
4848
$BIN/v-update-web-templates
4949
fi
@@ -56,7 +56,7 @@ else
5656
fi
5757

5858
# Insert redirect commands
59-
if [ ! -z $PROXY ]; then
59+
if [ ! -z "$PROXY_SYSTEM" ] || [ "$WEB_SYSTEM" = 'nginx' ]; then
6060
echo 'return 301 https://$host$request_uri;' > $forcessl
6161
else
6262
echo 'RewriteEngine On' > $forcessl
@@ -68,6 +68,10 @@ fi
6868
# Hestia #
6969
#----------------------------------------------------------#
7070

71+
if [ -z "$FORCESSL" ]; then
72+
add_object_key "web" 'DOMAIN' "$domain" 'FORCESSL' 'SSL'
73+
fi
74+
7175
# Set forcessl flag to enabled
7276
update_object_value 'web' 'DOMAIN' "$domain" '$FORCESSL' 'yes'
7377

bin/v-delete-web-domain-ssl-force

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,21 @@ is_object_valid 'web' 'DOMAIN' "$domain" "$FORCESSL"
3838
eval $(grep "DOMAIN='$domain'" $USER_DATA/web.conf)
3939

4040
# Remove forcessl configs
41-
rm -f $HOMEDIR/$user/conf/web/$domain/$WEB_SYSTEM.forcessl.conf
42-
rm -f $HOMEDIR/$user/conf/web/$domain/$PROXY_SYSTEM.forcessl.conf
41+
if [ -f $HOMEDIR/$user/conf/web/$domain/$WEB_SYSTEM.forcessl.conf ]; then
42+
rm -f $HOMEDIR/$user/conf/web/$domain/$WEB_SYSTEM.forcessl.conf
43+
fi
44+
if [ -f $HOMEDIR/$user/conf/web/$domain/$PROXY_SYSTEM.forcessl.conf ]; then
45+
rm -f $HOMEDIR/$user/conf/web/$domain/$PROXY_SYSTEM.forcessl.conf
46+
fi
4347

4448
#----------------------------------------------------------#
4549
# Hestia #
4650
#----------------------------------------------------------#
4751

52+
if [ -z "$FORCESSL" ]; then
53+
add_object_key "web" 'DOMAIN' "$domain" 'FORCESSL' 'SSL'
54+
fi
55+
4856
update_object_value 'web' 'DOMAIN' "$domain" '$FORCESSL' 'no'
4957

5058
# Restart services if requested

0 commit comments

Comments
 (0)