Skip to content

Commit 10c3156

Browse files
author
Kristan Kenney
committed
Prevent editing 'admin' user cron jobs
1 parent 13895cc commit 10c3156

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

web/templates/admin/list_cron.html

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,16 +90,21 @@
9090
<div class="clearfix l-unit__stat-col--left super-compact">
9191
<input id="check<?php echo $i ?>" class="ch-toggle" type="checkbox" name="job[]" value="<?php echo $key ?>">
9292
</div>
93-
94-
<div class="clearfix l-unit__stat-col--left wide-5 truncate"><b><a href="/edit/cron/?job=<?=$data[$key]['JOB']?>&token=<?=$_SESSION['token']?>" title="<?=_('Editing Cron Job')?>"><?=htmlspecialchars($data[$key]['CMD'], ENT_NOQUOTES)?></a></b> </div>
93+
<div class="clearfix l-unit__stat-col--left wide-5 truncate">
94+
<? if (($_SESSION['userContext'] === 'admin') && (isset($_SESSION['look'])) && ($_SESSION['look'] === 'admin')) {?>
95+
<b><?=htmlspecialchars($data[$key]['CMD'], ENT_NOQUOTES)?></b>
96+
<? } else { ?>
97+
<b><a href="/edit/cron/?job=<?=$data[$key]['JOB']?>&token=<?=$_SESSION['token']?>" title="<?=_('Editing Cron Job')?>"><?=htmlspecialchars($data[$key]['CMD'], ENT_NOQUOTES)?></a></b>
98+
<? } ?>
99+
</div>
95100
<!-- START QUICK ACTION TOOLBAR AREA -->
96101
<div class="clearfix l-unit__stat-col--left compact-2 text-right">
97102
<div class="l-unit-toolbar__col l-unit-toolbar__col--right noselect">
98103
<div class="actions-panel clearfix">
99104
<? if (($_SESSION['userContext'] === 'admin') && (isset($_SESSION['look'])) && ($_SESSION['look'] === 'admin')) {?>
100-
<!-- Restrict other administrators from deleting or suspending 'admin' user cron jobs -->
101-
<div class="actions-panel__col actions-panel__download shortcut-enter" key-action="href"><a href="/edit/cron/?job=<?=$data[$key]['JOB']?>&token=<?=$_SESSION['token']?>" title="<?=_('Editing Cron Job')?>"><i class="fas fa-pencil-alt status-icon orange status-icon dim"></i></a></div>
105+
<!-- Restrict other administrators from editing, deleting, or suspending 'admin' user cron jobs -->
102106
<? } else { ?>
107+
<div class="actions-panel__col actions-panel__download shortcut-enter" key-action="href"><a href="/edit/cron/?job=<?=$data[$key]['JOB']?>&token=<?=$_SESSION['token']?>" title="<?=_('Editing Cron Job')?>"><i class="fas fa-pencil-alt status-icon orange status-icon dim"></i></a></div>
103108
<div class="actions-panel__col actions-panel__suspend shortcut-s" key-action="js">
104109
<a id="<?=$spnd_action ?>_link_<?=$i?>" class="data-controls do_<?=$spnd_action?>" title="<?=_($spnd_action)?>">
105110
<i class="fas <?=$spnd_icon?> status-icon highlight status-icon dim do_<?=$spnd_action?>"></i>

0 commit comments

Comments
 (0)