Skip to content

Commit 0878fec

Browse files
committed
Sec: Fix input validation in v-get-(dns,mail)-domain-value scripts
1 parent 79290ad commit 0878fec

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

bin/v-get-dns-domain-value

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
user=$1
1414
domain=$2
1515
domain_idn=$2
16-
key=$(echo "$3"| tr '[:lower:]' '[:upper:]' | sed "s/^/$/")
16+
key=$3
1717

1818
# Includes
1919
source $HESTIA/func/main.sh
@@ -29,10 +29,11 @@ format_domain_idn
2929
#----------------------------------------------------------#
3030

3131
check_args '3' "$#" 'USER DOMAIN KEY'
32-
is_format_valid 'user' 'domain'
32+
is_format_valid 'user' 'domain' 'key'
3333
is_object_valid 'user' 'USER' "$user"
3434
is_object_valid 'dns' 'DOMAIN' "$domain"
3535

36+
key=$(echo "$key"| tr '[:lower:]' '[:upper:]' | sed "s/^/$/")
3637

3738
#----------------------------------------------------------#
3839
# Action #

bin/v-get-mail-account-value

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ user=$1
1414
domain=$2
1515
domain_idn=$2
1616
account=$3
17-
key=$(echo "$4"| tr '[:lower:]' '[:upper:]' | sed "s/^/$/")
17+
key=$4
1818

1919
# Includes
2020
source $HESTIA/func/main.sh
@@ -30,11 +30,12 @@ format_domain_idn
3030
#----------------------------------------------------------#
3131

3232
check_args '3' "$#" 'USER DOMAIN KEY'
33-
is_format_valid 'user' 'domain'
33+
is_format_valid 'user' 'domain' 'key'
3434
is_object_valid 'user' 'USER' "$user"
3535
is_object_valid 'mail' 'DOMAIN' "$domain"
3636
is_object_valid "mail/$domain" 'ACCOUNT' "$account"
3737

38+
key=$(echo "$key"| tr '[:lower:]' '[:upper:]' | sed "s/^/$/")
3839

3940
#----------------------------------------------------------#
4041
# Action #

bin/v-get-mail-domain-value

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
user=$1
1414
domain=$2
1515
domain_idn=$2
16-
key=$(echo "$3"| tr '[:lower:]' '[:upper:]' | sed "s/^/$/")
16+
key=$3
1717

1818
# Includes
1919
source $HESTIA/func/main.sh
@@ -29,10 +29,11 @@ format_domain_idn
2929
#----------------------------------------------------------#
3030

3131
check_args '3' "$#" 'USER DOMAIN KEY'
32-
is_format_valid 'user' 'domain'
32+
is_format_valid 'user' 'domain' 'key'
3333
is_object_valid 'user' 'USER' "$user"
3434
is_object_valid 'mail' 'DOMAIN' "$domain"
3535

36+
key=$(echo "$key"| tr '[:lower:]' '[:upper:]' | sed "s/^/$/")
3637

3738
#----------------------------------------------------------#
3839
# Action #

0 commit comments

Comments
 (0)