Skip to content

Commit 02c0292

Browse files
committed
Bugfix overwrite correct templates when using multiphp
- multiphp upgrade script used a undefine variable - When rebuilding web domains, do not assume deprecated config file to be present
1 parent e7949c3 commit 02c0292

File tree

4 files changed

+28
-7
lines changed

4 files changed

+28
-7
lines changed

bin/v-rebuild-web-domains

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,9 @@ is_object_unsuspended 'user' 'USER' "$user"
3737
#----------------------------------------------------------#
3838

3939
# Deleting old web configs
40-
sed -i "/.*\/$user\/conf\/web\//d" /etc/$WEB_SYSTEM/conf.d/hestia.conf
40+
if [ -e /etc/$WEB_SYSTEM/conf.d/hestia.conf ]; then
41+
sed -i "/.*\/$user\/conf\/web\//d" /etc/$WEB_SYSTEM/conf.d/hestia.conf
42+
fi
4143

4244
if [ -e "$HOMEDIR/$user/conf/web/$domain/$WEB_SYSTEM.conf" ]; then
4345
rm -f $HOMEDIR/$user/conf/web/$domain/$WEB_SYSTEM.conf
@@ -50,7 +52,9 @@ fi
5052

5153
# Deleting old proxy configs
5254
if [ ! -z "$PROXY_SYSTEM" ]; then
53-
sed -i "/.*\/$user\/conf\/web\//d" /etc/$PROXY_SYSTEM/conf.d/hestia.conf
55+
if [ -e /etc/$PROXY_SYSTEM/conf.d/hestia.conf ]; then
56+
sed -i "/.*\/$user\/conf\/web\//d" /etc/$PROXY_SYSTEM/conf.d/hestia.conf
57+
fi
5458

5559
if [ -e "$HOMEDIR/$user/conf/web/$domain/$PROXY_SYSTEM.conf" ]; then
5660
rm -f $HOMEDIR/$user/conf/web/$domain/$PROXY_SYSTEM.conf

bin/v-update-web-templates

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,21 @@ fi
4040
# Update templates
4141
cp -rf $HESTIA/install/$type/templates/web $HESTIA/data/templates/
4242

43+
# Update Multiphp templates
44+
php_versions=$( ls -l /etc/php/ | grep ^d | wc -l )
45+
if [ "$php_versions" -gt 1 ]; then
46+
if [ "$WEB_SYSTEM" = "nginx" ]; then
47+
for tplname in $(ls $HESTIA/data/templates/web/$WEB_SYSTEM/ | grep -v 'default'); do
48+
rm -fr $HESTIA/data/templates/web/$WEB_SYSTEM/$tplname
49+
done
50+
fi
51+
for v in $(ls /etc/php/); do
52+
v_tpl=$(echo "$v" | sed -e 's/[.]//')
53+
cp -f $HESTIA/install/$type/multiphp/$WEB_SYSTEM/PHP-$v_tpl.* $HESTIA/data/templates/web/$WEB_SYSTEM/
54+
done
55+
chmod a+x $HESTIA/data/templates/web/$WEB_SYSTEM/*.sh
56+
fi
57+
4358
# Rebuilding web domains
4459
for user in $($BIN/v-list-sys-users plain); do
4560
$BIN/v-rebuild-web-domains $user no

func/domain.sh

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -307,10 +307,12 @@ del_web_config() {
307307
fi
308308

309309
# Remove domain configuration files and clean up symbolic links
310-
rm -f /etc/$WEB_SYSTEM/conf.d/domains/$domain.conf
311-
rm -f /etc/$PROXY_SYSTEM/conf.d/domains/$domain.conf
312-
rm -f /etc/$WEB_SYSTEM/conf.d/domains/$domain.ssl.conf
313-
rm -f /etc/$PROXY_SYSTEM/conf.d/domains/$domain.ssl.conf
310+
rm -f /etc/$WEB_SYSTEM/conf.d/domains/$domain.conf
311+
rm -f /etc/$WEB_SYSTEM/conf.d/domains/$domain.ssl.conf
312+
if [ ! -z $PROXY_SYSTEM ]; then
313+
rm -f /etc/$PROXY_SYSTEM/conf.d/domains/$domain.conf
314+
rm -f /etc/$PROXY_SYSTEM/conf.d/domains/$domain.ssl.conf
315+
fi
314316

315317
# Clean up legacy configuration files
316318
if [ -e "$conf" ]; then

install/upgrade/0.10.0-190430.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ fi
171171
php_versions=$( ls -l /etc/php/ | grep ^d | wc -l )
172172
if [ "$php_versions" -gt 1 ]; then
173173
for v in $(ls /etc/php/); do
174-
cp -f $hestiacp/php-fpm/dummy.conf /etc/php/$d/fpm/pool.d/
174+
cp -f $hestiacp/php-fpm/dummy.conf /etc/php/$v/fpm/pool.d/
175175
v1=$(echo "$v" | sed -e 's/[.]//')
176176
sed -i "s/9999/99$v1/g" /etc/php/$v/fpm/pool.d/dummy.conf
177177
done

0 commit comments

Comments
 (0)