Skip to content

Commit 0220e08

Browse files
authored
Merge pull request hestiacp#2819 from jaapmarcus/fix/2815-email-does-not-include-password
2815 [Bug] - Notification mail account dont include Password when creating
2 parents a9fa2e3 + f93b84d commit 0220e08

File tree

17 files changed

+122
-273
lines changed

17 files changed

+122
-273
lines changed

bin/v-update-sys-hestia-git

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,13 @@ fork=$1
122122
branch=$2
123123
install=$3
124124

125+
# Allow the use of username:branch instead of username branch
126+
# Both fork and branch names can't contain a : anyway
127+
if [ -z "$branch" ]; then
128+
branch=$(echo "$fork" | cut -d ":" -f2)
129+
fork=$(echo "$fork" | cut -d ":" -f1)
130+
fi
131+
125132
# Set Version for compiling
126133
BUILD_VER=$(curl -s https://raw.githubusercontent.com/$fork/hestiacp/$branch/src/deb/hestia/control | grep "Version:" | cut -d' ' -f2)
127134
HESTIA_V="${BUILD_VER}_${BUILD_ARCH}"

install/common/roundcube/db.inc.php

Lines changed: 0 additions & 66 deletions
This file was deleted.

install/common/roundcube/main.inc.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,5 +103,4 @@
103103
$config['smtp_host'] = 'localhost:587';
104104

105105
// Log session authentication errors to <log_dir>/session or to syslog
106-
$config['log_session'] = true;
107-
?>
106+
$config['log_session'] = true;

install/common/roundcube/mimetypes.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,4 @@
5353
's7z' => 'application/x-7z-compressed',
5454
'vcf' => 'text/vcard',
5555
'ics' => 'text/calendar',
56-
);
57-
58-
?>
56+
);

install/upgrade/manual/install_sieve.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ if [ "$HAS_DOVECOT_SIEVE_INSTALLED" = "0" ]; then
6868
# roundcube install
6969
mkdir -p $RC_CONFIG_DIR/plugins/managesieve
7070

71-
cp -f $HESTIA_INSTALL_DIR/roundcube/plugins/config_managesieve.inc.php $RC_CONFIG_DIR/plugins/managesieve/config.inc.php
71+
cp -f $HESTIA_COMMON_DIR/roundcube/plugins/config_managesieve.inc.php $RC_CONFIG_DIR/plugins/managesieve/config.inc.php
7272
ln -s $RC_CONFIG_DIR/plugins/managesieve/config.inc.php $RC_INSTALL_DIR/plugins/managesieve/config.inc.php
7373

7474
# permission changes
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
#!/bin/bash
2+
3+
# Hestia Control Panel upgrade script for target version unknow
4+
5+
#######################################################################################
6+
####### Place additional commands below. #######
7+
#######################################################################################
8+
####### Pass through information to the end user in case of a issue or problem #######
9+
####### #######
10+
####### Use add_upgrade_message "My message here" to include a message #######
11+
####### in the upgrade notification email. Example: #######
12+
####### #######
13+
####### add_upgrade_message "My message here" #######
14+
####### #######
15+
####### You can use \n within the string to create new lines. #######
16+
#######################################################################################
17+
18+
upgrade_config_set_value 'UPGRADE_UPDATE_WEB_TEMPLATES' 'no'
19+
upgrade_config_set_value 'UPGRADE_UPDATE_DNS_TEMPLATES' 'no'
20+
upgrade_config_set_value 'UPGRADE_UPDATE_MAIL_TEMPLATES' 'no'
21+
upgrade_config_set_value 'UPGRADE_REBUILD_USERS' 'no'
22+
upgrade_config_set_value 'UPGRADE_UPDATE_FILEMANAGER_CONFIG' 'false'
23+
24+
# make sure to sync install qouteshellarg
25+
$HESTIA/bin/v-add-sys-phpmailer
26+
if [ "$FILE_MANAGER" = "true" ]; then
27+
# Sync up filemanger
28+
$HESTIA/bin/v-delete-sys-filemanger
29+
$HESTIA/bin/v-add-sys-filemanger
30+
fi
31+
32+
# Sync up config files #2819
33+
if [ -f "/etc/roundcube/config.inc.php" ]; then
34+
sed -i "s/?>//" /etc/roundcube/config.inc.php
35+
sed -i "s/?>//" /etc/roundcube/mimetypes.php
36+
fi

web/add/db/index.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@
114114
if ((!empty($v_db_email)) && (empty($_SESSION['error_msg']))) {
115115
$to = $v_db_email;
116116
$subject = _("Database Credentials");
117-
$hostname = exec('hostname');
117+
$hostname = get_hostname();
118118
$from = "noreply@".$hostname;
119119
$from_name = _('Hestia Control Panel');
120120
$mailtext = sprintf(_('DATABASE_READY'), $user_plain."_".$_POST['v_database'], $user_plain."_".$_POST['v_dbuser'], $_POST['v_password'], $db_admin_link);

web/add/mail/index.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@
287287
if ((!empty($v_send_email)) && (empty($_SESSION['error_msg']))) {
288288
$to = $v_send_email;
289289
$subject = _("Email Credentials");
290-
$hostname = exec('hostname');
290+
$hostname = get_hostname();
291291
$from = "noreply@".$hostname;
292292
$from_name = _('Hestia Control Panel');
293293
$mailtext = $v_credentials;

web/add/user/index.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@
112112
putenv("LANGUAGE=".$_POST['v_language']);
113113

114114
$subject = _("Welcome to Hestia Control Panel");
115-
$hostname = exec('hostname');
115+
$hostname = get_hostname();
116116
unset($output);
117117
$from = "noreply@".$hostname;
118118
$from_name = _('Hestia Control Panel');

web/edit/mail/index.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -652,7 +652,7 @@
652652
if ((!empty($v_send_email)) && (empty($_SESSION['error_msg']))) {
653653
$to = $v_send_email;
654654
$subject = _("Email Credentials");
655-
$hostname = exec('hostname');
655+
$hostname = get_hostname();
656656
$from = "noreply@".$hostname;
657657
$from_name = _('Hestia Control Panel');
658658
$mailtext = $v_credentials;

0 commit comments

Comments
 (0)