test_render_view.py

"""Renderer + view assembly: content, escaping, and the wired demo view."""

from __future__ import annotations

from pathlib import Path

from app.a11y_check import check_html
from app.render import render_dashboard
from app.view import build_view, demo_view, render_view
from ingest.models import (
    Author,
    Book,
    DailyActivity,
    ReadingState,
    ReadingStatus,
    Source,
    SourceKind,
    ThemeTag,
)
from ingest.store import CatalogPoolStatus, CatalogSourceStatus


def test_demo_view_has_expected_shape(tmp_path: Path) -> None:
    view = demo_view(tmp_path)
    assert view.user == "demo"
    assert view.currently_reading
    assert view.finished
    assert view.recommendations
    assert view.stats.books_finished >= 7
    assert view.wrapped.year == 2024


def test_render_contains_all_sections(tmp_path: Path) -> None:
    view = demo_view(tmp_path)
    html = render_dashboard(
        view.currently_reading,
        view.finished,
        view.stats,
        view.wrapped,
        view.recommendations,
        user=view.user,
    )
    for heading in (
        "Currently reading",
        "Time to finish",
        "Reading stats",
        "Reading Wrapped",
        "Recommended for you",
        "Recently finished",
    ):
        assert heading in html
    # Every rec card shows a source link and a why.
    assert "Why recommended" in html
    assert "Sources" in html
    # Cards are the single accessible recommendation presentation.
    assert "Recommendation fit scores" not in html
    assert 'aria-label="Dashboard sections"' in html
    assert 'action="/browse" method="get"' in html
    assert 'aria-label="Reading progress for Stone Butch Blues"' in html
    # Themes are rendered as text chips, not colour-only.
    assert 'class="tag"' in html


def test_render_escapes_user_content() -> None:
    src = Source(SourceKind.CALIBRE_TAG, "calibre:local", "2026-06-05", "x")
    book = Book(
        book_id="b",
        title="<script>alert(1)</script>",
        authors=(Author("A & B"),),
        theme_tags=(ThemeTag("queer", src),),
    )
    state = ReadingState(
        title=book.title, authors=("A & B",), status=ReadingStatus.READING, book=book
    )
    from app.stats import compute_stats
    from app.wrapped import compute_wrapped

    stats = compute_stats([state], [], 0)
    wrapped = compute_wrapped([state], [], 2024)
    html = render_dashboard([state], [], stats, wrapped, [], user="me")
    assert "<script>alert(1)</script>" not in html
    assert "&lt;script&gt;" in html
    assert "A &amp; B" in html


def test_build_view_empty_inputs() -> None:
    view = build_view([], [], (), lists=())
    assert view.recommendations == ()
    assert view.stats.books_finished == 0
    assert view.currently_reading == ()


def test_render_handles_empty_view() -> None:
    view = build_view([], [DailyActivity(0, 0, 0)], ())
    html = render_dashboard(
        view.currently_reading,
        view.finished,
        view.stats,
        view.wrapped,
        view.recommendations,
    )
    assert "Nothing in progress" in html
    assert "No recommendation candidates are stored yet" in html


def test_render_preserves_browse_query_and_exposes_live_count() -> None:
    view = build_view([], [DailyActivity(0, 0, 0)], ())
    html = render_dashboard(
        view.currently_reading,
        view.finished,
        view.stats,
        view.wrapped,
        view.recommendations,
        browse_query='queer "history"',
        browse_theme='trans "history"',
        browse_status="unread",
    )
    assert 'value="queer &quot;history&quot;"' in html
    assert 'type="hidden" name="theme" value="trans &quot;history&quot;"' in html
    assert 'type="hidden" name="status" value="unread"' in html
    assert 'id="lib-filter-status"' in html
    assert 'aria-live="polite"' in html


def test_render_caps_large_library_preview_but_reports_full_count() -> None:
    view = build_view([], [DailyActivity(0, 0, 0)], ())
    library = [
        ReadingState(
            title=f"Book {index:03}",
            authors=("Reader",),
            status=ReadingStatus.UNREAD,
        )
        for index in range(101)
    ]
    html = render_dashboard(
        view.currently_reading,
        view.finished,
        view.stats,
        view.wrapped,
        view.recommendations,
        library=library,
    )
    assert "Showing the first 100 of 101 books" in html
    assert 'data-complete="false"' in html
    assert "Book 099" in html
    assert "Book 100" not in html


def test_render_catalog_degradation_exposes_last_good_fallback() -> None:
    view = build_view([], [DailyActivity(0, 0, 0)], ())
    status = CatalogPoolStatus(
        outbound_mode="public-metadata",
        state="degraded",
        attempted_at=1_700_000_010,
        candidate_count=2,
        sources=(
            CatalogSourceStatus(
                source_id="openlibrary:subject/lgbt",
                status="error",
                attempted_at=1_700_000_010,
                fetched_at=1_700_000_000,
                candidate_count=2,
                error="TimeoutError",
            ),
        ),
    )
    html = render_dashboard(
        view.currently_reading,
        view.finished,
        view.stats,
        view.wrapped,
        view.recommendations,
        catalog_status=status,
    )
    assert '<details class="source-status" open>' in html
    assert "Public metadata — explicitly enabled" in html
    assert "A source failed; last-good candidates are retained" in html
    assert "Last attempt failed; using last-good candidates." in html
    assert "2023-11-14T22:13:20Z" in html
    assert "TimeoutError" in html
    assert check_html(html) == []


def test_render_data_status_never_refreshed() -> None:
    view = build_view([], [DailyActivity(0, 0, 0)], ())
    html = render_dashboard(
        view.currently_reading,
        view.finished,
        view.stats,
        view.wrapped,
        view.recommendations,
    )
    assert "Data status" in html
    assert "never refreshed" in html
    assert "stacks refresh" in html
    assert 'class="status-note" role="status"' not in html


def test_render_data_status_shows_stamp_and_no_banner_when_fresh() -> None:
    view = build_view([], [DailyActivity(0, 0, 0)], ())
    html = render_dashboard(
        view.currently_reading,
        view.finished,
        view.stats,
        view.wrapped,
        view.recommendations,
        refreshed_at=1_700_000_000,
        stale=False,
    )
    assert "Data status" in html
    assert "2023-11-14T22:13:20Z" in html  # ISO-8601 UTC of the epoch stamp
    assert 'class="status-note" role="status"' not in html


def test_render_data_status_stale_banner_is_visible_text() -> None:
    view = build_view([], [DailyActivity(0, 0, 0)], ())
    html = render_dashboard(
        view.currently_reading,
        view.finished,
        view.stats,
        view.wrapped,
        view.recommendations,
        refreshed_at=1_700_000_000,
        stale=True,
    )
    assert 'role="status"' in html
    assert "Stale" in html  # staleness named in text, not colour-only


# --- R4: descriptor provenance surfaced in the diversity section --------------


def _diversity_section(html: str) -> str:
    start = html.index("Reading diversity")
    return html[start : html.index("</details>", start)]


def test_diversity_provenance_shows_source_and_date(tmp_path: Path) -> None:
    html = render_view(demo_view(tmp_path))
    section = _diversity_section(html)
    # Every diverse-shelf tag shows the source that asserted it and when (R4).
    assert "Per-descriptor provenance" in section
    assert "calibre-tag" in section
    assert "2026-06-05" in section
    # Sensitive descriptors are flagged in text (never colour-only).
    assert "(sensitive)" in section


def test_hide_sensitive_redacts_diversity_section(states: list, candidates: tuple) -> None:
    view = build_view(states, [], candidates, hide_sensitive_descriptors=True)
    html = render_view(view)
    section = _diversity_section(html)
    # Identity-adjacent labels are aggregated out of the diverse-shelf view.
    assert "trans" not in section and "queer" not in section
    assert "aggregated for privacy" in section
    assert "Privacy:" in section
    # The redacted page is still fully accessible (the a11y contract holds).
    assert check_html(html) == []


def test_forecasts_render_a_ranged_estimate() -> None:
    from ingest.models import ReadingStat

    stat = ReadingStat(
        key="k",
        title="Pace Book",
        authors=("Author One",),
        pages_read=100,
        total_pages=300,
        read_time_seconds=3600,
        last_read_ts=1_700_000_000,
        sessions=6,
    )
    state = ReadingState(
        title="Pace Book",
        authors=("Author One",),
        status=ReadingStatus.READING,
        stat=stat,
    )
    # Six recent days with pages read give a solid per-page pace sample
    # (>= MIN_DAYS_FOR_ESTIMATE), so the forecast is estimable.
    daily = [DailyActivity(day_ordinal=d, seconds=600, pages=10) for d in range(1, 7)]
    view = build_view([state], daily, ())

    assert len(view.forecasts) == 1
    forecast = view.forecasts[0].forecast
    assert forecast.estimable
    assert forecast.low_hours > 0
    assert forecast.high_hours >= forecast.low_hours

    html = render_view(view)
    assert "Time to finish" in html
    assert "hours" in html
    assert "from your last" in html  # the window basis is disclosed, never hidden
    assert check_html(html) == []  # the new section is accessible


def test_forecast_without_page_stat_is_honestly_unestimated() -> None:
    # A currently-reading book with no reading stat can't be forecast; it must
    # say so rather than guess (unknown stays first-class).
    state = ReadingState(
        title="No Stats Yet",
        authors=("Author Two",),
        status=ReadingStatus.READING,
    )
    view = build_view([state], [DailyActivity(1, 600, 10)], ())
    assert len(view.forecasts) == 1
    assert not view.forecasts[0].forecast.estimable
    html = render_view(view)
    assert "not enough recent reading to estimate" in html