Skip to content

Commit ffa09d8

Browse files
committed
Pass strings for deletion of user sessions, closes pterodactyl#906
1 parent 47f1c9c commit ffa09d8

File tree

4 files changed

+13
-9
lines changed

4 files changed

+13
-9
lines changed

CHANGELOG.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,11 @@ This file is a running track of new features and fixes to each version of the pa
33

44
This project follows [Semantic Versioning](http://semver.org) guidelines.
55

6-
### v0.7.0-rc.1 (Derelict Dermodactylus)
6+
## v0.7.0-rc.2 (Derelict Dermodactylus)
7+
### Fixed
8+
* `[rc.1]` — Fixes exception thrown when revoking user sessions.
9+
10+
## v0.7.0-rc.1 (Derelict Dermodactylus)
711
### Fixed
812
* `[beta.4]` — Fixes some bad search and replace action that happened previously and was throwing errors when validating user permissions.
913
* `[beta.4]` — Fixes behavior of variable validation to not break the page when no rules are provided.

app/Contracts/Repository/SessionRepositoryInterface.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ public function getUserSessions(int $user): Collection;
1717
/**
1818
* Delete a session for a given user.
1919
*
20-
* @param int $user
21-
* @param int $session
20+
* @param int $user
21+
* @param string $session
2222
* @return null|int
2323
*/
24-
public function deleteUserSession(int $user, int $session);
24+
public function deleteUserSession(int $user, string $session);
2525
}

app/Http/Controllers/Base/SecurityController.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,10 +139,10 @@ public function disableTotp(Request $request)
139139
* Revokes a user session.
140140
*
141141
* @param \Illuminate\Http\Request $request
142-
* @param int $id
142+
* @param string $id
143143
* @return \Illuminate\Http\RedirectResponse
144144
*/
145-
public function revoke(Request $request, $id)
145+
public function revoke(Request $request, string $id)
146146
{
147147
$this->repository->deleteUserSession($request->user()->id, $id);
148148

app/Repositories/Eloquent/SessionRepository.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,11 @@ public function getUserSessions(int $user): Collection
3232
/**
3333
* Delete a session for a given user.
3434
*
35-
* @param int $user
36-
* @param int $session
35+
* @param int $user
36+
* @param string $session
3737
* @return null|int
3838
*/
39-
public function deleteUserSession(int $user, int $session)
39+
public function deleteUserSession(int $user, string $session)
4040
{
4141
return $this->getBuilder()->where('user_id', $user)->where('id', $session)->delete();
4242
}

0 commit comments

Comments
 (0)