Skip to content

Commit fcae6b5

Browse files
committed
remove required default value, update descriptions in seeder
1 parent c2d0a5a commit fcae6b5

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

app/Repositories/ServiceRepository/Variable.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ public function update($id, array $data)
100100
'name' => 'sometimes|required|string|min:1|max:255',
101101
'description' => 'sometimes|required|string',
102102
'env_variable' => 'sometimes|required|regex:/^[\w]{1,255}$/',
103-
'default_value' => 'sometimes|required|string|max:255',
103+
'default_value' => 'sometimes|string|max:255',
104104
'user_viewable' => 'sometimes|required|numeric|size:1',
105105
'user_editable' => 'sometimes|required|numeric|size:1',
106106
'required' => 'sometimes|required|numeric|size:1',
@@ -114,7 +114,7 @@ public function update($id, array $data)
114114
$data['default_value'] = (isset($data['default_value'])) ? $data['default_value'] : $variable->default_value;
115115
$data['regex'] = (isset($data['regex'])) ? $data['regex'] : $variable->regex;
116116

117-
if (!preg_match($data['regex'], $data['default_value'])) {
117+
if ($data['default_value'] !== '' && !preg_match($data['regex'], $data['default_value'])) {
118118
throw new DisplayException('The default value you entered cannot violate the regex requirements.');
119119
}
120120

database/seeds/MinecraftServiceTableSeeder.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ private function addCoreService()
5858
$this->service = Models\Service::create([
5959
'author' => 'ptrdctyl-v040-11e6-8b77-86f30ca893d3',
6060
'name' => 'Minecraft',
61+
'description' => 'Minecraft - the classic game from Mojang. With support for Vanilla MC, Spigot, and many others!',
6162
'file' => 'minecraft',
6263
'executable' => 'java',
6364
'startup' => '-Xms128M -Xmx{{SERVER_MEMORY}}M -jar {{SERVER_JARFILE}}'

database/seeds/SourceServiceTableSeeder.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ private function addCoreService()
5858
$this->service = Models\Service::create([
5959
'author' => 'ptrdctyl-v040-11e6-8b77-86f30ca893d3',
6060
'name' => 'Source Engine',
61+
'description' => 'Includes support for most Source Dedicated Server games.',
6162
'file' => 'srcds',
6263
'executable' => './srcds_run',
6364
'startup' => '-game {{SRCDS_GAME}} -console -port {{SERVER_PORT}} -strictportbind -norestart'

0 commit comments

Comments
 (0)