Fix error handling for large files (and endpoints called as non-json)

Author: DaneEveritt

app/Exceptions/Http/Server/FileSizeTooLargeException.php

@@ -1,16 +1,16 @@
 <?php
-/**
- * Pterodactyl - Panel
- * Copyright (c) 2015 - 2017 Dane Everitt <dane@daneeveritt.com>.
- *
- * This software is licensed under the terms of the MIT license.
- * https://opensource.org/licenses/MIT
- */
 
 namespace Pterodactyl\Exceptions\Http\Server;
 
 use Pterodactyl\Exceptions\DisplayException;
 
 class FileSizeTooLargeException extends DisplayException
 {
+    /**
+     * FileSizeTooLargeException constructor.
+     */
+    public function __construct()
+    {
+        parent::__construct('The file you are attempting to open is too large to view in the file editor.');
+    }
 }

app/Repositories/Wings/DaemonFileRepository.php

@@ -49,9 +49,7 @@ public function getContent(string $path, int $notLargerThan = null): string
         $length = (int) $response->getHeader('Content-Length')[0] ?? 0;
 
         if ($notLargerThan && $length > $notLargerThan) {
-            throw new FileSizeTooLargeException(
-                trans('server.files.exceptions.max_size')
-            );
+            throw new FileSizeTooLargeException;
         }
 
         return $response->getBody()->__toString();

config/pterodactyl.php

@@ -172,7 +172,7 @@
     | This array includes the MIME filetypes that can be edited via the web.
     */
     'files' => [
-        'max_edit_size' => env('PTERODACTYL_FILES_MAX_EDIT_SIZE', 50000),
+        'max_edit_size' => env('PTERODACTYL_FILES_MAX_EDIT_SIZE', 1024 * 512),
         'editable' => [
             'application/json',
             'application/javascript',

resources/scripts/api/http.ts

@@ -29,7 +29,18 @@ export default http;
  */
 export function httpErrorToHuman (error: any): string {
     if (error.response && error.response.data) {
-        const { data } = error.response;
+        let { data } = error.response;
+
+        // Some non-JSON requests can still return the error as a JSON block. In those cases, attempt
+        // to parse it into JSON so we can display an actual error.
+        if (typeof data === 'string') {
+            try {
+                data = JSON.parse(data);
+            } catch (e) {
+                // do nothing, bad json
+            }
+        }
+
         if (data.errors && data.errors[0] && data.errors[0].detail) {
             return data.errors[0].detail;
         }