Replace magic numbers with constants (pterodactyl#754)

* Replace magic numbers with constants

Author: lancepioch

app/Console/Commands/Maintenance/CleanServiceBackupFilesCommand.php

@@ -15,6 +15,8 @@
 
 class CleanServiceBackupFilesCommand extends Command
 {
+    const BACKUP_THRESHOLD_MINUTES = 5;
+
     /**
      * @var \Carbon\Carbon
      */
@@ -58,7 +60,7 @@ public function handle()
 
         collect($files)->each(function ($file) {
             $lastModified = $this->carbon->timestamp($this->disk->lastModified($file));
-            if ($lastModified->diffInMinutes($this->carbon->now()) > 5) {
+            if ($lastModified->diffInMinutes($this->carbon->now()) > self::BACKUP_THRESHOLD_MINUTES) {
                 $this->disk->delete($file);
                 $this->info(trans('command/messages.maintenance.deleting_service_backup', ['file' => $file]));
             }

app/Repositories/Eloquent/NodeRepository.php

@@ -18,6 +18,9 @@ class NodeRepository extends EloquentRepository implements NodeRepositoryInterfa
 {
     use Searchable;
 
+    const THRESHOLD_PERCENTAGE_LOW = 75;
+    const THRESHOLD_PERCENTAGE_MEDIUM = 90;
+
     /**
      * {@inheritdoc}
      */
@@ -56,7 +59,7 @@ public function getUsageStats($id)
                         'value' => number_format($value),
                         'max' => number_format($maxUsage),
                         'percent' => $percent,
-                        'css' => ($percent <= 75) ? 'green' : (($percent > 90) ? 'red' : 'yellow'),
+                        'css' => ($percent <= self::THRESHOLD_PERCENTAGE_LOW) ? 'green' : (($percent > self::THRESHOLD_PERCENTAGE_MEDIUM) ? 'red' : 'yellow'),
                     ],
                 ];
             })

app/Services/Schedules/Tasks/TaskCreationService.php

@@ -16,6 +16,8 @@
 
 class TaskCreationService
 {
+    const MAX_INTERVAL_TIME_SECONDS = 900;
+
     /**
      * @var \Pterodactyl\Contracts\Repository\TaskRepositoryInterface
      */
@@ -50,7 +52,7 @@ public function handle($schedule, array $data, $returnModel = true)
 
         $schedule = ($schedule instanceof Schedule) ? $schedule->id : $schedule;
         $delay = $data['time_interval'] === 'm' ? $data['time_value'] * 60 : $data['time_value'];
-        if ($delay > 900) {
+        if ($delay > self::MAX_INTERVAL_TIME_SECONDS) {
             throw new TaskIntervalTooLongException(trans('exceptions.tasks.chain_interval_too_long'));
         }