Add IP Aliasing (pterodactyl#72)

* complete support for IP Alias's throughout panel

Includes a database change and probably better allocation handling
anyways

closes pterodactyl#37

Author: DaneEveritt

app/Http/Controllers/Admin/ServersController.php

@@ -52,10 +52,17 @@ public function __construct()
     public function getIndex(Request $request)
     {
         return view('admin.servers.index', [
-            'servers' => Models\Server::select('servers.*', 'nodes.name as a_nodeName', 'users.email as a_ownerEmail')
-                ->join('nodes', 'servers.node', '=', 'nodes.id')
-                ->join('users', 'servers.owner', '=', 'users.id')
-                ->paginate(20),
+            'servers' => Models\Server::select(
+                'servers.*',
+                'nodes.name as a_nodeName',
+                'users.email as a_ownerEmail',
+                'allocations.ip',
+                'allocations.port',
+                'allocations.ip_alias'
+            )->join('nodes', 'servers.node', '=', 'nodes.id')
+            ->join('users', 'servers.owner', '=', 'users.id')
+            ->join('allocations', 'servers.allocation', '=', 'allocations.id')
+            ->paginate(20),
         ]);
     }
 
@@ -76,12 +83,16 @@ public function getView(Request $request, $id)
             'locations.long as a_locationName',
             'services.name as a_serviceName',
             'services.executable as a_serviceExecutable',
-            'service_options.name as a_servceOptionName'
+            'service_options.name as a_servceOptionName',
+            'allocations.ip',
+            'allocations.port',
+            'allocations.ip_alias'
         )->join('nodes', 'servers.node', '=', 'nodes.id')
         ->join('users', 'servers.owner', '=', 'users.id')
         ->join('locations', 'nodes.location', '=', 'locations.id')
         ->join('services', 'servers.service', '=', 'services.id')
         ->join('service_options', 'servers.option', '=', 'service_options.id')
+        ->join('allocations', 'servers.allocation', '=', 'allocations.id')
         ->where('servers.id', $id)
         ->first();
 
@@ -91,8 +102,8 @@ public function getView(Request $request, $id)
 
         return view('admin.servers.view', [
             'server' => $server,
-            'assigned' => Models\Allocation::select('id', 'ip', 'port')->where('assigned_to', $id)->orderBy('ip', 'asc')->orderBy('port', 'asc')->get(),
-            'unassigned' => Models\Allocation::select('id', 'ip', 'port')->where('node', $server->node)->whereNull('assigned_to')->orderBy('ip', 'asc')->orderBy('port', 'asc')->get(),
+            'assigned' => Models\Allocation::where('assigned_to', $id)->orderBy('ip', 'asc')->orderBy('port', 'asc')->get(),
+            'unassigned' => Models\Allocation::where('node', $server->node)->whereNull('assigned_to')->orderBy('ip', 'asc')->orderBy('port', 'asc')->get(),
             'startup' => Models\ServiceVariables::select('service_variables.*', 'server_variables.variable_value as a_serverValue')
                 ->join('server_variables', 'server_variables.variable_id', '=', 'service_variables.id')
                 ->where('service_variables.option_id', $server->option)

app/Http/Controllers/Server/AjaxController.php

@@ -194,9 +194,11 @@ public function postSetConnection(Request $request, $uuid)
     {
 
         $server = Server::getByUUID($uuid);
+        $allocation = Models\Allocation::findOrFail($server->allocation);
+
         $this->authorize('set-connection', $server);
 
-        if ($request->input('connection') === $server->ip . ':' . $server->port) {
+        if ($request->input('connection') === $allocation->ip . ':' . $allocation->port) {
             return response()->json([
                 'error' => 'You are already using this as your default connection.'
             ], 409);

app/Http/Controllers/Server/ServerController.php

@@ -195,11 +195,8 @@ public function getDownloadFile(Request $request, $uuid, $file)
     public function getSettings(Request $request, $uuid)
     {
         $server = Models\Server::getByUUID($uuid);
-        // $variables = Models\ServiceVariables::select('service_variables.*', 'server_variables.variable_value as a_serverValue')
-        //     ->join('server_variables', 'server_variables.variable_id', '=', 'service_variables.id')
-        //     ->where('service_variables.option_id', $server->option)
-        //     ->where('server_variables.server_id', $server->id)
-        //     ->get();
+        $allocation = Models\Allocation::findOrFail($server->allocation);
+
         $variables = Models\ServiceVariables::select(
                 'service_variables.*',
                 DB::raw('COALESCE(server_variables.variable_value, service_variables.default_value) as a_serverValue')
@@ -217,8 +214,8 @@ public function getSettings(Request $request, $uuid)
 
         $serverVariables = [
             '{{SERVER_MEMORY}}' => $server->memory,
-            '{{SERVER_IP}}' => $server->ip,
-            '{{SERVER_PORT}}' => $server->port,
+            '{{SERVER_IP}}' => $allocation->ip,
+            '{{SERVER_PORT}}' => $allocation->port,
         ];
 
         $processed = str_replace(array_keys($serverVariables), array_values($serverVariables), $server->startup);

app/Models/Server.php

@@ -124,10 +124,16 @@ protected static function getUserDaemonSecret(Server $server)
     public static function getUserServers($paginate = null)
     {
 
-        $query = self::select('servers.*', 'nodes.name as nodeName', 'locations.short as a_locationShort')
-                    ->join('nodes', 'servers.node', '=', 'nodes.id')
-                    ->join('locations', 'nodes.location', '=', 'locations.id')
-                    ->where('active', 1);
+        $query = self::select(
+            'servers.*',
+            'nodes.name as nodeName',
+            'locations.short as a_locationShort',
+            'allocations.ip_alias',
+            'allocations.port'
+        )->join('nodes', 'servers.node', '=', 'nodes.id')
+        ->join('locations', 'nodes.location', '=', 'locations.id')
+        ->join('allocations', 'servers.allocation', '=', 'allocations.id')
+        ->where('active', 1);
 
         if (self::$user->root_admin !== 1) {
             $query->whereIn('servers.id', Subuser::accessServers());

app/Repositories/ServerRepository.php

@@ -213,8 +213,7 @@ public function create(array $data)
                 'io' => $data['io'],
                 'cpu' => $data['cpu'],
                 'oom_disabled' => (isset($data['oom_disabled'])) ? true : false,
-                'ip' => $data['ip'],
-                'port' => $data['port'],
+                'allocation' => $allocation->id,
                 'service' => $data['service'],
                 'option' => $data['option'],
                 'startup' => $data['startup'],
@@ -253,11 +252,11 @@ public function create(array $data)
                     'user' => $server->username,
                     'build' => [
                         'default' => [
-                            'ip' => $server->ip,
-                            'port' => (int) $server->port
+                            'ip' => $allocation->ip,
+                            'port' => (int) $allocation->port
                         ],
                         'ports' => [
-                            (string) $server->ip => [ (int) $server->port ]
+                            (string) $allocation->ip => [ (int) $allocation->port ]
                         ],
                         'env' => $environmentVariables,
                         'memory' => (int) $server->memory,
@@ -413,17 +412,20 @@ public function changeBuild($id, array $data)
 
         try {
             $server = Models\Server::findOrFail($id);
+            $allocation = Models\Allocation::findOrFail($server->allocation);
 
             if (isset($data['default'])) {
                 list($ip, $port) = explode(':', $data['default']);
-                if ($ip !== $server->ip || $port !== $server->port) {
-                    $allocation = Models\Allocation::where('ip', $ip)->where('port', $port)->where('assigned_to', $server->id)->first();
-                    if (!$allocation) {
+                if ($ip !== $allocation->ip || $port !== $allocation->port) {
+                    $selection = Models\Allocation::where('ip', $ip)->where('port', $port)->where('assigned_to', $server->id)->first();
+                    if (!$selection) {
                         throw new DisplayException('The requested default connection (' . $ip . ':' . $port . ') is not allocated to this server.');
                     }
 
-                    $server->ip = $ip;
-                    $server->port = $port;
+                    $server->allocation = $selection->id;
+
+                    // Re-Run to keep updated for rest of function
+                    $allocation = Models\Allocation::findOrFail($server->allocation);
                 }
             }
 
@@ -437,7 +439,7 @@ public function changeBuild($id, array $data)
                     }
 
                     // Can't remove the assigned IP/Port combo
-                    if ($ip === $server->ip && $port === $server->port) {
+                    if ($ip === $allocation->ip && $port === $allocation->port) {
                         continue;
                     }
 
@@ -513,8 +515,8 @@ public function changeBuild($id, array $data)
                 'json' => [
                     'build' => [
                         'default' => [
-                            'ip' => $server->ip,
-                            'port' => (int) $server->port
+                            'ip' => $allocation->ip,
+                            'port' => (int) $allocation->port
                         ],
                         'ports|overwrite' => $additionalAssignments,
                         'memory' => (int) $server->memory,

database/migrations/2016_08_15_234600_fix_column_name_for_databases.php

@@ -0,0 +1,42 @@
+<?php
+
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Database\Migrations\Migration;
+
+class AddIpAlias extends Migration
+{
+    /**
+     * Run the migrations.
+     *
+     * @return void
+     */
+    public function up()
+    {
+        Schema::table('allocations', function (Blueprint $table) {
+            $table->text('ip_alias')->nullable()->after('ip');
+        });
+
+        $allocations = DB::select('SELECT id, ip FROM allocations');
+        foreach($allocations as $allocation) {
+            DB::update(
+                'UPDATE allocations SET ip_alias = :ip WHERE id = :id',
+                [
+                    'ip' => $allocation->ip,
+                    'id' => $allocation->id
+                ]
+            );
+        }
+    }
+
+    /**
+     * Reverse the migrations.
+     *
+     * @return void
+     */
+    public function down()
+    {
+        Schema::table('allocations', function (Blueprint $table) {
+            $table->dropColumn('ip_alias');
+        });
+    }
+}

database/migrations/2016_08_30_212718_add_ip_alias.php

@@ -0,0 +1,84 @@
+<?php
+
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Database\Migrations\Migration;
+
+class ModifyIpStorageMethod extends Migration
+{
+    /**
+     * Run the migrations.
+     *
+     * @return void
+     */
+    public function up()
+    {
+        Schema::table('servers', function (Blueprint $table) {
+            $table->mediumInteger('allocation')->unsigned()->after('oom_disabled');
+        });
+
+        // Parse All Servers
+        $servers = DB::select('SELECT id, ip, port, node FROM servers');
+        foreach($servers as $server) {
+            $allocation = DB::select(
+                'SELECT id FROM allocations WHERE ip = :ip AND port = :port AND node = :node',
+                [
+                    'ip' => $server->ip,
+                    'port' => $server->port,
+                    'node' => $server->node
+                ]
+            );
+
+            if (isset($allocation[0])) {
+                DB::update(
+                    'UPDATE servers SET allocation = :alocid WHERE id = :id',
+                    [
+                        'alocid' => $allocation[0]->id,
+                        'id' => $server->id
+                    ]
+                );
+            }
+        }
+
+        // Updated the server allocations, remove old fields
+        Schema::table('servers', function (Blueprint $table) {
+            $table->dropColumn('ip');
+            $table->dropColumn('port');
+        });
+
+    }
+
+    /**
+     * Reverse the migrations.
+     *
+     * @return void
+     */
+    public function down()
+    {
+
+        Schema::table('servers', function (Blueprint $table) {
+            $table->text('ip')->after('allocation');
+            $table->integer('port')->unsigned()->after('ip');
+        });
+
+        // Find the allocations and reset the servers...
+        $servers = DB::select('SELECT id, allocation FROM servers');
+        foreach($servers as $server) {
+            $allocation = DB::select('SELECT * FROM allocations WHERE id = :alocid', [ 'alocid' => $server->allocation ]);
+
+            if (isset($allocation[0])) {
+                DB::update(
+                    'UPDATE servers SET ip = :ip, port = :port WHERE id = :id',
+                    [
+                        'ip' => $allocation[0]->ip,
+                        'port' => $allocation[0]->port,
+                        'id' => $server->id
+                    ]
+                );
+            }
+        }
+
+        Schema::table('servers', function (Blueprint $table) {
+            $table->dropColumn('allocation');
+        });
+    }
+}

database/migrations/2016_08_30_213301_modify_ip_storage_method.php

@@ -46,7 +46,7 @@
                     <td><a href="/admin/servers/view/{{ $server->id }}">{{ $server->name }}</td>
                     <td><a href="/admin/users/view/{{ $server->owner }}">{{ $server->a_ownerEmail }}</a></td>
                     <td class="hidden-xs"><a href="/admin/nodes/view/{{ $server->node }}">{{ $server->a_nodeName }}</a></td>
-                    <td><code>{{ $server->ip }}:{{ $server->port }}</code></td>
+                    <td><code>{{ $server->ip_alias }}:{{ $server->port }}</code> @if($server->ip !== $server->ip_alias)<span class="label label-default">alias</span>@endif</td>
                     <td class="hidden-xs"><code>{{ $server->username }}</code></td>
                 </tr>
             @endforeach