Always return the status code from the daemon if possible

Author: DaneEveritt

app/Exceptions/Http/Connection/DaemonConnectionException.php

@@ -22,7 +22,7 @@ class DaemonConnectionException extends DisplayException
      * @param \GuzzleHttp\Exception\GuzzleException $previous
      * @param bool $useStatusCode
      */
-    public function __construct(GuzzleException $previous, bool $useStatusCode = false)
+    public function __construct(GuzzleException $previous, bool $useStatusCode = true)
     {
         /** @var \GuzzleHttp\Psr7\Response|null $response */
         $response = method_exists($previous, 'getResponse') ? $previous->getResponse() : null;

app/Http/Controllers/Api/Client/Servers/FileController.php

@@ -6,13 +6,11 @@
 use Illuminate\Http\Response;
 use Pterodactyl\Models\Server;
 use Illuminate\Http\JsonResponse;
-use GuzzleHttp\Exception\TransferException;
 use Pterodactyl\Services\Nodes\NodeJWTService;
 use Illuminate\Contracts\Routing\ResponseFactory;
 use Pterodactyl\Repositories\Wings\DaemonFileRepository;
 use Pterodactyl\Transformers\Daemon\FileObjectTransformer;
 use Pterodactyl\Http\Controllers\Api\Client\ClientApiController;
-use Pterodactyl\Exceptions\Http\Connection\DaemonConnectionException;
 use Pterodactyl\Http\Requests\Api\Client\Servers\Files\CopyFileRequest;
 use Pterodactyl\Http\Requests\Api\Client\Servers\Files\ListFilesRequest;
 use Pterodactyl\Http\Requests\Api\Client\Servers\Files\DeleteFileRequest;
@@ -70,13 +68,9 @@ public function __construct(
      */
     public function directory(ListFilesRequest $request, Server $server): array
     {
-        try {
-            $contents = $this->fileRepository
-                ->setServer($server)
-                ->getDirectory($request->get('directory') ?? '/');
-        } catch (TransferException $exception) {
-            throw new DaemonConnectionException($exception, true);
-        }
+        $contents = $this->fileRepository
+            ->setServer($server)
+            ->getDirectory($request->get('directory') ?? '/');
 
         return $this->fractal->collection($contents)
             ->transformWith($this->getTransformer(FileObjectTransformer::class))

app/Repositories/Wings/DaemonServerRepository.php

@@ -23,7 +23,7 @@ public function getDetails(): array
                 sprintf('/api/servers/%s', $this->server->uuid)
             );
         } catch (TransferException $exception) {
-            throw new DaemonConnectionException($exception);
+            throw new DaemonConnectionException($exception, false);
         }
 
         return json_decode($response->getBody()->__toString(), true);