Fix single failing test

Author: DaneEveritt

app/Http/Controllers/Api/Remote/Servers/ServerInstallController.php

@@ -4,6 +4,7 @@
 
 use Illuminate\Http\Request;
 use Illuminate\Http\Response;
+use Pterodactyl\Models\Server;
 use Illuminate\Http\JsonResponse;
 use Pterodactyl\Http\Controllers\Controller;
 use Pterodactyl\Repositories\Eloquent\ServerRepository;
@@ -61,10 +62,13 @@ public function store(InstallationDataRequest $request, string $uuid)
     {
         $server = $this->repository->getByUuid($uuid);
 
-        $this->repository->update($server->id, [
-            'installed' => (string) $request->input('successful') === '1' ? 1 : 2,
-        ], true, true);
+        $status = $request->input('successful') === '1' ? null : Server::STATUS_INSTALL_FAILED;
+        if ($server->status === Server::STATUS_SUSPENDED) {
+            $status = Server::STATUS_SUSPENDED
+        }
 
-        return JsonResponse::create([], Response::HTTP_NO_CONTENT);
+        $this->repository->update($server->id, ['status' => $status], true, true);
+
+        return new JsonResponse([], Response::HTTP_NO_CONTENT);
     }
 }

app/Models/Server.php

@@ -129,7 +129,6 @@ class Server extends Model
         'startup' => 'required|string',
         'skip_scripts' => 'sometimes|boolean',
         'image' => 'required|string|max:191',
-        'installed' => 'in:0,1,2',
         'database_limit' => 'present|nullable|integer|min:0',
         'allocation_limit' => 'sometimes|nullable|integer|min:0',
         'backup_limit' => 'present|nullable|integer|min:0',

tests/Unit/Http/Middleware/Server/AccessingValidServerTest.php

@@ -67,7 +67,7 @@ public function testExceptionIsThrownIfServerIsNotInstalled()
         $this->expectException(ConflictHttpException::class);
         $this->expectExceptionMessage('Server is still completing the installation process.');
 
-        $model = factory(Server::class)->make(['installed' => 0]);
+        $model = factory(Server::class)->make(['status' => Server::STATUS_INSTALLING]);
 
         $this->request->shouldReceive('route->parameter')->with('server')->once()->andReturn('123456');
         $this->request->shouldReceive('expectsJson')->withNoArgs()->once()->andReturn(true);