eslint cleanup

Author: DaneEveritt

package.json

@@ -115,6 +115,7 @@
     },
     "scripts": {
         "clean": "rm -rf public/assets/*.{js,css,map}",
+        "lint": "eslint ./resources/scripts/**/*.{ts,tsx} --ext .ts,.tsx",
         "watch": "cross-env NODE_ENV=development ./node_modules/.bin/webpack --watch --progress",
         "build": "cross-env NODE_ENV=development ./node_modules/.bin/webpack --progress",
         "build:production": "yarn run clean && cross-env NODE_ENV=production ./node_modules/.bin/webpack --mode production",

resources/scripts/.eslintrc.yml

@@ -49,7 +49,7 @@ rules:
   "@typescript-eslint/no-explicit-any": 0
   "@typescript-eslint/no-non-null-assertion": 0
   "@typescript-eslint/ban-ts-comment": 0
-  # @todo this would be nice to have, but don't want to deal with the warning spam at the moment.
+  # This would be nice to have, but don't want to deal with the warning spam at the moment.
   "@typescript-eslint/explicit-module-boundary-types": 0
   no-restricted-imports:
     - error
@@ -58,6 +58,8 @@ rules:
           message: Please import from styled-components/macro.
       patterns:
         - "!styled-components/macro"
+  # Not sure, this rule just doesn't work right and is protected by our use of Typescript anyways
+  # so I'm just not going to worry about it.
   "react/prop-types": 0
   "react/display-name": 0
   "react/jsx-indent-props":

resources/scripts/api/account/createApiKey.ts

@@ -3,13 +3,13 @@ import { ApiKey, rawDataToApiKey } from '@/api/account/getApiKeys';
 
 export default (description: string, allowedIps: string): Promise<ApiKey & { secretToken: string }> => {
     return new Promise((resolve, reject) => {
-        http.post(`/api/client/account/api-keys`, {
+        http.post('/api/client/account/api-keys', {
             description,
-            // eslint-disable-next-line @typescript-eslint/camelcase
             allowed_ips: allowedIps.length > 0 ? allowedIps.split('\n') : [],
         })
             .then(({ data }) => resolve({
                 ...rawDataToApiKey(data.attributes),
+                // eslint-disable-next-line camelcase
                 secretToken: data.meta?.secret_token ?? '',
             }))
             .catch(reject);

resources/scripts/api/account/updateAccountPassword.ts

@@ -9,10 +9,8 @@ interface Data {
 export default ({ current, password, confirmPassword }: Data): Promise<void> => {
     return new Promise((resolve, reject) => {
         http.put('/api/client/account/password', {
-            // eslint-disable-next-line @typescript-eslint/camelcase
             current_password: current,
             password: password,
-            // eslint-disable-next-line @typescript-eslint/camelcase
             password_confirmation: confirmPassword,
         })
             .then(() => resolve())

resources/scripts/api/auth/loginCheckpoint.ts

@@ -4,11 +4,9 @@ import { LoginResponse } from '@/api/auth/login';
 export default (token: string, code: string, recoveryToken?: string): Promise<LoginResponse> => {
     return new Promise((resolve, reject) => {
         http.post('/auth/login/checkpoint', {
-            /* eslint-disable @typescript-eslint/camelcase */
             confirmation_token: token,
             authentication_code: code,
             recovery_token: (recoveryToken && recoveryToken.length > 0) ? recoveryToken : undefined,
-            /* eslint-enable @typescript-eslint/camelcase */
         })
             .then(response => resolve({
                 complete: response.data.data.complete,

resources/scripts/api/auth/performPasswordReset.ts

@@ -17,7 +17,6 @@ export default (email: string, data: Data): Promise<PasswordResetResponse> => {
             email,
             token: data.token,
             password: data.password,
-            // eslint-disable-next-line @typescript-eslint/camelcase
             password_confirmation: data.passwordConfirmation,
         })
             .then(response => resolve({

resources/scripts/api/getServers.ts

@@ -3,10 +3,9 @@ import http, { getPaginationSet, PaginatedResult } from '@/api/http';
 
 export default (query?: string, includeAdmin?: boolean): Promise<PaginatedResult<Server>> => {
     return new Promise((resolve, reject) => {
-        http.get(`/api/client`, {
+        http.get('/api/client', {
             params: {
                 include: [ 'allocation' ],
-                // eslint-disable-next-line @typescript-eslint/camelcase
                 filter: includeAdmin ? 'all' : undefined,
                 query,
             },

resources/scripts/api/getSystemPermissions.ts

@@ -3,7 +3,7 @@ import http from '@/api/http';
 
 export default (): Promise<PanelPermissions> => {
     return new Promise((resolve, reject) => {
-        http.get(`/api/client/permissions`)
+        http.get('/api/client/permissions')
             .then(({ data }) => resolve(data.attributes.permissions))
             .catch(reject);
     });

resources/scripts/api/http.ts

@@ -5,7 +5,7 @@ const http: AxiosInstance = axios.create({
     timeout: 20000,
     headers: {
         'X-Requested-With': 'XMLHttpRequest',
-        'Accept': 'application/json',
+        Accept: 'application/json',
         'Content-Type': 'application/json',
         'X-CSRF-Token': (window as any).X_CSRF_TOKEN as string || '',
     },

resources/scripts/api/server/files/renameFile.ts

@@ -8,9 +8,7 @@ interface Data {
 export default (uuid: string, { renameFrom, renameTo }: Data): Promise<void> => {
     return new Promise((resolve, reject) => {
         http.put(`/api/client/servers/${uuid}/files/rename`, {
-            // eslint-disable-next-line @typescript-eslint/camelcase
             rename_from: renameFrom,
-            // eslint-disable-next-line @typescript-eslint/camelcase
             rename_to: renameTo,
         })
             .then(() => resolve())