Fix database naming conventions; closes pterodactyl#2404

Author: DaneEveritt

app/Http/Requests/Api/Client/Servers/Databases/StoreDatabaseRequest.php

@@ -22,7 +22,7 @@ public function permission(): string
     public function rules(): array
     {
         return [
-            'database' => 'required|alpha_dash|min:1|max:100',
+            'database' => 'required|alpha_dash|min:3|max:48',
             'remote' => 'required|string|regex:/^[0-9%.]{1,15}$/',
         ];
     }

app/Models/Database.php

@@ -65,7 +65,7 @@ class Database extends Model
     public static $validationRules = [
         'server_id' => 'required|numeric|exists:servers,id',
         'database_host_id' => 'required|exists:database_hosts,id',
-        'database' => 'required|string|alpha_dash|between:3,100',
+        'database' => 'required|string|alpha_dash|between:3,48',
         'username' => 'string|alpha_dash|between:3,100',
         'max_connections' => 'nullable|integer',
         'remote' => 'required|string|regex:/^[0-9%.]{1,15}$/',

app/Services/Databases/DatabaseManagementService.php

@@ -104,9 +104,12 @@ public function create(Server $server, array $data)
             }
         }
 
+        // Max of 48 characters, including the s123_ that we append to the front.
+        $truncatedName = substr($data['database'], 0, 48 - strlen("s{$server->id}_"));
+
         $data = array_merge($data, [
             'server_id' => $server->id,
-            'database' => sprintf('s%d_%s', $server->id, $data['database']),
+            'database' => $truncatedName,
             'username' => sprintf('u%d_%s', $server->id, str_random(10)),
             'password' => $this->encrypter->encrypt(
                 Utilities::randomStringWithSpecialCharacters(24)

resources/scripts/components/server/databases/CreateDatabaseButton.tsx

@@ -19,9 +19,9 @@ interface Values {
 const schema = object().shape({
     databaseName: string()
         .required('A database name must be provided.')
-        .min(5, 'Database name must be at least 5 characters.')
-        .max(64, 'Database name must not exceed 64 characters.')
-        .matches(/^[A-Za-z0-9_\-.]{5,64}$/, 'Database name should only contain alphanumeric characters, underscores, dashes, and/or periods.'),
+        .min(3, 'Database name must be at least 3 characters.')
+        .max(48, 'Database name must not exceed 48 characters.')
+        .matches(/^[A-Za-z0-9_\-.]{3,48}$/, 'Database name should only contain alphanumeric characters, underscores, dashes, and/or periods.'),
     connectionsFrom: string()
         .required('A connection value must be provided.')
         .matches(/^([1-9]{1,3}|%)(\.([0-9]{1,3}|%))?(\.([0-9]{1,3}|%))?(\.([0-9]{1,3}|%))?$/, 'A valid connection address must be provided.'),