Skip to content

Commit b539f26

Browse files
committed
Stop browser autofill on user view pages.
1 parent 6dc1c15 commit b539f26

File tree

2 files changed

+15
-7
lines changed

2 files changed

+15
-7
lines changed

app/Http/Controllers/Admin/UserController.php

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -141,12 +141,20 @@ public function store(Request $request)
141141
*/
142142
public function update(Request $request, $id)
143143
{
144-
try {
145-
$repo = new UserRepository;
146-
$user = $repo->update($id, $request->intersect([
144+
// Rename variables because autofill cannot be disabled
145+
// in any logical manner, and editing users is impossible.
146+
$fixedData = array_filter(
147+
collect($request->all())->mapWithKeys(function ($item, $key) {
148+
return [str_replace('input_', '', $key) => $item];
149+
})->only([
147150
'email', 'password', 'name_first',
148151
'name_last', 'username', 'root_admin',
149-
]));
152+
])->toArray()
153+
);
154+
155+
try {
156+
$repo = new UserRepository;
157+
$user = $repo->update($id, $fixedData);
150158
Alert::success('User account was successfully updated.')->flash();
151159
} catch (DisplayValidationException $ex) {
152160
return redirect()->route('admin.users.view', $id)->withErrors(json_decode($ex->getMessage()));

resources/themes/pterodactyl/admin/users/view.blade.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,13 @@
4444
<div class="form-group">
4545
<label for="email" class="control-label">Email</label>
4646
<div>
47-
<input type="text" name="email" value="{{ $user->email }}" class="form-control">
47+
<input type="email" name="input_email" value="{{ $user->email }}" class="form-control">
4848
</div>
4949
</div>
5050
<div class="form-group">
5151
<label for="registered" class="control-label">Username</label>
5252
<div>
53-
<input type="text" name="username" value="{{ $user->username }}" class="form-control">
53+
<input type="text" name="input_username" value="{{ $user->username }}" class="form-control">
5454
</div>
5555
</div>
5656
<div class="form-group">
@@ -82,7 +82,7 @@
8282
<div class="form-group">
8383
<label for="password" class="control-label">Password</label>
8484
<div>
85-
<input type="password" id="password" name="password" class="form-control">
85+
<input type="password" id="password" name="input_password" class="form-control">
8686
</div>
8787
</div>
8888
</div>

0 commit comments

Comments
 (0)