Throw exception if no allocation is there.

DaneEveritt · DaneEveritt · commit b2cd7cc5c94c · 2016-09-28T17:32:11.000-04:00
diff --git a/app/Services/DeploymentService.php b/app/Services/DeploymentService.php
@@ -104,7 +104,12 @@ public static function smartRandomNode($memory, $disk, $location = null) {
      */
     public static function randomAllocation($node)
     {
-        return Models\Allocation::where('node', $node)->whereNull('assigned_to')->inRandomOrder()->first();
+        $allocation = Models\Allocation::where('node', $node)->whereNull('assigned_to')->inRandomOrder()->first();
+        if (!$allocation) {
+            throw new DisplayException('No available allocation could be found for the assigned node.');
+        }
+
+        return $allocation;
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,12 @@ public static function smartRandomNode($memory, $disk, $location = null) {`
`104`	`104`	`*/`
`105`	`105`	`public static function randomAllocation($node)`
`106`	`106`	`{`
`107`		`- return Models\Allocation::where('node', $node)->whereNull('assigned_to')->inRandomOrder()->first();`
	`107`	`+ $allocation = Models\Allocation::where('node', $node)->whereNull('assigned_to')->inRandomOrder()->first();`
	`108`	`+ if (!$allocation) {`
	`109`	`+ throw new DisplayException('No available allocation could be found for the assigned node.');`
	`110`	`+ }`
	`111`	`+`
	`112`	`+ return $allocation;`
`108`	`113`	`}`
`109`	`114`
`110`	`115`	`/**`