Skip to content

Commit b08d6a4

Browse files
committed
Make config caching less aggressive
1 parent acdc78e commit b08d6a4

File tree

5 files changed

+2
-14
lines changed

5 files changed

+2
-14
lines changed

app/Console/Commands/Environment/AppSettingsCommand.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,6 @@ public function handle()
114114
$this->checkForRedis();
115115
$this->writeToEnvironment($this->variables);
116116

117-
$this->command->call('config:cache');
118117
$this->info($this->command->output());
119118
}
120119

app/Console/Commands/Environment/DatabaseSettingsCommand.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,6 @@ public function handle()
122122

123123
$this->writeToEnvironment($this->variables);
124124

125-
$this->console->call('config:cache');
126125
$this->info($this->console->output());
127126

128127
return 0;

app/Console/Commands/Environment/EmailSettingsCommand.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@ public function handle()
9292
$this->writeToEnvironment($this->variables);
9393

9494
$this->line('Updating stored environment configuration file.');
95-
$this->call('config:cache');
9695
$this->line('');
9796
}
9897

composer.json

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -68,21 +68,13 @@
6868
}
6969
},
7070
"scripts": {
71-
"pre-install-cmd": [
72-
"rm -f bootstrap/cache/services.php bootstrap/cache/compiled.php"
73-
],
74-
"pre-update-cmd": [
75-
"rm -f bootstrap/cache/services.php bootstrap/cache/compiled.php"
76-
],
7771
"post-install-cmd": [
7872
"Illuminate\\Foundation\\ComposerScripts::postInstall",
79-
"php artisan optimize",
80-
"php artisan config:cache"
73+
"php artisan optimize"
8174
],
8275
"post-update-cmd": [
8376
"Illuminate\\Foundation\\ComposerScripts::postUpdate",
84-
"php artisan optimize",
85-
"php artisan config:cache"
77+
"php artisan optimize"
8678
]
8779
},
8880
"prefer-stable": true,

tests/Unit/Commands/Environment/EmailSettingsCommandTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -276,6 +276,5 @@ private function setupCoreFunctions(array $data)
276276
{
277277
$this->config->shouldReceive('get')->withAnyArgs()->zeroOrMoreTimes()->andReturnNull();
278278
$this->command->shouldReceive('writeToEnvironment')->with($data)->once()->andReturnNull();
279-
$this->command->shouldReceive('call')->with('config:cache')->once()->andReturnNull();
280279
}
281280
}

0 commit comments

Comments
 (0)