Use the cache tags correctly.

Author: DaneEveritt

app/Http/Controllers/Admin/NodesController.php

@@ -366,7 +366,7 @@ public function setToken(Request $request, $id)
         $node = Models\Node::findOrFail($id);
 
         $token = str_random(32);
-        Cache::put('NodeConfiguration:' . $token, $node->id, 5);
+        Cache::tags(['Node:Configuration'])->put($token, $node->id, 5);
 
         return response()->json(['token' => $token]);
     }

app/Http/Controllers/Daemon/ActionController.php

@@ -40,7 +40,7 @@ class ActionController extends Controller
      */
     public function authenticateDownload(Request $request)
     {
-        $download = Cache::pull('Download:' . $request->input('token'));
+        $download = Cache::tags(['Server:Downloads'])->pull($request->input('token'));
 
         if (is_null($download)) {
             return response()->json([
@@ -81,7 +81,7 @@ public function markInstall(Request $request)
         $server->installed = ($status === 'installed') ? 1 : 2;
         $server->save();
 
-        return response('', 204);
+        return response()->json([]);
     }
 
     /**
@@ -93,7 +93,7 @@ public function markInstall(Request $request)
      */
     public function configuration(Request $request, $token)
     {
-        $nodeId = Cache::pull('NodeConfiguration:' . $token);
+        $nodeId = Cache::tags(['Node:Configuration'])->pull($token);
         if (is_null($nodeId)) {
             return response()->json(['error' => 'token_invalid'], 403);
         }

app/Http/Controllers/Server/ServerController.php

@@ -202,10 +202,10 @@ public function getDownloadFile(Request $request, $uuid, $file)
         $this->authorize('download-files', $server);
 
         $token = str_random(40);
-        Cache::tags(['Downloads', 'Downloads:Server:' . $server->uuid])->put('Download:' . $token, [
+        Cache::tags(['Server:Downloads'])->put($token, [
             'server' => $server->uuid,
             'path' => $file,
-        ], 1);
+        ], 5);
 
         return redirect($server->node->scheme . '://' . $server->node->fqdn . ':' . $server->node->daemonListen . '/server/file/download/' . $token);
     }