Respect pagination settings on frontend

closes pterodactyl#1335

Author: DaneEveritt

CHANGELOG.md

@@ -9,6 +9,7 @@ This project follows [Semantic Versioning](http://semver.org) guidelines.
 * TS3 egg updated to use CLI arguments correctly and have a more minimalistic installation script.
 * Terminal was not properly displaying longer lines leading to some visual inconsistency.
 * Assorted translation updates.
+* Pagination for server listing now properly respects configuration setting.
 
 ### Changed
 * Removed PhraseApp integration from Panel code as it is no longer used.

app/Contracts/Repository/ServerRepositoryInterface.php

@@ -103,10 +103,10 @@ public function getDaemonServiceData(Server $server, bool $refresh = false): arr
      *
      * @param \Pterodactyl\Models\User $user
      * @param int                      $level
-     * @param bool                     $paginate
+     * @param bool|int                 $paginate
      * @return \Illuminate\Pagination\LengthAwarePaginator|\Illuminate\Database\Eloquent\Collection
      */
-    public function filterUserAccessServers(User $user, int $level, bool $paginate = true);
+    public function filterUserAccessServers(User $user, int $level, $paginate = 25);
 
     /**
      * Return a server by UUID.

app/Http/Controllers/Api/Client/ClientController.php

@@ -35,7 +35,7 @@ public function __construct(ServerRepositoryInterface $repository)
      */
     public function index(GetServersRequest $request): array
     {
-        $servers = $this->repository->filterUserAccessServers($request->user(), User::FILTER_LEVEL_SUBUSER);
+        $servers = $this->repository->filterUserAccessServers($request->user(), User::FILTER_LEVEL_SUBUSER, config('pterodactyl.paginate.frontend.servers'));
 
         return $this->fractal->collection($servers)
             ->transformWith($this->getTransformer(ServerTransformer::class))

app/Http/Controllers/Base/IndexController.php

@@ -56,7 +56,7 @@ public function __construct(
     public function getIndex(Request $request)
     {
         $servers = $this->repository->setSearchTerm($request->input('query'))->filterUserAccessServers(
-            $request->user(), User::FILTER_LEVEL_ALL
+            $request->user(), User::FILTER_LEVEL_ALL, config('pterodactyl.paginate.frontend.servers')
         );
 
         return view('base.index', ['servers' => $servers]);

app/Repositories/Eloquent/ServerRepository.php

@@ -211,10 +211,10 @@ public function getDaemonServiceData(Server $server, bool $refresh = false): arr
      *
      * @param \Pterodactyl\Models\User $user
      * @param int                      $level
-     * @param bool                     $paginate
+     * @param bool|int                 $paginate
      * @return \Illuminate\Contracts\Pagination\LengthAwarePaginator|\Illuminate\Database\Eloquent\Collection
      */
-    public function filterUserAccessServers(User $user, int $level, bool $paginate = true)
+    public function filterUserAccessServers(User $user, int $level, $paginate = 25)
     {
         $instance = $this->getBuilder()->select($this->getColumns())->with(['user', 'node', 'allocation']);
 
@@ -240,7 +240,7 @@ public function filterUserAccessServers(User $user, int $level, bool $paginate =
 
         $instance->search($this->getSearchTerm());
 
-        return $paginate ? $instance->paginate(25) : $instance->get();
+        return $paginate ? $instance->paginate($paginate) : $instance->get();
     }
 
     /**