Merge pull request pterodactyl#608 from Pterodactyl/feature/PTDL-472

Merge code refactor into develop.

Author: DaneEveritt

.dev/vagrant/motd.txt

@@ -13,5 +13,5 @@ Default panel users:
 
 MySQL is accessible using root/pterodactyl or pterodactyl/pterodactyl
 
-Services for pteroq and mailhog are running
+Service for pteroq and mailhog are running
 #####################################################

.env.example

@@ -24,10 +24,6 @@ MAIL_PASSWORD=null
 MAIL_ENCRYPTION=null
 MAIL_FROM=you@example.com
 
-API_PREFIX=api
-API_VERSION=v1
-API_DEBUG=false
-
 QUEUE_DRIVER=database
 QUEUE_HIGH=high
 QUEUE_STANDARD=standard

.env.travis

@@ -0,0 +1,16 @@
+APP_ENV=testing
+APP_DEBUG=true
+APP_KEY=SomeRandomString3232RandomString
+APP_THEME=pterodactyl
+APP_TIMEZONE=UTC
+APP_URL=http://localhost/
+
+DB_HOST=127.0.0.1
+DB_DATABASE=travis
+DB_USERNAME=root
+DB_PASSWORD=""
+
+CACHE_DRIVER=array
+SESSION_DRIVER=array
+MAIL_DRIVER=array
+QUEUE_DRIVER=sync

.gitignore

@@ -23,3 +23,4 @@ docker-compose.yml
 # for image related files
 misc
 .phpstorm.meta.php
+.php_cs.cache

.php_cs

@@ -1,7 +1,41 @@
 <?php
 
-require_once __DIR__ . '/vendor/sllh/php-cs-fixer-styleci-bridge/autoload.php';
+$finder = PhpCsFixer\Finder::create()
+    ->in([
+        'app',
+        'bootstrap',
+        'config',
+        'database',
+        'resources/lang',
+        'routes',
+        'tests',
+    ]);
 
-use SLLH\StyleCIBridge\ConfigBridge;
-
-return ConfigBridge::create();
+return PhpCsFixer\Config::create()
+    ->setRules([
+        '@Symfony' => true,
+        '@PSR1' => true,
+        '@PSR2' => true,
+        'align_multiline_comment' => ['comment_type' => 'phpdocs_like'],
+        'array_syntax' => ['syntax' => 'short'],
+        'blank_line_before_return' => true,
+        'blank_line_before_statement' => false,
+        'combine_consecutive_unsets' => true,
+        'concat_space' => ['spacing' => 'one'],
+        'declare_equal_normalize' => ['space' => 'single'],
+        'heredoc_to_nowdoc' => true,
+        'linebreak_after_opening_tag' => true,
+        'new_with_braces' => false,
+        'no_alias_functions' => true,
+        'no_multiline_whitespace_before_semicolons' => true,
+        'no_unreachable_default_argument_value' => true,
+        'no_useless_return' => true,
+        'not_operator_with_successor_space' => true,
+        'phpdoc_align' => ['tags' => ['param']],
+        'phpdoc_separation' => false,
+        'protected_to_private' => false,
+        'psr0' => ['dir' => 'app'],
+        'psr4' => true,
+        'random_api_migration' => true,
+        'standardize_not_equals' => true,
+    ])->setRiskyAllowed(true)->setFinder($finder);

.styleci.yml

@@ -4,3 +4,4 @@ disabled:
   - concat_without_spaces
 enabled:
   - concat_with_spaces
+  - no_unused_imports

.travis.yml

@@ -0,0 +1,24 @@
+language: php
+dist: trusty
+php:
+  - '7.0'
+  - '7.1'
+  - '7.2'
+sudo: false
+cache:
+  directories:
+    - $HOME/.composer/cache
+services:
+  - mysql
+before_install:
+  - mysql -e 'CREATE DATABASE IF NOT EXISTS travis;'
+before_script:
+  - cp .env.travis .env
+  - composer install --no-interaction --prefer-dist --no-suggest --verbose
+  - php artisan migrate --seed -v
+script:
+  - vendor/bin/phpunit --coverage-clover coverage.xml
+notifications:
+  email: false
+after_success:
+  - bash <(curl -s https://codecov.io/bash)

CHANGELOG.md

@@ -246,7 +246,7 @@ spatie/laravel-fractal (4.0.0 => 4.0.1)
 * New theme applied to Admin CP. Many graphical changes were made, some data was moved around and some display data changed. Too much was changed to feasibly log it all in here. Major breaking changes or notable new features will be logged.
 * New server creation page now makes significantly less AJAX calls and is much quicker to respond.
 * Server and Node view pages wee modified to split tabs into individual pages to make re-themeing and modifications significantly easier, and reduce MySQL query loads on page.
-* `[pre.4]` — Services and Pack magement overhauled to be faster, cleaner, and more extensible in the future.
+* `[pre.4]` — Service and Pack magement overhauled to be faster, cleaner, and more extensible in the future.
 * Most of the backend `UnhandledException` display errors now include a clearer error that directs admins to the program's logs.
 * Table seeders for services now can be run during upgrades and will attempt to locate and update, or create new if not found in the database.
 * Many structural changes to the database and `Pterodactyl\Models` classes that would flood this changelog if they were all included. All required migrations included to handle database changes.

app/Console/Commands/AddLocation.php

@@ -31,12 +31,12 @@ class AddLocation extends Command
 {
     protected $data = [];
 
-     /**
-      * The name and signature of the console command.
-      *
-      * @var string
-      */
-     protected $signature = 'pterodactyl:location
+    /**
+     * The name and signature of the console command.
+     *
+     * @var string
+     */
+    protected $signature = 'pterodactyl:location
                              {--short= : The shortcode name of this location (ex. us1).}
                              {--long= : A longer description of this location.}';
 
@@ -49,8 +49,6 @@ class AddLocation extends Command
 
     /**
      * Create a new command instance.
-     *
-     * @return void
      */
     public function __construct()
     {

app/Console/Commands/AddNode.php

@@ -57,8 +57,6 @@ class AddNode extends Command
 
     /**
      * Create a new command instance.
-     *
-     * @return void
      */
     public function __construct()
     {