closes pterodactyl#991

Author: DaneEveritt

CHANGELOG.md

@@ -3,6 +3,10 @@ This file is a running track of new features and fixes to each version of the pa
 
 This project follows [Semantic Versioning](http://semver.org) guidelines.
 
+## v0.7.4 (Derelict Dermodactylus)
+### Fixed
+* Fixes a bug when reinstalling a server that would not mark the server as installing, resulting in some UI issues.
+
 ## v0.7.3 (Derelict Dermodactylus)
 ### Fixed
 * Fixes server creation API endpoint not passing the provided `external_id` to the creation service.

app/Services/Servers/ReinstallServerService.php

@@ -66,7 +66,7 @@ public function reinstall($server)
         $this->database->beginTransaction();
         $this->repository->withoutFreshModel()->update($server->id, [
             'installed' => 0,
-        ]);
+        ], true, true);
 
         try {
             $this->daemonServerRepository->setServer($server)->reinstall();

tests/Unit/Services/Servers/ReinstallServerServiceTest.php

@@ -81,10 +81,9 @@ public function testServerShouldBeReinstalledWhenModelIsPassed()
         $this->repository->shouldNotReceive('find');
 
         $this->database->shouldReceive('beginTransaction')->withNoArgs()->once()->andReturnNull();
-        $this->repository->shouldReceive('withoutFreshModel')->withNoArgs()->once()->andReturnSelf()
-            ->shouldReceive('update')->with($this->server->id, [
-                'installed' => 0,
-            ])->once()->andReturnNull();
+        $this->repository->shouldReceive('withoutFreshModel->update')->with($this->server->id, [
+            'installed' => 0,
+        ], true, true)->once()->andReturnNull();
 
         $this->daemonServerRepository->shouldReceive('setServer')->with($this->server)->once()->andReturnSelf()
             ->shouldReceive('reinstall')->withNoArgs()->once()->andReturn(new Response);
@@ -101,10 +100,9 @@ public function testServerShouldBeReinstalledWhenServerIdIsPassed()
         $this->repository->shouldReceive('find')->with($this->server->id)->once()->andReturn($this->server);
 
         $this->database->shouldReceive('beginTransaction')->withNoArgs()->once()->andReturnNull();
-        $this->repository->shouldReceive('withoutFreshModel')->withNoArgs()->once()->andReturnSelf()
-            ->shouldReceive('update')->with($this->server->id, [
-                'installed' => 0,
-            ])->once()->andReturnNull();
+        $this->repository->shouldReceive('withoutFreshModel->update')->with($this->server->id, [
+            'installed' => 0,
+        ], true, true)->once()->andReturnNull();
 
         $this->daemonServerRepository->shouldReceive('setServer')->with($this->server)->once()->andReturnSelf()
             ->shouldReceive('reinstall')->withNoArgs()->once()->andReturn(new Response);
@@ -121,10 +119,9 @@ public function testServerShouldBeReinstalledWhenServerIdIsPassed()
     public function testExceptionThrownByGuzzleShouldBeReRenderedAsDisplayable()
     {
         $this->database->shouldReceive('beginTransaction')->withNoArgs()->once()->andReturnNull();
-        $this->repository->shouldReceive('withoutFreshModel')->withNoArgs()->once()->andReturnSelf()
-            ->shouldReceive('update')->with($this->server->id, [
-                'installed' => 0,
-            ])->once()->andReturnNull();
+        $this->repository->shouldReceive('withoutFreshModel->update')->with($this->server->id, [
+            'installed' => 0,
+        ], true, true)->once()->andReturnNull();
 
         $this->daemonServerRepository->shouldReceive('setServer')->with($this->server)->once()->andThrow($this->exception);
 
@@ -139,10 +136,9 @@ public function testExceptionThrownByGuzzleShouldBeReRenderedAsDisplayable()
     public function testExceptionNotThrownByGuzzleShouldNotBeTransformedToDisplayable()
     {
         $this->database->shouldReceive('beginTransaction')->withNoArgs()->once()->andReturnNull();
-        $this->repository->shouldReceive('withoutFreshModel')->withNoArgs()->once()->andReturnSelf()
-            ->shouldReceive('update')->with($this->server->id, [
-                'installed' => 0,
-            ])->once()->andReturnNull();
+        $this->repository->shouldReceive('withoutFreshModel->update')->with($this->server->id, [
+            'installed' => 0,
+        ], true, true)->once()->andReturnNull();
 
         $this->daemonServerRepository->shouldReceive('setServer')->with($this->server)->once()->andThrow(new Exception());