replace manual json headers with laravel response()->json()

better Carbon dependency
rename admin.nodes.configuration-token route
style fixes

Author: schrej

app/Http/Controllers/Admin/NodesController.php

@@ -27,8 +27,8 @@
 use DB;
 use Log;
 use Alert;
+use Carbon;
 use Validator;
-use Carbon\Carbon;
 use Pterodactyl\Models;
 use Illuminate\Http\Request;
 use Pterodactyl\Exceptions\DisplayException;
@@ -296,7 +296,6 @@ public function getConfigurationToken(Request $request, $id)
             'expires_at' => $token->expires_at->toDateTimeString(),
         ];
 
-        return response(json_encode($token_response), 200)
-            ->header('Content-Type', 'application/json');
+        return response()->json($token_response, 200);
     }
 }

app/Http/Controllers/Remote/RemoteController.php

@@ -116,21 +116,20 @@ public function getConfiguration(Request $request, $tokenString)
             $token = Models\NodeConfigurationToken::where('token', $tokenString)->firstOrFail();
             $node = Models\Node::findOrFail($token->node);
         } catch (\Illuminate\Database\Eloquent\ModelNotFoundException $e) {
-            return response(json_encode(['error' => 'token_invalid']), 403)
-                ->header('Content-Type', 'application/json');
+            return response()->json(['error' => 'token_invalid'], 403);
         }
 
         // Check if token is expired
         if ($token->expires_at->lt(Carbon::now())) {
             $token->delete();
 
-            return response(json_encode(['error' => 'token_expired']), 403)
-                ->header('Content-Type', 'application/json');
+            return response()->json(['error' => 'token_expired'], 403);
         }
 
         // Delete the token, it's one-time use
         $token->delete();
 
+        // Manually as getConfigurationAsJson() returns it in correct format already
         return response($node->getConfigurationAsJson(), 200)
             ->header('Content-Type', 'application/json');
     }

app/Http/Routes/AdminRoutes.php

@@ -288,7 +288,7 @@ public function map(Router $router)
             ]);
 
             $router->get('/{id}/configurationtoken', [
-                'as' => 'admin.nodes.configurationtoken',
+                'as' => 'admin.nodes.configuration-token',
                 'uses' => 'Admin\NodesController@getConfigurationToken',
             ]);
         });

database/migrations/2017_01_07_154228_create_node_configuration_tokens_table.php

@@ -18,8 +18,7 @@ public function up()
             $table->char('token', 32);
             $table->timestamp('expires_at');
             $table->integer('node')->unsigned();
-            $table->foreign('node')
-                ->references('id')->on('nodes');
+            $table->foreign('node')->references('id')->on('nodes');
             $table->timestamps();
         });
     }

resources/views/admin/nodes/view.blade.php

@@ -502,7 +502,7 @@
     });
 
     $('#configTokenBtn').on('click', function (event) {
-        $.getJSON('{{ route('admin.nodes.configurationtoken', $node->id) }}')
+        $.getJSON('{{ route('admin.nodes.configuration-token', $node->id) }}')
             .done(function (data) {
                 swal({
                     type: 'success',