Merge pull request pterodactyl#3072 from pterodactyl/matthewpi/fix-server-installs

DaneEveritt · web-flow · commit 9af1b9c3ac94 · 2021-02-08T10:04:45.000-08:00
api(remote): fix inproper reading of boolean for installation status
diff --git a/app/Http/Controllers/Api/Remote/Servers/ServerInstallController.php b/app/Http/Controllers/Api/Remote/Servers/ServerInstallController.php
@@ -56,7 +56,7 @@ public function store(InstallationDataRequest $request, string $uuid)
     {
         $server = $this->repository->getByUuid($uuid);
 
-        $status = $request->input('successful') === '1' ? null : Server::STATUS_INSTALL_FAILED;
+        $status = $request->boolean('successful') ? null : Server::STATUS_INSTALL_FAILED;
         if ($server->status === Server::STATUS_SUSPENDED) {
             $status = Server::STATUS_SUSPENDED;
         }

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ public function store(InstallationDataRequest $request, string $uuid)`
`56`	`56`	`{`
`57`	`57`	`$server = $this->repository->getByUuid($uuid);`
`58`	`58`
`59`		`- $status = $request->input('successful') === '1' ? null : Server::STATUS_INSTALL_FAILED;`
	`59`	`+ $status = $request->boolean('successful') ? null : Server::STATUS_INSTALL_FAILED;`
`60`	`60`	`if ($server->status === Server::STATUS_SUSPENDED) {`
`61`	`61`	`$status = Server::STATUS_SUSPENDED;`
`62`	`62`	`}`