fix: EnvironmentWriterTrait not allowing null values

matthewpi · matthewpi · commit 871ef0c56412 · 2025-02-14T13:22:59.000-07:00
Fixes pterodactyl#5108 Signed-off-by: Matthew Penner <me@matthewp.io>
diff --git a/app/Traits/Commands/EnvironmentWriterTrait.php b/app/Traits/Commands/EnvironmentWriterTrait.php
@@ -11,8 +11,12 @@ trait EnvironmentWriterTrait
      * reasonably cause environment parsing issues. Those values are then wrapped
      * in quotes before being returned.
      */
-    public function escapeEnvironmentValue(string $value): string
+    public function escapeEnvironmentValue(?string $value): string
     {
+        if (is_null($value)) {
+            return '';
+        }
+
         if (!preg_match('/^\"(.*)\"$/', $value) && preg_match('/([^\w.\-+\/])+/', $value)) {
             return sprintf('"%s"', addslashes($value));
         }

Original file line number	Diff line number	Diff line change
`@@ -11,8 +11,12 @@ trait EnvironmentWriterTrait`
`11`	`11`	`* reasonably cause environment parsing issues. Those values are then wrapped`
`12`	`12`	`* in quotes before being returned.`
`13`	`13`	`*/`
`14`		`- public function escapeEnvironmentValue(string $value): string`
	`14`	`+ public function escapeEnvironmentValue(?string $value): string`
`15`	`15`	`{`
	`16`	`+ if (is_null($value)) {`
	`17`	`+ return '';`
	`18`	`+ }`
	`19`	`+`
`16`	`20`	`if (!preg_match('/^\"(.*)\"$/', $value) && preg_match('/([^\w.\-+\/])+/', $value)) {`
`17`	`21`	`return sprintf('"%s"', addslashes($value));`
`18`	`22`	`}`