Merge pull request pterodactyl#2801 from pterodactyl/issue/2800

Delete the oldest backup, not the newest backup

Author: DaneEveritt

app/Services/Backups/InitiateBackupService.php

@@ -13,7 +13,6 @@
 use Pterodactyl\Repositories\Wings\DaemonBackupRepository;
 use Pterodactyl\Exceptions\Service\Backup\TooManyBackupsException;
 use Symfony\Component\HttpKernel\Exception\TooManyRequestsHttpException;
-use Pterodactyl\Services\Backups\DeleteBackupService;
 
 class InitiateBackupService
 {
@@ -124,8 +123,11 @@ public function handle(Server $server, string $name = null, bool $override = fal
                 throw new TooManyBackupsException($server->backup_limit);
             }
 
-            // Remove oldest backup
-            $oldestBackup = $server->backups()->where('is_successful', true)->orderByDesc('created_at')->first();
+            // Get the oldest backup the server has.
+            /** @var \Pterodactyl\Models\Backup $oldestBackup */
+            $oldestBackup = $server->backups()->where('is_successful', true)->orderBy('created_at')->first();
+
+            // Delete the oldest backup.
             $this->deleteBackupService->handle($oldestBackup);
         }